| Message ID | 1394703425-6462-3-git-send-email-k.kozlowski@samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Krzysztof, On 13.03.2014 10:37, Krzysztof Kozlowski wrote: > Add of_compatible strings for MFD cells for regulator, clock and RTC > drivers in S5M8767, S2MPS11 and S2MPS14 PMIC-s. > > Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> > --- > drivers/mfd/sec-core.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/drivers/mfd/sec-core.c b/drivers/mfd/sec-core.c > index d163c66edebb..c5b9b95b2099 100644 > --- a/drivers/mfd/sec-core.c > +++ b/drivers/mfd/sec-core.c > @@ -55,28 +55,36 @@ static const struct mfd_cell s5m8763_devs[] = { > static const struct mfd_cell s5m8767_devs[] = { > { > .name = "s5m8767-pmic", > + .of_compatible = "samsung,s5m8767-regulators", > }, { > .name = "s5m-rtc", > + .of_compatible = "samsung,s5m8767-rtc", > }, { > .name = "s5m8767-clk", > + .of_compatible = "samsung,s5m8767-clk", > } > }; > > static const struct mfd_cell s2mps11_devs[] = { > { > .name = "s2mps11-pmic", > + .of_compatible = "samsung,s2mps11-regulators", > }, { > .name = "s2mps11-clk", > + .of_compatible = "samsung,s2mps11-clk", > } > }; > > static const struct mfd_cell s2mps14_devs[] = { > { > .name = "s2mps14-pmic", > + .of_compatible = "samsung,s2mps14-regulators", > }, { > .name = "s2mps14-rtc", > + .of_compatible = "samsung,s2mps14-rtc", > }, { > .name = "s2mps14-clk", > + .of_compatible = "samsung,s2mps14-clk", > } > }; Are these compatible strings documented anywhere? Best regards, Tomasz
On Thu, 2014-03-13 at 13:07 +0100, Tomasz Figa wrote: > Hi Krzysztof, > > On 13.03.2014 10:37, Krzysztof Kozlowski wrote: > > Add of_compatible strings for MFD cells for regulator, clock and RTC > > drivers in S5M8767, S2MPS11 and S2MPS14 PMIC-s. > > > > Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> > > --- > > drivers/mfd/sec-core.c | 8 ++++++++ > > 1 file changed, 8 insertions(+) > > > > diff --git a/drivers/mfd/sec-core.c b/drivers/mfd/sec-core.c > > index d163c66edebb..c5b9b95b2099 100644 > > --- a/drivers/mfd/sec-core.c > > +++ b/drivers/mfd/sec-core.c > > @@ -55,28 +55,36 @@ static const struct mfd_cell s5m8763_devs[] = { > > static const struct mfd_cell s5m8767_devs[] = { > > { > > .name = "s5m8767-pmic", > > + .of_compatible = "samsung,s5m8767-regulators", > > }, { > > .name = "s5m-rtc", > > + .of_compatible = "samsung,s5m8767-rtc", > > }, { > > .name = "s5m8767-clk", > > + .of_compatible = "samsung,s5m8767-clk", > > } > > }; > > > > static const struct mfd_cell s2mps11_devs[] = { > > { > > .name = "s2mps11-pmic", > > + .of_compatible = "samsung,s2mps11-regulators", > > }, { > > .name = "s2mps11-clk", > > + .of_compatible = "samsung,s2mps11-clk", > > } > > }; > > > > static const struct mfd_cell s2mps14_devs[] = { > > { > > .name = "s2mps14-pmic", > > + .of_compatible = "samsung,s2mps14-regulators", > > }, { > > .name = "s2mps14-rtc", > > + .of_compatible = "samsung,s2mps14-rtc", > > }, { > > .name = "s2mps14-clk", > > + .of_compatible = "samsung,s2mps14-clk", > > } > > }; > > Are these compatible strings documented anywhere? The "-clk" compatible strings are (in next patch). The "-rtc" and "-regulators" are not. Actually they aren't also used by child driver (each child driver parses from parent of_node). Best regards, Krzysztof
On 13.03.2014 13:16, Krzysztof Kozlowski wrote: > On Thu, 2014-03-13 at 13:07 +0100, Tomasz Figa wrote: >> Hi Krzysztof, >> >> On 13.03.2014 10:37, Krzysztof Kozlowski wrote: >>> Add of_compatible strings for MFD cells for regulator, clock and RTC >>> drivers in S5M8767, S2MPS11 and S2MPS14 PMIC-s. >>> >>> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> >>> --- >>> drivers/mfd/sec-core.c | 8 ++++++++ >>> 1 file changed, 8 insertions(+) >>> >>> diff --git a/drivers/mfd/sec-core.c b/drivers/mfd/sec-core.c >>> index d163c66edebb..c5b9b95b2099 100644 >>> --- a/drivers/mfd/sec-core.c >>> +++ b/drivers/mfd/sec-core.c >>> @@ -55,28 +55,36 @@ static const struct mfd_cell s5m8763_devs[] = { >>> static const struct mfd_cell s5m8767_devs[] = { >>> { >>> .name = "s5m8767-pmic", >>> + .of_compatible = "samsung,s5m8767-regulators", >>> }, { >>> .name = "s5m-rtc", >>> + .of_compatible = "samsung,s5m8767-rtc", >>> }, { >>> .name = "s5m8767-clk", >>> + .of_compatible = "samsung,s5m8767-clk", >>> } >>> }; >>> >>> static const struct mfd_cell s2mps11_devs[] = { >>> { >>> .name = "s2mps11-pmic", >>> + .of_compatible = "samsung,s2mps11-regulators", >>> }, { >>> .name = "s2mps11-clk", >>> + .of_compatible = "samsung,s2mps11-clk", >>> } >>> }; >>> >>> static const struct mfd_cell s2mps14_devs[] = { >>> { >>> .name = "s2mps14-pmic", >>> + .of_compatible = "samsung,s2mps14-regulators", >>> }, { >>> .name = "s2mps14-rtc", >>> + .of_compatible = "samsung,s2mps14-rtc", >>> }, { >>> .name = "s2mps14-clk", >>> + .of_compatible = "samsung,s2mps14-clk", >>> } >>> }; >> >> Are these compatible strings documented anywhere? > > The "-clk" compatible strings are (in next patch). The "-rtc" and > "-regulators" are not. Hmm, this doesn't sound good. > Actually they aren't also used by child driver (each child driver parses > from parent of_node). Do you need to add compatible strings to mfd_cell entries of such cells then? Best regards, Tomasz
On Thu, 2014-03-13 at 13:37 +0100, Tomasz Figa wrote: > On 13.03.2014 13:16, Krzysztof Kozlowski wrote: > > On Thu, 2014-03-13 at 13:07 +0100, Tomasz Figa wrote: > >> Hi Krzysztof, > >> > >> On 13.03.2014 10:37, Krzysztof Kozlowski wrote: > >>> Add of_compatible strings for MFD cells for regulator, clock and RTC > >>> drivers in S5M8767, S2MPS11 and S2MPS14 PMIC-s. > >>> > >>> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> > >>> --- > >>> drivers/mfd/sec-core.c | 8 ++++++++ > >>> 1 file changed, 8 insertions(+) > >>> > >>> diff --git a/drivers/mfd/sec-core.c b/drivers/mfd/sec-core.c > >>> index d163c66edebb..c5b9b95b2099 100644 > >>> --- a/drivers/mfd/sec-core.c > >>> +++ b/drivers/mfd/sec-core.c > >>> @@ -55,28 +55,36 @@ static const struct mfd_cell s5m8763_devs[] = { > >>> static const struct mfd_cell s5m8767_devs[] = { > >>> { > >>> .name = "s5m8767-pmic", > >>> + .of_compatible = "samsung,s5m8767-regulators", > >>> }, { > >>> .name = "s5m-rtc", > >>> + .of_compatible = "samsung,s5m8767-rtc", > >>> }, { > >>> .name = "s5m8767-clk", > >>> + .of_compatible = "samsung,s5m8767-clk", > >>> } > >>> }; > >>> > >>> static const struct mfd_cell s2mps11_devs[] = { > >>> { > >>> .name = "s2mps11-pmic", > >>> + .of_compatible = "samsung,s2mps11-regulators", > >>> }, { > >>> .name = "s2mps11-clk", > >>> + .of_compatible = "samsung,s2mps11-clk", > >>> } > >>> }; > >>> > >>> static const struct mfd_cell s2mps14_devs[] = { > >>> { > >>> .name = "s2mps14-pmic", > >>> + .of_compatible = "samsung,s2mps14-regulators", > >>> }, { > >>> .name = "s2mps14-rtc", > >>> + .of_compatible = "samsung,s2mps14-rtc", > >>> }, { > >>> .name = "s2mps14-clk", > >>> + .of_compatible = "samsung,s2mps14-clk", > >>> } > >>> }; > >> > >> Are these compatible strings documented anywhere? > > > > The "-clk" compatible strings are (in next patch). The "-rtc" and > > "-regulators" are not. > > Hmm, this doesn't sound good. > > > Actually they aren't also used by child driver (each child driver parses > > from parent of_node). > > Do you need to add compatible strings to mfd_cell entries of such cells > then? From my point of view there isn't any special need for them (except for clk). Dear Lee, Do you wish to have these compatibles for all of child drivers even when they aren't used directly by them? If yes then probably I should document them. Best regards, Krzysztof
<snip> > > >> Are these compatible strings documented anywhere? > > > > > > The "-clk" compatible strings are (in next patch). The "-rtc" and > > > "-regulators" are not. > > > > Hmm, this doesn't sound good. > > > > > Actually they aren't also used by child driver (each child driver parses > > > from parent of_node). > > > > Do you need to add compatible strings to mfd_cell entries of such cells > > then? > > From my point of view there isn't any special need for them (except for > clk). > > Dear Lee, > > Do you wish to have these compatibles for all of child drivers even when > they aren't used directly by them? If yes then probably I should > document them. It's your call, either remove the unused ones or document them all. I don't really mind either way. In the previous version I asked if there was any reason why you weren't applying compatible strings to the other cells; "subordinate drivers don't use them" is a perfectly reasonable reason.
diff --git a/drivers/mfd/sec-core.c b/drivers/mfd/sec-core.c index d163c66edebb..c5b9b95b2099 100644 --- a/drivers/mfd/sec-core.c +++ b/drivers/mfd/sec-core.c @@ -55,28 +55,36 @@ static const struct mfd_cell s5m8763_devs[] = { static const struct mfd_cell s5m8767_devs[] = { { .name = "s5m8767-pmic", + .of_compatible = "samsung,s5m8767-regulators", }, { .name = "s5m-rtc", + .of_compatible = "samsung,s5m8767-rtc", }, { .name = "s5m8767-clk", + .of_compatible = "samsung,s5m8767-clk", } }; static const struct mfd_cell s2mps11_devs[] = { { .name = "s2mps11-pmic", + .of_compatible = "samsung,s2mps11-regulators", }, { .name = "s2mps11-clk", + .of_compatible = "samsung,s2mps11-clk", } }; static const struct mfd_cell s2mps14_devs[] = { { .name = "s2mps14-pmic", + .of_compatible = "samsung,s2mps14-regulators", }, { .name = "s2mps14-rtc", + .of_compatible = "samsung,s2mps14-rtc", }, { .name = "s2mps14-clk", + .of_compatible = "samsung,s2mps14-clk", } };
Add of_compatible strings for MFD cells for regulator, clock and RTC drivers in S5M8767, S2MPS11 and S2MPS14 PMIC-s. Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> --- drivers/mfd/sec-core.c | 8 ++++++++ 1 file changed, 8 insertions(+)