| Message ID | 201403190258.16812.sergei.shtylyov@cogentembedded.com (mailing list archive) |
|---|---|
| State | Awaiting Upstream |
| Headers | show |
Hi Sergei, Thank you for the patch. On Wednesday 19 March 2014 02:58:16 Sergei Shtylyov wrote: > Commit 20d8435a1cff (phy: micrel: add of configuration for LED mode) made > the obvious mistake when masking off the LED mode bits: forgot to do a > logical NOT to the mask with which it ANDs the register value, so that > unrelated bits are cleared instead. > > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> Good catch. Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > This patch is against DaveM's 'net-next.git' repo. > > drivers/net/phy/micrel.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > Index: net-next/drivers/net/phy/micrel.c > =================================================================== > --- net-next.orig/drivers/net/phy/micrel.c > +++ net-next/drivers/net/phy/micrel.c > @@ -167,7 +167,7 @@ static int kszphy_setup_led(struct phy_d > if (temp < 0) > return temp; > > - temp &= 3 << shift; > + temp &= ~(3 << shift); > temp |= val << shift; > rc = phy_write(phydev, reg, temp);
On 19/03/14 00:58, Sergei Shtylyov wrote: > Commit 20d8435a1cff (phy: micrel: add of configuration for LED mode) made the > obvious mistake when masking off the LED mode bits: forgot to do a logical NOT > to the mask with which it ANDs the register value, so that unrelated bits are > cleared instead. > > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> Acked-by: Ben Dooks <ben.dooks@codethink.co.uk> Oops, thanks for noticing that.
2014-03-19 1:12 GMT-07:00 Ben Dooks <ben.dooks@codethink.co.uk>: > On 19/03/14 00:58, Sergei Shtylyov wrote: >> >> Commit 20d8435a1cff (phy: micrel: add of configuration for LED mode) made >> the >> obvious mistake when masking off the LED mode bits: forgot to do a >> logical NOT >> to the mask with which it ANDs the register value, so that unrelated bits >> are >> cleared instead. >> >> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> > > Acked-by: Ben Dooks <ben.dooks@codethink.co.uk> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com> -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hello. On 03/19/2014 07:21 PM, Florian Fainelli wrote: >>> Commit 20d8435a1cff (phy: micrel: add of configuration for LED mode) made >>> the >>> obvious mistake when masking off the LED mode bits: forgot to do a >>> logical NOT >>> to the mask with which it ANDs the register value, so that unrelated bits >>> are >>> cleared instead. >>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> >> Acked-by: Ben Dooks <ben.dooks@codethink.co.uk> > Reviewed-by: Florian Fainelli <f.fainelli@gmail.com> Oh, sorry for not CCing you -- I forgot that phylib is now maintained. WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> Date: Wed, 19 Mar 2014 02:58:16 +0300 > Commit 20d8435a1cff (phy: micrel: add of configuration for LED mode) made the > obvious mistake when masking off the LED mode bits: forgot to do a logical NOT > to the mask with which it ANDs the register value, so that unrelated bits are > cleared instead. > > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> Applied to net-next, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hello. On 03/20/2014 12:42 AM, David Miller wrote: >> Commit 20d8435a1cff (phy: micrel: add of configuration for LED mode) made the >> obvious mistake when masking off the LED mode bits: forgot to do a logical NOT >> to the mask with which it ANDs the register value, so that unrelated bits are >> cleared instead. I'm seeing now that I hadn't finished editing the changelog before submitting -- the verbs have inconsistent times. So much for my haste... :-) >> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> > Applied to net-next, thanks. Thanks. WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Index: net-next/drivers/net/phy/micrel.c =================================================================== --- net-next.orig/drivers/net/phy/micrel.c +++ net-next/drivers/net/phy/micrel.c @@ -167,7 +167,7 @@ static int kszphy_setup_led(struct phy_d if (temp < 0) return temp; - temp &= 3 << shift; + temp &= ~(3 << shift); temp |= val << shift; rc = phy_write(phydev, reg, temp);
Commit 20d8435a1cff (phy: micrel: add of configuration for LED mode) made the obvious mistake when masking off the LED mode bits: forgot to do a logical NOT to the mask with which it ANDs the register value, so that unrelated bits are cleared instead. Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> --- This patch is against DaveM's 'net-next.git' repo. drivers/net/phy/micrel.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html