| Message ID | 1395054917-27390-5-git-send-email-ben.dooks@codethink.co.uk (mailing list archive) |
|---|---|
| State | RFC |
| Headers | show |
Hi Ben, On Mon, Mar 17, 2014 at 12:15 PM, Ben Dooks <ben.dooks@codethink.co.uk> wrote: > Ensure pm_runtime is initialised. > > Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk> > --- > arch/arm/mach-shmobile/setup-r8a7790.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm/mach-shmobile/setup-r8a7790.c b/arch/arm/mach-shmobile/setup-r8a7790.c > index c4616f0..8424cb4 100644 > --- a/arch/arm/mach-shmobile/setup-r8a7790.c > +++ b/arch/arm/mach-shmobile/setup-r8a7790.c > @@ -305,6 +305,7 @@ void __init r8a7790_add_dt_devices(void) > > void __init r8a7790_add_standard_devices(void) > { > + sh_pm_runtime_init(); > r8a7790_add_dt_devices(); > r8a7790_register_irqc(0); > r8a7790_register_thermal(); Are you sure this is the right function? r8a7790_add_standard_devices() is only called from board-lager.c, not from board-lager-reference.c. I'd expect it to be added to r8a7790_add_dt_devices(). Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 19/03/14 17:10, Geert Uytterhoeven wrote: > Hi Ben, > > On Mon, Mar 17, 2014 at 12:15 PM, Ben Dooks <ben.dooks@codethink.co.uk> wrote: >> Ensure pm_runtime is initialised. >> >> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk> >> --- >> arch/arm/mach-shmobile/setup-r8a7790.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/arch/arm/mach-shmobile/setup-r8a7790.c b/arch/arm/mach-shmobile/setup-r8a7790.c >> index c4616f0..8424cb4 100644 >> --- a/arch/arm/mach-shmobile/setup-r8a7790.c >> +++ b/arch/arm/mach-shmobile/setup-r8a7790.c >> @@ -305,6 +305,7 @@ void __init r8a7790_add_dt_devices(void) >> >> void __init r8a7790_add_standard_devices(void) >> { >> + sh_pm_runtime_init(); >> r8a7790_add_dt_devices(); >> r8a7790_register_irqc(0); >> r8a7790_register_thermal(); > > Are you sure this is the right function? > r8a7790_add_standard_devices() is only called from board-lager.c, > not from board-lager-reference.c. > > I'd expect it to be added to r8a7790_add_dt_devices(). Thanks, I only put this out as an RFC, not had time to do a full test yet.
On Wed, Mar 19, 2014 at 5:15 PM, Ben Dooks <ben.dooks@codethink.co.uk> wrote: >>> --- a/arch/arm/mach-shmobile/setup-r8a7790.c >>> +++ b/arch/arm/mach-shmobile/setup-r8a7790.c >>> @@ -305,6 +305,7 @@ void __init r8a7790_add_dt_devices(void) >>> >>> void __init r8a7790_add_standard_devices(void) >>> { >>> + sh_pm_runtime_init(); >>> r8a7790_add_dt_devices(); >>> r8a7790_register_irqc(0); >>> r8a7790_register_thermal(); >> >> >> Are you sure this is the right function? >> r8a7790_add_standard_devices() is only called from board-lager.c, >> not from board-lager-reference.c. >> >> I'd expect it to be added to r8a7790_add_dt_devices(). > > Thanks, I only put this out as an RFC, not had time to do a full > test yet. IC. I'm reworking the series to apply to all shmobile SoCs. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm/mach-shmobile/setup-r8a7790.c b/arch/arm/mach-shmobile/setup-r8a7790.c index c4616f0..8424cb4 100644 --- a/arch/arm/mach-shmobile/setup-r8a7790.c +++ b/arch/arm/mach-shmobile/setup-r8a7790.c @@ -305,6 +305,7 @@ void __init r8a7790_add_dt_devices(void) void __init r8a7790_add_standard_devices(void) { + sh_pm_runtime_init(); r8a7790_add_dt_devices(); r8a7790_register_irqc(0); r8a7790_register_thermal();
Ensure pm_runtime is initialised. Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk> --- arch/arm/mach-shmobile/setup-r8a7790.c | 1 + 1 file changed, 1 insertion(+)