[V2] mmc: dw_mmc: exynos: Turn SDIO interrupts on

Message ID	1395635037-24081-1-git-send-email-yuvaraj.cd@samsung.com (mailing list archive)
State	New, archived
Headers	show Return-Path: <linux-mmc-owner@kernel.org> From: Yuvaraj Kumar C D <yuvaraj.cd@gmail.com> To: grundler@chromium.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, jh80.chung@samsung.com, cjb@laptop.org, tgih.jun@samsung.com, linux-mmc@vger.kernel.org, sonnyrao@chromium.org, kgene.kim@samsung.com, joshi@samsung.com Cc: t.figa@samsung.com, Yuvaraj Kumar C D <yuvaraj.cd@samsung.com>, Doug Anderson <dianders@chromium.org> Subject: [PATCH V2] mmc: dw_mmc: exynos: Turn SDIO interrupts on Date: Mon, 24 Mar 2014 09:53:57 +0530 Message-Id: <1395635037-24081-1-git-send-email-yuvaraj.cd@samsung.com> Sender: linux-mmc-owner@vger.kernel.org Precedence: bulk

Message ID

1395635037-24081-1-git-send-email-yuvaraj.cd@samsung.com (mailing list archive)

State

New, archived

Headers

From: Yuvaraj Kumar C D <yuvaraj.cd@gmail.com>
To: grundler@chromium.org, linux-samsung-soc@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, jh80.chung@samsung.com,
	cjb@laptop.org, tgih.jun@samsung.com, linux-mmc@vger.kernel.org,
	sonnyrao@chromium.org, kgene.kim@samsung.com, joshi@samsung.com
Cc: t.figa@samsung.com, Yuvaraj Kumar C D <yuvaraj.cd@samsung.com>,
	Doug Anderson <dianders@chromium.org>
Subject: [PATCH V2] mmc: dw_mmc: exynos: Turn SDIO interrupts on
Date: Mon, 24 Mar 2014 09:53:57 +0530
Message-Id: <1395635037-24081-1-git-send-email-yuvaraj.cd@samsung.com>
Sender: linux-mmc-owner@vger.kernel.org
Precedence: bulk

Commit Message

Yuvaraj CD March 24, 2014, 4:23 a.m. UTC

The mmc part in exynos supports SDIO interrupts and they work fine, so
turn the capability on.  With this I see download speeds increase
about 10x. 
	
This V1 of this patch is posted to LKML at
https://patchwork.kernel.org/patch/2429661/) by Doug Anderson.

Signed-off-by: Doug Anderson <dianders@chromium.org>
Signed-off-by: Yuvaraj Kumar C D <yuvaraj.cd@samsung.com>
---
 drivers/mmc/host/dw_mmc.c |    3 +++
 1 file changed, 3 insertions(+)

Comments

Jaehoon Chung March 24, 2014, 4:29 a.m. UTC | #1

Hi, Yuvaraj.

NACK. we can use "mmc_of_parese()".

I have sent the patch that use "mmc_of_parse()".
https://patchwork.kernel.org/patch/3750681/

Best Regards,
Jaehoon Chung

On 03/24/2014 01:23 PM, Yuvaraj Kumar C D wrote:
> The mmc part in exynos supports SDIO interrupts and they work fine, so
> turn the capability on.  With this I see download speeds increase
> about 10x. 
> 	
> This V1 of this patch is posted to LKML at
> https://patchwork.kernel.org/patch/2429661/) by Doug Anderson.
> 
> Signed-off-by: Doug Anderson <dianders@chromium.org>
> Signed-off-by: Yuvaraj Kumar C D <yuvaraj.cd@samsung.com>
> ---
>  drivers/mmc/host/dw_mmc.c |    3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c
> index 0c56faa..240949d 100644
> --- a/drivers/mmc/host/dw_mmc.c
> +++ b/drivers/mmc/host/dw_mmc.c
> @@ -2417,6 +2417,9 @@ static struct dw_mci_board *dw_mci_parse_dt(struct dw_mci *host)
>  	if (of_get_property(np, "cd-inverted", NULL))
>  		pdata->caps2 |= MMC_CAP2_CD_ACTIVE_HIGH;
>  
> +	if (of_find_property(np, "cap-sdio-irq", NULL))
> +		pdata->caps |= MMC_CAP_SDIO_IRQ;
> +
>  	return pdata;
>  }
>  
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Yuvaraj CD March 24, 2014, 4:42 a.m. UTC | #2

On Mon, Mar 24, 2014 at 9:59 AM, Jaehoon Chung <jh80.chung@samsung.com> wrote:
> Hi, Yuvaraj.
>
> NACK. we can use "mmc_of_parese()".
Thanks Jaehoon for the pointer.I will use "mmc_of_parse()".
>
> I have sent the patch that use "mmc_of_parse()".
> https://patchwork.kernel.org/patch/3750681/
>
> Best Regards,
> Jaehoon Chung
>
> On 03/24/2014 01:23 PM, Yuvaraj Kumar C D wrote:
>> The mmc part in exynos supports SDIO interrupts and they work fine, so
>> turn the capability on.  With this I see download speeds increase
>> about 10x.
>>
>> This V1 of this patch is posted to LKML at
>> https://patchwork.kernel.org/patch/2429661/) by Doug Anderson.
>>
>> Signed-off-by: Doug Anderson <dianders@chromium.org>
>> Signed-off-by: Yuvaraj Kumar C D <yuvaraj.cd@samsung.com>
>> ---
>>  drivers/mmc/host/dw_mmc.c |    3 +++
>>  1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c
>> index 0c56faa..240949d 100644
>> --- a/drivers/mmc/host/dw_mmc.c
>> +++ b/drivers/mmc/host/dw_mmc.c
>> @@ -2417,6 +2417,9 @@ static struct dw_mci_board *dw_mci_parse_dt(struct dw_mci *host)
>>       if (of_get_property(np, "cd-inverted", NULL))
>>               pdata->caps2 |= MMC_CAP2_CD_ACTIVE_HIGH;
>>
>> +     if (of_find_property(np, "cap-sdio-irq", NULL))
>> +             pdata->caps |= MMC_CAP_SDIO_IRQ;
>> +
>>       return pdata;
>>  }
>>
>>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Alim Akhtar April 23, 2014, 4:12 a.m. UTC | #3

Hi Yuvaraj,

On Mon, Mar 24, 2014 at 10:12 AM, Yuvaraj Kumar <yuvaraj.cd@gmail.com> wrote:
> On Mon, Mar 24, 2014 at 9:59 AM, Jaehoon Chung <jh80.chung@samsung.com> wrote:
>> Hi, Yuvaraj.
>>
>> NACK. we can use "mmc_of_parese()".
> Thanks Jaehoon for the pointer.I will use "mmc_of_parse()".
Are you planning to re-spin this patch? Now Jaehoon's changes for
using mmc_of_parse() is landed in mmc-next.
Thanks!!
>>
>> I have sent the patch that use "mmc_of_parse()".
>> https://patchwork.kernel.org/patch/3750681/
>>
>> Best Regards,
>> Jaehoon Chung
>>
>> On 03/24/2014 01:23 PM, Yuvaraj Kumar C D wrote:
>>> The mmc part in exynos supports SDIO interrupts and they work fine, so
>>> turn the capability on.  With this I see download speeds increase
>>> about 10x.
>>>
>>> This V1 of this patch is posted to LKML at
>>> https://patchwork.kernel.org/patch/2429661/) by Doug Anderson.
>>>
>>> Signed-off-by: Doug Anderson <dianders@chromium.org>
>>> Signed-off-by: Yuvaraj Kumar C D <yuvaraj.cd@samsung.com>
>>> ---
>>>  drivers/mmc/host/dw_mmc.c |    3 +++
>>>  1 file changed, 3 insertions(+)
>>>
>>> diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c
>>> index 0c56faa..240949d 100644
>>> --- a/drivers/mmc/host/dw_mmc.c
>>> +++ b/drivers/mmc/host/dw_mmc.c
>>> @@ -2417,6 +2417,9 @@ static struct dw_mci_board *dw_mci_parse_dt(struct dw_mci *host)
>>>       if (of_get_property(np, "cd-inverted", NULL))
>>>               pdata->caps2 |= MMC_CAP2_CD_ACTIVE_HIGH;
>>>
>>> +     if (of_find_property(np, "cap-sdio-irq", NULL))
>>> +             pdata->caps |= MMC_CAP_SDIO_IRQ;
>>> +
>>>       return pdata;
>>>  }
>>>
>>>
>>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Yuvaraj CD April 23, 2014, 6:54 a.m. UTC | #4

On Wed, Apr 23, 2014 at 9:42 AM, Alim Akhtar <alim.akhtar@gmail.com> wrote:
> Hi Yuvaraj,
>
> On Mon, Mar 24, 2014 at 10:12 AM, Yuvaraj Kumar <yuvaraj.cd@gmail.com> wrote:
>> On Mon, Mar 24, 2014 at 9:59 AM, Jaehoon Chung <jh80.chung@samsung.com> wrote:
>>> Hi, Yuvaraj.
>>>
>>> NACK. we can use "mmc_of_parese()".
>> Thanks Jaehoon for the pointer.I will use "mmc_of_parse()".
> Are you planning to re-spin this patch? Now Jaehoon's changes for
> using mmc_of_parse() is landed in mmc-next.
As its already added mmc_of_parse(),no respin of this.
Just we need to use it in DT.
> Thanks!!
>>>
>>> I have sent the patch that use "mmc_of_parse()".
>>> https://patchwork.kernel.org/patch/3750681/
>>>
>>> Best Regards,
>>> Jaehoon Chung
>>>
>>> On 03/24/2014 01:23 PM, Yuvaraj Kumar C D wrote:
>>>> The mmc part in exynos supports SDIO interrupts and they work fine, so
>>>> turn the capability on.  With this I see download speeds increase
>>>> about 10x.
>>>>
>>>> This V1 of this patch is posted to LKML at
>>>> https://patchwork.kernel.org/patch/2429661/) by Doug Anderson.
>>>>
>>>> Signed-off-by: Doug Anderson <dianders@chromium.org>
>>>> Signed-off-by: Yuvaraj Kumar C D <yuvaraj.cd@samsung.com>
>>>> ---
>>>>  drivers/mmc/host/dw_mmc.c |    3 +++
>>>>  1 file changed, 3 insertions(+)
>>>>
>>>> diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c
>>>> index 0c56faa..240949d 100644
>>>> --- a/drivers/mmc/host/dw_mmc.c
>>>> +++ b/drivers/mmc/host/dw_mmc.c
>>>> @@ -2417,6 +2417,9 @@ static struct dw_mci_board *dw_mci_parse_dt(struct dw_mci *host)
>>>>       if (of_get_property(np, "cd-inverted", NULL))
>>>>               pdata->caps2 |= MMC_CAP2_CD_ACTIVE_HIGH;
>>>>
>>>> +     if (of_find_property(np, "cap-sdio-irq", NULL))
>>>> +             pdata->caps |= MMC_CAP_SDIO_IRQ;
>>>> +
>>>>       return pdata;
>>>>  }
>>>>
>>>>
>>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
>
>
> --
> Regards,
> Alim
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c
index 0c56faa..240949d 100644
--- a/drivers/mmc/host/dw_mmc.c
+++ b/drivers/mmc/host/dw_mmc.c
@@ -2417,6 +2417,9 @@  static struct dw_mci_board *dw_mci_parse_dt(struct dw_mci *host)
 	if (of_get_property(np, "cd-inverted", NULL))
 		pdata->caps2 |= MMC_CAP2_CD_ACTIVE_HIGH;
 
+	if (of_find_property(np, "cap-sdio-irq", NULL))
+		pdata->caps |= MMC_CAP_SDIO_IRQ;
+
 	return pdata;
 }

[V2] mmc: dw_mmc: exynos: Turn SDIO interrupts on

Commit Message

Comments

Patch