| Message ID | 1668037.2oe7J2B7N4@amdc1032 (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thu, Mar 27, 2014 at 01:23:39PM +0100, Bartlomiej Zolnierkiewicz wrote: > Make sata_mv host driver depend on PCI || ARCH_DOVE || ARCH_KIRKWOOD || > ARCH_MV78XX0 || ARCH_MVEBU || ARCH_ORION5X config options as Marvell > SATA support covers both Marvell PCI devices and Marvell Dove, Kirkwood, > MV78xx0, Armada 370/XP and Orion5x SoCs (for non-PCI devices the driver > to work requires suitable device tree node to be defined). Good old fashioned platform driver will also work. In fact, 95% of Orion5x and mv78xx0 devices don't have DT yet. You might also be able to simplify it to PCI || PLAT_ORION || COMPILE_TEST But i suggest you build test to make sure. Andrew
On 03/27/2014 01:38 PM, Andrew Lunn wrote: > On Thu, Mar 27, 2014 at 01:23:39PM +0100, Bartlomiej Zolnierkiewicz wrote: >> Make sata_mv host driver depend on PCI || ARCH_DOVE || ARCH_KIRKWOOD || >> ARCH_MV78XX0 || ARCH_MVEBU || ARCH_ORION5X config options as Marvell >> SATA support covers both Marvell PCI devices and Marvell Dove, Kirkwood, >> MV78xx0, Armada 370/XP and Orion5x SoCs (for non-PCI devices the driver >> to work requires suitable device tree node to be defined). > > Good old fashioned platform driver will also work. In fact, 95% of Orion5x > and mv78xx0 devices don't have DT yet. > > You might also be able to simplify it to > > PCI || PLAT_ORION || COMPILE_TEST > > But i suggest you build test to make sure. Please, don't do it. We are in the progress of getting rid of PLAT_ORION. v3 is just fine, or keep at least ARCH_MVEBU: PCI || PLAT_ORION || ARCH_MVEBU || COMPILE_TEST Sebastian
Index: b/drivers/ata/Kconfig =================================================================== --- a/drivers/ata/Kconfig 2014-03-26 17:59:35.000000000 +0100 +++ b/drivers/ata/Kconfig 2014-03-27 13:14:24.097787880 +0100 @@ -281,6 +281,8 @@ config SATA_HIGHBANK config SATA_MV tristate "Marvell SATA support" + depends on PCI || ARCH_DOVE || ARCH_KIRKWOOD || ARCH_MV78XX0 || \ + ARCH_MVEBU || ARCH_ORION5X || COMPILE_TEST help This option enables support for the Marvell Serial ATA family. Currently supports 88SX[56]0[48][01] PCI(-X) chips,
Make sata_mv host driver depend on PCI || ARCH_DOVE || ARCH_KIRKWOOD || ARCH_MV78XX0 || ARCH_MVEBU || ARCH_ORION5X config options as Marvell SATA support covers both Marvell PCI devices and Marvell Dove, Kirkwood, MV78xx0, Armada 370/XP and Orion5x SoCs (for non-PCI devices the driver to work requires suitable device tree node to be defined). Additionally allow the driver build if COMPILE_TEST config option is set. Cc: Jason Cooper <jason@lakedaemon.net> Cc: Andrew Lunn <andrew@lunn.ch> Cc: Gregory Clement <gregory.clement@free-electrons.com> Cc: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> --- v3: - added dependencies for Marvel Dove and MV78xx0 v2: - resynced patch with libata/for-3.15 branch (previous patch was against libata/for-next branch and SATA_MV selects GENERIC_PHY in that branch) drivers/ata/Kconfig | 2 ++ 1 file changed, 2 insertions(+)