diff mbox

input: sirfsoc-onkey - set the capability of reporting KEY_POWER

Message ID 1393335375-1870-1-git-send-email-21cnbao@gmail.com (mailing list archive)
State New, archived
Headers show

Commit Message

Barry Song Feb. 25, 2014, 1:36 p.m. UTC
From: Xianglong Du <Xianglong.Du@csr.com>

commit a1a7521064428fc1cf8 moved to report EV_KEY event(KEY_POWER) instead of
reporting EV_PWR event(KEY_SUSPEND), but it didn't enable the capability, so
the KEY_POWER will not be reported to userspace by input core. this patch fixes
the issue.

Signed-off-by: Xianglong Du <Xianglong.Du@csr.com>
Signed-off-by: Barry Song <Baohua.Song@csr.com>
---
 drivers/input/misc/sirfsoc-onkey.c |    1 +
 1 file changed, 1 insertion(+)

Comments

Barry Song March 27, 2014, 7:35 a.m. UTC | #1
2014-02-25 21:36 GMT+08:00 Barry Song <21cnbao@gmail.com>:
> From: Xianglong Du <Xianglong.Du@csr.com>
>
> commit a1a7521064428fc1cf8 moved to report EV_KEY event(KEY_POWER) instead of
> reporting EV_PWR event(KEY_SUSPEND), but it didn't enable the capability, so
> the KEY_POWER will not be reported to userspace by input core. this patch fixes
> the issue.
>
> Signed-off-by: Xianglong Du <Xianglong.Du@csr.com>
> Signed-off-by: Barry Song <Baohua.Song@csr.com>
> ---

Dmitry, i guess you missed this one, this one should be in 3.15,
otherwise, onkey is broken.


>  drivers/input/misc/sirfsoc-onkey.c |    1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/input/misc/sirfsoc-onkey.c b/drivers/input/misc/sirfsoc-onkey.c
> index 4d66c72..e4104f9 100644
> --- a/drivers/input/misc/sirfsoc-onkey.c
> +++ b/drivers/input/misc/sirfsoc-onkey.c
> @@ -136,6 +136,7 @@ static int sirfsoc_pwrc_probe(struct platform_device *pdev)
>         pwrcdrv->input->name = "sirfsoc pwrckey";
>         pwrcdrv->input->phys = "pwrc/input0";
>         pwrcdrv->input->evbit[0] = BIT_MASK(EV_KEY);
> +       input_set_capability(pwrcdrv->input, EV_KEY, KEY_POWER);
>
>         INIT_DELAYED_WORK(&pwrcdrv->work, sirfsoc_pwrc_report_event);
>
> --
> 1.7.9.5
>

-barry
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Dmitry Torokhov March 28, 2014, 7:39 a.m. UTC | #2
On Thu, Mar 27, 2014 at 03:35:46PM +0800, Barry Song wrote:
> 2014-02-25 21:36 GMT+08:00 Barry Song <21cnbao@gmail.com>:
> > From: Xianglong Du <Xianglong.Du@csr.com>
> >
> > commit a1a7521064428fc1cf8 moved to report EV_KEY event(KEY_POWER) instead of
> > reporting EV_PWR event(KEY_SUSPEND), but it didn't enable the capability, so
> > the KEY_POWER will not be reported to userspace by input core. this patch fixes
> > the issue.
> >
> > Signed-off-by: Xianglong Du <Xianglong.Du@csr.com>
> > Signed-off-by: Barry Song <Baohua.Song@csr.com>
> > ---
> 
> Dmitry, i guess you missed this one, this one should be in 3.15,
> otherwise, onkey is broken.

Applied, thank you.

> 
> 
> >  drivers/input/misc/sirfsoc-onkey.c |    1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/input/misc/sirfsoc-onkey.c b/drivers/input/misc/sirfsoc-onkey.c
> > index 4d66c72..e4104f9 100644
> > --- a/drivers/input/misc/sirfsoc-onkey.c
> > +++ b/drivers/input/misc/sirfsoc-onkey.c
> > @@ -136,6 +136,7 @@ static int sirfsoc_pwrc_probe(struct platform_device *pdev)
> >         pwrcdrv->input->name = "sirfsoc pwrckey";
> >         pwrcdrv->input->phys = "pwrc/input0";
> >         pwrcdrv->input->evbit[0] = BIT_MASK(EV_KEY);
> > +       input_set_capability(pwrcdrv->input, EV_KEY, KEY_POWER);
> >
> >         INIT_DELAYED_WORK(&pwrcdrv->work, sirfsoc_pwrc_report_event);
> >
> > --
> > 1.7.9.5
> >
> 
> -barry
diff mbox

Patch

diff --git a/drivers/input/misc/sirfsoc-onkey.c b/drivers/input/misc/sirfsoc-onkey.c
index 4d66c72..e4104f9 100644
--- a/drivers/input/misc/sirfsoc-onkey.c
+++ b/drivers/input/misc/sirfsoc-onkey.c
@@ -136,6 +136,7 @@  static int sirfsoc_pwrc_probe(struct platform_device *pdev)
 	pwrcdrv->input->name = "sirfsoc pwrckey";
 	pwrcdrv->input->phys = "pwrc/input0";
 	pwrcdrv->input->evbit[0] = BIT_MASK(EV_KEY);
+	input_set_capability(pwrcdrv->input, EV_KEY, KEY_POWER);
 
 	INIT_DELAYED_WORK(&pwrcdrv->work, sirfsoc_pwrc_report_event);