diff mbox

[v7,1/3] ARM: EXYNOS: initial board support for exynos5260 SoC

Message ID 1396519224-18712-2-git-send-email-rahul.sharma@samsung.com (mailing list archive)
State New, archived
Headers show

Commit Message

Rahul Sharma April 3, 2014, 10 a.m. UTC 
From: Pankaj Dubey <pankaj.dubey@samsung.com>

This patch add basic arch side support for exynos5260 SoC.

Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com>
Signed-off-by: Rahul Sharma <rahul.sharma@samsung.com>
Reviewed-by: Tomasz Figa <t.figa@samsung.com>
---
 arch/arm/mach-exynos/Kconfig  |    5 +++++
 arch/arm/mach-exynos/exynos.c |    1 +
 2 files changed, 6 insertions(+)

Comments

Sachin Kamat April 7, 2014, 8:38 a.m. UTC | #1 
Hi Rahul,

On 3 April 2014 15:30, Rahul Sharma <rahul.sharma@samsung.com> wrote:
> From: Pankaj Dubey <pankaj.dubey@samsung.com>
>
> This patch add basic arch side support for exynos5260 SoC.
<snip>

> @@ -374,6 +374,7 @@ static char const *exynos_dt_compat[] __initconst = {
>         "samsung,exynos4412",
>         "samsung,exynos5",
>         "samsung,exynos5250",
> +       "samsung,exynos5260",

I don't think we should be adding this as we do not yet have any soc
specific quirk.
Compatibility to generic string, "samsung,exynos5"  should be sufficient.
Tomasz Figa April 9, 2014, 9:04 a.m. UTC | #2 
On 07.04.2014 10:38, Sachin Kamat wrote:
> Hi Rahul,
>
> On 3 April 2014 15:30, Rahul Sharma <rahul.sharma@samsung.com> wrote:
>> From: Pankaj Dubey <pankaj.dubey@samsung.com>
>>
>> This patch add basic arch side support for exynos5260 SoC.
> <snip>
>
>> @@ -374,6 +374,7 @@ static char const *exynos_dt_compat[] __initconst = {
>>          "samsung,exynos4412",
>>          "samsung,exynos5",
>>          "samsung,exynos5250",
>> +       "samsung,exynos5260",
>
> I don't think we should be adding this as we do not yet have any soc
> specific quirk.
> Compatibility to generic string, "samsung,exynos5"  should be sufficient.
>

Yes. Unless a SoC specific quirk that needs to be handled at such low 
level stage emerges, there is no need to add such compatible string to 
the kernel.

Best regards,
Tomasz
Rahul Sharma April 9, 2014, 9:15 a.m. UTC | #3 
On 9 April 2014 14:34, Tomasz Figa <t.figa@samsung.com> wrote:
> On 07.04.2014 10:38, Sachin Kamat wrote:
>>
>> Hi Rahul,
>>
>> On 3 April 2014 15:30, Rahul Sharma <rahul.sharma@samsung.com> wrote:
>>>
>>> From: Pankaj Dubey <pankaj.dubey@samsung.com>
>>>
>>> This patch add basic arch side support for exynos5260 SoC.
>>
>> <snip>
>>
>>> @@ -374,6 +374,7 @@ static char const *exynos_dt_compat[] __initconst = {
>>>          "samsung,exynos4412",
>>>          "samsung,exynos5",
>>>          "samsung,exynos5250",
>>> +       "samsung,exynos5260",
>>
>>
>> I don't think we should be adding this as we do not yet have any soc
>> specific quirk.
>> Compatibility to generic string, "samsung,exynos5"  should be sufficient.
>>
>
> Yes. Unless a SoC specific quirk that needs to be handled at such low level
> stage emerges, there is no need to add such compatible string to the kernel.
>

Thanks Sachin, Tomasz,

I will change this.

Regards,
Rahul Sharma.

> Best regards,
> Tomasz
diff mbox

Patch

diff --git a/arch/arm/mach-exynos/Kconfig b/arch/arm/mach-exynos/Kconfig
index 5c34dc2..6c48844 100644
--- a/arch/arm/mach-exynos/Kconfig
+++ b/arch/arm/mach-exynos/Kconfig
@@ -51,6 +51,11 @@  config SOC_EXYNOS5250
 	default y
 	depends on ARCH_EXYNOS5
 
+config SOC_EXYNOS5260
+	bool "SAMSUNG EXYNOS5260"
+	default y
+	depends on ARCH_EXYNOS5
+
 config SOC_EXYNOS5420
 	bool "SAMSUNG EXYNOS5420"
 	default y
diff --git a/arch/arm/mach-exynos/exynos.c b/arch/arm/mach-exynos/exynos.c
index b567361..5324051 100644
--- a/arch/arm/mach-exynos/exynos.c
+++ b/arch/arm/mach-exynos/exynos.c
@@ -374,6 +374,7 @@  static char const *exynos_dt_compat[] __initconst = {
 	"samsung,exynos4412",
 	"samsung,exynos5",
 	"samsung,exynos5250",
+	"samsung,exynos5260",
 	"samsung,exynos5420",
 	"samsung,exynos5440",
 	NULL