| Message ID | 1394811272-1547-6-git-send-email-Liviu.Dudau@arm.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Fri, Mar 14, 2014 at 03:34:31PM +0000, Liviu Dudau wrote: > This is a useful function and we should make it visible outside the > generic PCI code. Export it as a GPL symbol. > > Signed-off-by: Liviu Dudau <Liviu.Dudau@arm.com> > Tested-by: Tanmay Inamdar <tinamdar@apm.com> > --- > drivers/pci/host-bridge.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/pci/host-bridge.c b/drivers/pci/host-bridge.c > index 06ace62..8708b652 100644 > --- a/drivers/pci/host-bridge.c > +++ b/drivers/pci/host-bridge.c > @@ -17,12 +17,13 @@ static struct pci_bus *find_pci_root_bus(struct pci_bus *bus) > return bus; > } > > -static struct pci_host_bridge *find_pci_host_bridge(struct pci_bus *bus) > +struct pci_host_bridge *find_pci_host_bridge(struct pci_bus *bus) > { > struct pci_bus *root_bus = find_pci_root_bus(bus); > > return to_pci_host_bridge(root_bus->bridge); > } > +EXPORT_SYMBOL_GPL(find_pci_host_bridge); Do you have a place where you actually need to use find_pci_host_bridge()? I'd rather not export it, even as _GPL, unless we have a user. If we *do* export it, I'd like it to have a more conventional name, e.g., something starting with "pci_". > > void pci_set_host_bridge_release(struct pci_host_bridge *bridge, > void (*release_fn)(struct pci_host_bridge *), > -- > 1.9.0 >
On Sat, Apr 05, 2014 at 12:39:48AM +0100, Bjorn Helgaas wrote: > On Fri, Mar 14, 2014 at 03:34:31PM +0000, Liviu Dudau wrote: > > This is a useful function and we should make it visible outside the > > generic PCI code. Export it as a GPL symbol. > > > > Signed-off-by: Liviu Dudau <Liviu.Dudau@arm.com> > > Tested-by: Tanmay Inamdar <tinamdar@apm.com> > > --- > > drivers/pci/host-bridge.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/pci/host-bridge.c b/drivers/pci/host-bridge.c > > index 06ace62..8708b652 100644 > > --- a/drivers/pci/host-bridge.c > > +++ b/drivers/pci/host-bridge.c > > @@ -17,12 +17,13 @@ static struct pci_bus *find_pci_root_bus(struct pci_bus *bus) > > return bus; > > } > > > > -static struct pci_host_bridge *find_pci_host_bridge(struct pci_bus *bus) > > +struct pci_host_bridge *find_pci_host_bridge(struct pci_bus *bus) > > { > > struct pci_bus *root_bus = find_pci_root_bus(bus); > > > > return to_pci_host_bridge(root_bus->bridge); > > } > > +EXPORT_SYMBOL_GPL(find_pci_host_bridge); > > Do you have a place where you actually need to use find_pci_host_bridge()? > I'd rather not export it, even as _GPL, unless we have a user. The code in arm64 series is using it to implement pci_domain_nr(). > > If we *do* export it, I'd like it to have a more conventional name, e.g., > something starting with "pci_". Understood. pci_find_host_bridge() ? Best regards, Liviu > > > > > void pci_set_host_bridge_release(struct pci_host_bridge *bridge, > > void (*release_fn)(struct pci_host_bridge *), > > -- > > 1.9.0 > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-pci" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >
> > If we *do* export it, I'd like it to have a more conventional name, e.g., > > something starting with "pci_". > > Understood. pci_find_host_bridge() ? pci_get_host_bridge() and take a reference IMHO ? If your primary bus is not PCI then your PCI "host" bridge could be hot swappable so the API at least ought to get that right. Alan
diff --git a/drivers/pci/host-bridge.c b/drivers/pci/host-bridge.c index 06ace62..8708b652 100644 --- a/drivers/pci/host-bridge.c +++ b/drivers/pci/host-bridge.c @@ -17,12 +17,13 @@ static struct pci_bus *find_pci_root_bus(struct pci_bus *bus) return bus; } -static struct pci_host_bridge *find_pci_host_bridge(struct pci_bus *bus) +struct pci_host_bridge *find_pci_host_bridge(struct pci_bus *bus) { struct pci_bus *root_bus = find_pci_root_bus(bus); return to_pci_host_bridge(root_bus->bridge); } +EXPORT_SYMBOL_GPL(find_pci_host_bridge); void pci_set_host_bridge_release(struct pci_host_bridge *bridge, void (*release_fn)(struct pci_host_bridge *),