diff mbox

[v2,1/4] rtl8180: change module name in rtl818x_pci

Message ID 1396981525-28078-1-git-send-email-andrea.merello@gmail.com (mailing list archive)
State Not Applicable, archived
Headers show

Commit Message

Andrea Merello April 8, 2014, 6:25 p.m. UTC
From: Larry Finger <Larry.Finger@lwfinger.net> [ original patch ]

rtl8180 driver can handle also rtl8185 and rtl8187SE cards,
however in userspace tools (network manager) it still appares
as "rtl8180".
This might lead the user to think the wrong driver is in use.

This patch changes module name to "rtl818x_pci" that should be
more explanatory.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net> [ original patch ]
Signed-off-by: Andrea Merello <andrea.merello@gmail.com>
---
 drivers/net/wireless/rtl818x/rtl8180/Makefile | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

John W. Linville April 9, 2014, 4:10 p.m. UTC | #1
I see parts 1, 3, and 4/4.  Is there a part 2/4 that I missed?

On Tue, Apr 08, 2014 at 08:25:25PM +0200, Andrea Merello wrote:
> From: Larry Finger <Larry.Finger@lwfinger.net> [ original patch ]
> 
> rtl8180 driver can handle also rtl8185 and rtl8187SE cards,
> however in userspace tools (network manager) it still appares
> as "rtl8180".
> This might lead the user to think the wrong driver is in use.
> 
> This patch changes module name to "rtl818x_pci" that should be
> more explanatory.
> 
> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net> [ original patch ]
> Signed-off-by: Andrea Merello <andrea.merello@gmail.com>
> ---
>  drivers/net/wireless/rtl818x/rtl8180/Makefile | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/wireless/rtl818x/rtl8180/Makefile b/drivers/net/wireless/rtl818x/rtl8180/Makefile
> index 08b056d..21005bd 100644
> --- a/drivers/net/wireless/rtl818x/rtl8180/Makefile
> +++ b/drivers/net/wireless/rtl818x/rtl8180/Makefile
> @@ -1,5 +1,5 @@
> -rtl8180-objs		:= dev.o rtl8225.o sa2400.o max2820.o grf5101.o rtl8225se.o
> +rtl818x_pci-objs	:= dev.o rtl8225.o sa2400.o max2820.o grf5101.o rtl8225se.o
>  
> -obj-$(CONFIG_RTL8180)	+= rtl8180.o
> +obj-$(CONFIG_RTL8180)	+= rtl818x_pci.o
>  
>  ccflags-y += -Idrivers/net/wireless/rtl818x
> -- 
> 1.8.3.2
> 
>
Andrea Merello April 9, 2014, 4:30 p.m. UTC | #2
Yes, it is.
It seems that at least the wireless ML received it.
http://marc.info/?l=linux-wireless&m=139662852419525&w=2

BTW I can resend if you need it.

On Wed, Apr 9, 2014 at 6:10 PM, John W. Linville <linville@tuxdriver.com> wrote:
> I see parts 1, 3, and 4/4.  Is there a part 2/4 that I missed?
>
> On Tue, Apr 08, 2014 at 08:25:25PM +0200, Andrea Merello wrote:
>> From: Larry Finger <Larry.Finger@lwfinger.net> [ original patch ]
>>
>> rtl8180 driver can handle also rtl8185 and rtl8187SE cards,
>> however in userspace tools (network manager) it still appares
>> as "rtl8180".
>> This might lead the user to think the wrong driver is in use.
>>
>> This patch changes module name to "rtl818x_pci" that should be
>> more explanatory.
>>
>> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net> [ original patch ]
>> Signed-off-by: Andrea Merello <andrea.merello@gmail.com>
>> ---
>>  drivers/net/wireless/rtl818x/rtl8180/Makefile | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/net/wireless/rtl818x/rtl8180/Makefile b/drivers/net/wireless/rtl818x/rtl8180/Makefile
>> index 08b056d..21005bd 100644
>> --- a/drivers/net/wireless/rtl818x/rtl8180/Makefile
>> +++ b/drivers/net/wireless/rtl818x/rtl8180/Makefile
>> @@ -1,5 +1,5 @@
>> -rtl8180-objs         := dev.o rtl8225.o sa2400.o max2820.o grf5101.o rtl8225se.o
>> +rtl818x_pci-objs     := dev.o rtl8225.o sa2400.o max2820.o grf5101.o rtl8225se.o
>>
>> -obj-$(CONFIG_RTL8180)        += rtl8180.o
>> +obj-$(CONFIG_RTL8180)        += rtl818x_pci.o
>>
>>  ccflags-y += -Idrivers/net/wireless/rtl818x
>> --
>> 1.8.3.2
>>
>>
>
> --
> John W. Linville                Someday the world will need a hero, and you
> linville@tuxdriver.com                  might be all we have.  Be ready.
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
John W. Linville April 9, 2014, 4:42 p.m. UTC | #3
NM, I've got them -- they just got sorted strangely in my mailbox...

On Wed, Apr 09, 2014 at 06:30:14PM +0200, Andrea Merello wrote:
> Yes, it is.
> It seems that at least the wireless ML received it.
> http://marc.info/?l=linux-wireless&m=139662852419525&w=2
> 
> BTW I can resend if you need it.
> 
> On Wed, Apr 9, 2014 at 6:10 PM, John W. Linville <linville@tuxdriver.com> wrote:
> > I see parts 1, 3, and 4/4.  Is there a part 2/4 that I missed?
> >
> > On Tue, Apr 08, 2014 at 08:25:25PM +0200, Andrea Merello wrote:
> >> From: Larry Finger <Larry.Finger@lwfinger.net> [ original patch ]
> >>
> >> rtl8180 driver can handle also rtl8185 and rtl8187SE cards,
> >> however in userspace tools (network manager) it still appares
> >> as "rtl8180".
> >> This might lead the user to think the wrong driver is in use.
> >>
> >> This patch changes module name to "rtl818x_pci" that should be
> >> more explanatory.
> >>
> >> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net> [ original patch ]
> >> Signed-off-by: Andrea Merello <andrea.merello@gmail.com>
> >> ---
> >>  drivers/net/wireless/rtl818x/rtl8180/Makefile | 4 ++--
> >>  1 file changed, 2 insertions(+), 2 deletions(-)
> >>
> >> diff --git a/drivers/net/wireless/rtl818x/rtl8180/Makefile b/drivers/net/wireless/rtl818x/rtl8180/Makefile
> >> index 08b056d..21005bd 100644
> >> --- a/drivers/net/wireless/rtl818x/rtl8180/Makefile
> >> +++ b/drivers/net/wireless/rtl818x/rtl8180/Makefile
> >> @@ -1,5 +1,5 @@
> >> -rtl8180-objs         := dev.o rtl8225.o sa2400.o max2820.o grf5101.o rtl8225se.o
> >> +rtl818x_pci-objs     := dev.o rtl8225.o sa2400.o max2820.o grf5101.o rtl8225se.o
> >>
> >> -obj-$(CONFIG_RTL8180)        += rtl8180.o
> >> +obj-$(CONFIG_RTL8180)        += rtl818x_pci.o
> >>
> >>  ccflags-y += -Idrivers/net/wireless/rtl818x
> >> --
> >> 1.8.3.2
> >>
> >>
> >
> > --
> > John W. Linville                Someday the world will need a hero, and you
> > linville@tuxdriver.com                  might be all we have.  Be ready.
>
diff mbox

Patch

diff --git a/drivers/net/wireless/rtl818x/rtl8180/Makefile b/drivers/net/wireless/rtl818x/rtl8180/Makefile
index 08b056d..21005bd 100644
--- a/drivers/net/wireless/rtl818x/rtl8180/Makefile
+++ b/drivers/net/wireless/rtl818x/rtl8180/Makefile
@@ -1,5 +1,5 @@ 
-rtl8180-objs		:= dev.o rtl8225.o sa2400.o max2820.o grf5101.o rtl8225se.o
+rtl818x_pci-objs	:= dev.o rtl8225.o sa2400.o max2820.o grf5101.o rtl8225se.o
 
-obj-$(CONFIG_RTL8180)	+= rtl8180.o
+obj-$(CONFIG_RTL8180)	+= rtl818x_pci.o
 
 ccflags-y += -Idrivers/net/wireless/rtl818x