| Message ID | 1397118296-6846-3-git-send-email-sachin.kamat@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Sachin, On 10.04.2014 10:24, Sachin Kamat wrote: > 'exynos_subsys' is now local to this file. Make it static > and remove the declaration from header file. > > Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> > --- > arch/arm/mach-exynos/exynos.c | 2 +- > arch/arm/plat-samsung/include/plat/cpu.h | 1 - > 2 files changed, 1 insertion(+), 2 deletions(-) > > diff --git a/arch/arm/mach-exynos/exynos.c b/arch/arm/mach-exynos/exynos.c > index 6a5fe18ec9b1..0ef42b9efd36 100644 > --- a/arch/arm/mach-exynos/exynos.c > +++ b/arch/arm/mach-exynos/exynos.c > @@ -284,7 +284,7 @@ void __init exynos_init_io(void) > of_scan_flat_dt(exynos_fdt_map_sysram, NULL); > } > > -struct bus_type exynos_subsys = { > +static struct bus_type exynos_subsys = { > .name = "exynos-core", > .dev_name = "exynos-core", > }; > diff --git a/arch/arm/plat-samsung/include/plat/cpu.h b/arch/arm/plat-samsung/include/plat/cpu.h > index 5992b8dd9b89..930b4be832cd 100644 > --- a/arch/arm/plat-samsung/include/plat/cpu.h > +++ b/arch/arm/plat-samsung/include/plat/cpu.h > @@ -239,7 +239,6 @@ extern struct bus_type s3c2443_subsys; > extern struct bus_type s3c6410_subsys; > extern struct bus_type s5p64x0_subsys; > extern struct bus_type s5pv210_subsys; > -extern struct bus_type exynos_subsys; > > extern void (*s5pc1xx_idle)(void); > > This struct and registration of it do not seem to be needed for anything anymore. Would you consider removing it instead? Best regards, Tomasz
Hi Tomasz, On 10 April 2014 14:47, Tomasz Figa <t.figa@samsung.com> wrote: > Hi Sachin, > > > On 10.04.2014 10:24, Sachin Kamat wrote: >> >> 'exynos_subsys' is now local to this file. Make it static >> and remove the declaration from header file. >> >> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> >> --- >> arch/arm/mach-exynos/exynos.c | 2 +- >> arch/arm/plat-samsung/include/plat/cpu.h | 1 - >> 2 files changed, 1 insertion(+), 2 deletions(-) >> >> diff --git a/arch/arm/mach-exynos/exynos.c b/arch/arm/mach-exynos/exynos.c >> index 6a5fe18ec9b1..0ef42b9efd36 100644 >> --- a/arch/arm/mach-exynos/exynos.c >> +++ b/arch/arm/mach-exynos/exynos.c >> @@ -284,7 +284,7 @@ void __init exynos_init_io(void) >> of_scan_flat_dt(exynos_fdt_map_sysram, NULL); >> } >> >> -struct bus_type exynos_subsys = { >> +static struct bus_type exynos_subsys = { >> .name = "exynos-core", >> .dev_name = "exynos-core", >> }; >> diff --git a/arch/arm/plat-samsung/include/plat/cpu.h >> b/arch/arm/plat-samsung/include/plat/cpu.h >> index 5992b8dd9b89..930b4be832cd 100644 >> --- a/arch/arm/plat-samsung/include/plat/cpu.h >> +++ b/arch/arm/plat-samsung/include/plat/cpu.h >> @@ -239,7 +239,6 @@ extern struct bus_type s3c2443_subsys; >> extern struct bus_type s3c6410_subsys; >> extern struct bus_type s5p64x0_subsys; >> extern struct bus_type s5pv210_subsys; >> -extern struct bus_type exynos_subsys; >> >> extern void (*s5pc1xx_idle)(void); >> >> > > This struct and registration of it do not seem to be needed for anything > anymore. Would you consider removing it instead? I had considered removing that while I was doing other code consolidation of this file. However I found that without this, the system failed to boot. I did not look much into it then. Probably I can revisit it and if it doesn't cause any boot issue, will remove it.
On 10.04.2014 11:22, Sachin Kamat wrote: > Hi Tomasz, > > On 10 April 2014 14:47, Tomasz Figa <t.figa@samsung.com> wrote: >> Hi Sachin, >> >> >> On 10.04.2014 10:24, Sachin Kamat wrote: >>> >>> 'exynos_subsys' is now local to this file. Make it static >>> and remove the declaration from header file. >>> >>> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> >>> --- >>> arch/arm/mach-exynos/exynos.c | 2 +- >>> arch/arm/plat-samsung/include/plat/cpu.h | 1 - >>> 2 files changed, 1 insertion(+), 2 deletions(-) >>> >>> diff --git a/arch/arm/mach-exynos/exynos.c b/arch/arm/mach-exynos/exynos.c >>> index 6a5fe18ec9b1..0ef42b9efd36 100644 >>> --- a/arch/arm/mach-exynos/exynos.c >>> +++ b/arch/arm/mach-exynos/exynos.c >>> @@ -284,7 +284,7 @@ void __init exynos_init_io(void) >>> of_scan_flat_dt(exynos_fdt_map_sysram, NULL); >>> } >>> >>> -struct bus_type exynos_subsys = { >>> +static struct bus_type exynos_subsys = { >>> .name = "exynos-core", >>> .dev_name = "exynos-core", >>> }; >>> diff --git a/arch/arm/plat-samsung/include/plat/cpu.h >>> b/arch/arm/plat-samsung/include/plat/cpu.h >>> index 5992b8dd9b89..930b4be832cd 100644 >>> --- a/arch/arm/plat-samsung/include/plat/cpu.h >>> +++ b/arch/arm/plat-samsung/include/plat/cpu.h >>> @@ -239,7 +239,6 @@ extern struct bus_type s3c2443_subsys; >>> extern struct bus_type s3c6410_subsys; >>> extern struct bus_type s5p64x0_subsys; >>> extern struct bus_type s5pv210_subsys; >>> -extern struct bus_type exynos_subsys; >>> >>> extern void (*s5pc1xx_idle)(void); >>> >>> >> >> This struct and registration of it do not seem to be needed for anything >> anymore. Would you consider removing it instead? > > I had considered removing that while I was doing other code consolidation > of this file. However I found that without this, the system failed to boot. I > did not look much into it then. Probably I can revisit it and if it > doesn't cause > any boot issue, will remove it. > Hmm, I don't see why it could break anything as I can't find any users of it. Anyway I just tested removing this code on Exynos4412-trats2 board and didn't find any problems. Best regards, Tomasz
On 10 April 2014 18:02, Tomasz Figa <t.figa@samsung.com> wrote: > On 10.04.2014 11:22, Sachin Kamat wrote: >> >> Hi Tomasz, >> >> On 10 April 2014 14:47, Tomasz Figa <t.figa@samsung.com> wrote: >>> >>> Hi Sachin, >>> >>> >>> On 10.04.2014 10:24, Sachin Kamat wrote: >>>> >>>> >>>> 'exynos_subsys' is now local to this file. Make it static >>>> and remove the declaration from header file. >>>> >>>> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> >>>> --- >>>> arch/arm/mach-exynos/exynos.c | 2 +- >>>> arch/arm/plat-samsung/include/plat/cpu.h | 1 - >>>> 2 files changed, 1 insertion(+), 2 deletions(-) >>>> >>>> diff --git a/arch/arm/mach-exynos/exynos.c >>>> b/arch/arm/mach-exynos/exynos.c >>>> index 6a5fe18ec9b1..0ef42b9efd36 100644 >>>> --- a/arch/arm/mach-exynos/exynos.c >>>> +++ b/arch/arm/mach-exynos/exynos.c >>>> @@ -284,7 +284,7 @@ void __init exynos_init_io(void) >>>> of_scan_flat_dt(exynos_fdt_map_sysram, NULL); >>>> } >>>> >>>> -struct bus_type exynos_subsys = { >>>> +static struct bus_type exynos_subsys = { >>>> .name = "exynos-core", >>>> .dev_name = "exynos-core", >>>> }; >>>> diff --git a/arch/arm/plat-samsung/include/plat/cpu.h >>>> b/arch/arm/plat-samsung/include/plat/cpu.h >>>> index 5992b8dd9b89..930b4be832cd 100644 >>>> --- a/arch/arm/plat-samsung/include/plat/cpu.h >>>> +++ b/arch/arm/plat-samsung/include/plat/cpu.h >>>> @@ -239,7 +239,6 @@ extern struct bus_type s3c2443_subsys; >>>> extern struct bus_type s3c6410_subsys; >>>> extern struct bus_type s5p64x0_subsys; >>>> extern struct bus_type s5pv210_subsys; >>>> -extern struct bus_type exynos_subsys; >>>> >>>> extern void (*s5pc1xx_idle)(void); >>>> >>>> >>> >>> This struct and registration of it do not seem to be needed for anything >>> anymore. Would you consider removing it instead? >> >> >> I had considered removing that while I was doing other code consolidation >> of this file. However I found that without this, the system failed to >> boot. I >> did not look much into it then. Probably I can revisit it and if it >> doesn't cause >> any boot issue, will remove it. >> > > Hmm, I don't see why it could break anything as I can't find any users of > it. Anyway I just tested removing this code on Exynos4412-trats2 board and > didn't find any problems. Thanks for testing. Let me check at my end on other boards and if it doesn't cause any problem, will remove this.
Hi Tomasz, On 10 April 2014 18:05, Sachin Kamat <sachin.kamat@linaro.org> wrote: > On 10 April 2014 18:02, Tomasz Figa <t.figa@samsung.com> wrote: >> On 10.04.2014 11:22, Sachin Kamat wrote: >>> >>> Hi Tomasz, >>> >>> On 10 April 2014 14:47, Tomasz Figa <t.figa@samsung.com> wrote: <snip> >> Hmm, I don't see why it could break anything as I can't find any users of >> it. Anyway I just tested removing this code on Exynos4412-trats2 board and >> didn't find any problems. > > Thanks for testing. Let me check at my end on other boards and if it > doesn't cause > any problem, will remove this. Tested after removing this code on various boards and there doesn't seem to be any problems. Will re-send with this change.
diff --git a/arch/arm/mach-exynos/exynos.c b/arch/arm/mach-exynos/exynos.c index 6a5fe18ec9b1..0ef42b9efd36 100644 --- a/arch/arm/mach-exynos/exynos.c +++ b/arch/arm/mach-exynos/exynos.c @@ -284,7 +284,7 @@ void __init exynos_init_io(void) of_scan_flat_dt(exynos_fdt_map_sysram, NULL); } -struct bus_type exynos_subsys = { +static struct bus_type exynos_subsys = { .name = "exynos-core", .dev_name = "exynos-core", }; diff --git a/arch/arm/plat-samsung/include/plat/cpu.h b/arch/arm/plat-samsung/include/plat/cpu.h index 5992b8dd9b89..930b4be832cd 100644 --- a/arch/arm/plat-samsung/include/plat/cpu.h +++ b/arch/arm/plat-samsung/include/plat/cpu.h @@ -239,7 +239,6 @@ extern struct bus_type s3c2443_subsys; extern struct bus_type s3c6410_subsys; extern struct bus_type s5p64x0_subsys; extern struct bus_type s5pv210_subsys; -extern struct bus_type exynos_subsys; extern void (*s5pc1xx_idle)(void);
'exynos_subsys' is now local to this file. Make it static and remove the declaration from header file. Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> --- arch/arm/mach-exynos/exynos.c | 2 +- arch/arm/plat-samsung/include/plat/cpu.h | 1 - 2 files changed, 1 insertion(+), 2 deletions(-)