| Message ID | 1397124377-16969-4-git-send-email-cw00.choi@samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thu, Apr 10, 2014 at 07:06:02PM +0900, Chanwoo Choi wrote: > This patch add interrupt-parent node to connected with GIC. > All interrupt-related dt nodes need default interrupt-parent node. > > Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com> > Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com> There's no point in splitting these off in separate patches; fold them into one patch that introduces the SoC dtsi, please. Also, you missed your sign-off on one or two of the previous ones, but that won't be a problem once they're folded in. :) Finally, if the code is yours, and you're posting it, then Kyungmin should probably have a Reviewed-by or Acked-by tag, not a Signed-off-by. See Documentation/SubmittingPatches, section 12 and 13. -Olof
Hi, On 04/11/2014 01:00 PM, Olof Johansson wrote: > On Thu, Apr 10, 2014 at 07:06:02PM +0900, Chanwoo Choi wrote: >> This patch add interrupt-parent node to connected with GIC. >> All interrupt-related dt nodes need default interrupt-parent node. >> >> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com> >> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com> > > There's no point in splitting these off in separate patches; fold them > into one patch that introduces the SoC dtsi, please. OK, I will consolidate following two patches into one patch. [PATCH 11/27] ARM: dts: exynos3250: Add GIC dt node for Exynos3250 [PATCH 12/27] ARM: dts: exynos3250: Add default interrupt-parent connected with GIC > > Also, you missed your sign-off on one or two of the previous ones, but that > won't be a problem once they're folded in. :) I'll add my sign-off to all the patches on next posting(v2). > > Finally, if the code is yours, and you're posting it, then Kyungmin should > probably have a Reviewed-by or Acked-by tag, not a Signed-off-by. See > Documentation/SubmittingPatches, section 12 and 13. > OK, I'll change from 'Signed-off-by' to 'Acked-by'. Thanks, Best Regards, Chanwoo Choi
Hi Chanwoo, On 11.04.2014 06:44, Chanwoo Choi wrote: > Hi, > > On 04/11/2014 01:00 PM, Olof Johansson wrote: >> On Thu, Apr 10, 2014 at 07:06:02PM +0900, Chanwoo Choi wrote: >>> This patch add interrupt-parent node to connected with GIC. >>> All interrupt-related dt nodes need default interrupt-parent node. >>> >>> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com> >>> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com> >> >> There's no point in splitting these off in separate patches; fold them >> into one patch that introduces the SoC dtsi, please. > > OK, I will consolidate following two patches into one patch. > > [PATCH 11/27] ARM: dts: exynos3250: Add GIC dt node for Exynos3250 > [PATCH 12/27] ARM: dts: exynos3250: Add default interrupt-parent connected with GIC > I believe the intention was to squash all the patches related to exynos3250.dtsi into a single patch called "ARM: dts: Add device tree sources for Exynos3250". To retain authorship information, signed-off-by tags should be merged from all those patches too. Best regards, Tomasz
Hi Tomasz, On Fri, Apr 11, 2014 at 5:51 PM, Tomasz Figa <t.figa@samsung.com> wrote: > Hi Chanwoo, > > > On 11.04.2014 06:44, Chanwoo Choi wrote: >> >> Hi, >> >> On 04/11/2014 01:00 PM, Olof Johansson wrote: >>> >>> On Thu, Apr 10, 2014 at 07:06:02PM +0900, Chanwoo Choi wrote: >>>> >>>> This patch add interrupt-parent node to connected with GIC. >>>> All interrupt-related dt nodes need default interrupt-parent node. >>>> >>>> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com> >>>> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com> >>> >>> >>> There's no point in splitting these off in separate patches; fold them >>> into one patch that introduces the SoC dtsi, please. >> >> >> OK, I will consolidate following two patches into one patch. >> >> [PATCH 11/27] ARM: dts: exynos3250: Add GIC dt node for Exynos3250 >> [PATCH 12/27] ARM: dts: exynos3250: Add default interrupt-parent connected >> with GIC >> > > I believe the intention was to squash all the patches related to > exynos3250.dtsi into a single patch called "ARM: dts: Add device tree > sources for Exynos3250". To retain authorship information, signed-off-by > tags should be merged from all those patches too. > As you comment, I will consolidate exynos3250.dtsi into only one patch on next posting(v2). Thanks, Best Regards, Chanwoo Choi
diff --git a/arch/arm/boot/dts/exynos3250.dtsi b/arch/arm/boot/dts/exynos3250.dtsi index fe8960e..13efdbed 100644 --- a/arch/arm/boot/dts/exynos3250.dtsi +++ b/arch/arm/boot/dts/exynos3250.dtsi @@ -21,6 +21,7 @@ / { compatible = "samsung,exynos3250"; + interrupt-parent = <&gic>; chipid@10000000 { compatible = "samsung,exynos4210-chipid";