| Message ID | 1397124377-16969-2-git-send-email-cw00.choi@samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Chanwoo, On 10 April 2014 15:36, Chanwoo Choi <cw00.choi@samsung.com> wrote: > From: Tomasz Figa <t.figa@samsung.com> > > This patch add new exynos3250.dtsi to support Exynos3250 SoC and includes > chipid/sys_reg dt node. > > Signed-off-by: Tomasz Figa <t.figa@samsung.com> > Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com> > Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com> > --- > arch/arm/boot/dts/exynos3250.dtsi | 34 ++++++++++++++++++++++++++++++++++ > 1 file changed, 34 insertions(+) > create mode 100644 arch/arm/boot/dts/exynos3250.dtsi > > diff --git a/arch/arm/boot/dts/exynos3250.dtsi b/arch/arm/boot/dts/exynos3250.dtsi > new file mode 100644 > index 0000000..3c8cee6 > --- /dev/null > +++ b/arch/arm/boot/dts/exynos3250.dtsi > @@ -0,0 +1,34 @@ > +/* > + * Samsung's Exynos3250 SoC device tree source > + * > + * Copyright (c) 2014 Samsung Electronics Co., Ltd. > + * http://www.samsung.com > + * > + * Samsung's Exynos3250 SoC device nodes are listed in this file. Exynos3250 > + * based board files can include this file and provide values for board specfic > + * bindings. > + * > + * Note: This file does not include device nodes for all the controllers in > + * Exynos3250 SoC. As device tree coverage for Exynos3250 increases, additional > + * nodes can be added to this file. > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License version 2 as > + * published by the Free Software Foundation. > + */ > + > +#include "skeleton.dtsi" > + > +/ { > + compatible = "samsung,exynos3250"; > + > + chipid@10000000 { > + compatible = "samsung,exynos4210-chipid"; > + reg = <0x10000000 0x100>; > + }; > + > + sys_reg: syscon@10010000 { > + compatible = "samsung,exynos3-sysreg", "syscon"; > + reg = <0x10010000 0x400>; > + }; > +}; Shouldn't these be grouped under the soc node?
Hi, On 04/11/2014 01:01 PM, Sachin Kamat wrote: > Hi Chanwoo, > > On 10 April 2014 15:36, Chanwoo Choi <cw00.choi@samsung.com> wrote: >> From: Tomasz Figa <t.figa@samsung.com> >> >> This patch add new exynos3250.dtsi to support Exynos3250 SoC and includes >> chipid/sys_reg dt node. >> >> Signed-off-by: Tomasz Figa <t.figa@samsung.com> >> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com> >> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com> >> --- >> arch/arm/boot/dts/exynos3250.dtsi | 34 ++++++++++++++++++++++++++++++++++ >> 1 file changed, 34 insertions(+) >> create mode 100644 arch/arm/boot/dts/exynos3250.dtsi >> >> diff --git a/arch/arm/boot/dts/exynos3250.dtsi b/arch/arm/boot/dts/exynos3250.dtsi >> new file mode 100644 >> index 0000000..3c8cee6 >> --- /dev/null >> +++ b/arch/arm/boot/dts/exynos3250.dtsi >> @@ -0,0 +1,34 @@ >> +/* >> + * Samsung's Exynos3250 SoC device tree source >> + * >> + * Copyright (c) 2014 Samsung Electronics Co., Ltd. >> + * http://www.samsung.com >> + * >> + * Samsung's Exynos3250 SoC device nodes are listed in this file. Exynos3250 >> + * based board files can include this file and provide values for board specfic >> + * bindings. >> + * >> + * Note: This file does not include device nodes for all the controllers in >> + * Exynos3250 SoC. As device tree coverage for Exynos3250 increases, additional >> + * nodes can be added to this file. >> + * >> + * This program is free software; you can redistribute it and/or modify >> + * it under the terms of the GNU General Public License version 2 as >> + * published by the Free Software Foundation. >> + */ >> + >> +#include "skeleton.dtsi" >> + >> +/ { >> + compatible = "samsung,exynos3250"; >> + >> + chipid@10000000 { >> + compatible = "samsung,exynos4210-chipid"; >> + reg = <0x10000000 0x100>; >> + }; >> + >> + sys_reg: syscon@10010000 { >> + compatible = "samsung,exynos3-sysreg", "syscon"; >> + reg = <0x10010000 0x400>; >> + }; >> +}; > > Shouldn't these be grouped under the soc node? I don't understand accurate meaning. Do you have to explain more detailed comment? Best Regards, Chanwoo Choi
diff --git a/arch/arm/boot/dts/exynos3250.dtsi b/arch/arm/boot/dts/exynos3250.dtsi new file mode 100644 index 0000000..3c8cee6 --- /dev/null +++ b/arch/arm/boot/dts/exynos3250.dtsi @@ -0,0 +1,34 @@ +/* + * Samsung's Exynos3250 SoC device tree source + * + * Copyright (c) 2014 Samsung Electronics Co., Ltd. + * http://www.samsung.com + * + * Samsung's Exynos3250 SoC device nodes are listed in this file. Exynos3250 + * based board files can include this file and provide values for board specfic + * bindings. + * + * Note: This file does not include device nodes for all the controllers in + * Exynos3250 SoC. As device tree coverage for Exynos3250 increases, additional + * nodes can be added to this file. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License version 2 as + * published by the Free Software Foundation. + */ + +#include "skeleton.dtsi" + +/ { + compatible = "samsung,exynos3250"; + + chipid@10000000 { + compatible = "samsung,exynos4210-chipid"; + reg = <0x10000000 0x100>; + }; + + sys_reg: syscon@10010000 { + compatible = "samsung,exynos3-sysreg", "syscon"; + reg = <0x10010000 0x400>; + }; +};