| Message ID | 000001cf57b4$d3450780$79cf1680$@samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 14/04/14 08:40, Jungseok Lee wrote: > This patch deals with checkpatch complaint as fixing line length > exceeding 80 characters. > > WARNING: line over 80 characters > > Signed-off-by: Jungseok Lee <jays.lee@samsung.com> > Reviewed-by: Sungjinn Chung <sungjinn.chung@samsung.com> > --- > arch/arm/kvm/mmu.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/kvm/mmu.c b/arch/arm/kvm/mmu.c > index 80bb1e6..e0d4f24 100644 > --- a/arch/arm/kvm/mmu.c > +++ b/arch/arm/kvm/mmu.c > @@ -563,8 +563,8 @@ void kvm_free_stage2_pgd(struct kvm *kvm) > kvm->arch.pgd = NULL; > } > > -static pmd_t *stage2_get_pmd(struct kvm *kvm, struct kvm_mmu_memory_cache *cache, > - phys_addr_t addr) > +static pmd_t *stage2_get_pmd(struct kvm *kvm, struct kvm_mmu_memory_cache > + *cache, phys_addr_t addr) Please don't. This makes the code unreadable (and no, I don't care about checkpatch ;-). M.
On Tuesday, April 15, 2014 1:19 AM, Marc Zyngier wrote: > On 14/04/14 08:40, Jungseok Lee wrote: > > This patch deals with checkpatch complaint as fixing line length > > exceeding 80 characters. > > > > WARNING: line over 80 characters > > > > Signed-off-by: Jungseok Lee <jays.lee@samsung.com> > > Reviewed-by: Sungjinn Chung <sungjinn.chung@samsung.com> > > --- > > arch/arm/kvm/mmu.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/arch/arm/kvm/mmu.c b/arch/arm/kvm/mmu.c index > > 80bb1e6..e0d4f24 100644 > > --- a/arch/arm/kvm/mmu.c > > +++ b/arch/arm/kvm/mmu.c > > @@ -563,8 +563,8 @@ void kvm_free_stage2_pgd(struct kvm *kvm) > > kvm->arch.pgd = NULL; > > } > > > > -static pmd_t *stage2_get_pmd(struct kvm *kvm, struct kvm_mmu_memory_cache *cache, > > - phys_addr_t addr) > > +static pmd_t *stage2_get_pmd(struct kvm *kvm, struct kvm_mmu_memory_cache > > + *cache, phys_addr_t addr) > > Please don't. This makes the code unreadable (and no, I don't care about checkpatch ;-). Okay. I will drop this patch from the next version. It would be good to change stage2_set_pmd_huge function for readability if you don't care about checkpatch. Best Regards Jungseok Lee
On 15/04/14 01:38, Jungseok Lee wrote: > On Tuesday, April 15, 2014 1:19 AM, Marc Zyngier wrote: >> On 14/04/14 08:40, Jungseok Lee wrote: >>> This patch deals with checkpatch complaint as fixing line length >>> exceeding 80 characters. >>> >>> WARNING: line over 80 characters >>> >>> Signed-off-by: Jungseok Lee <jays.lee@samsung.com> >>> Reviewed-by: Sungjinn Chung <sungjinn.chung@samsung.com> >>> --- >>> arch/arm/kvm/mmu.c | 4 ++-- >>> 1 file changed, 2 insertions(+), 2 deletions(-) >>> >>> diff --git a/arch/arm/kvm/mmu.c b/arch/arm/kvm/mmu.c index >>> 80bb1e6..e0d4f24 100644 >>> --- a/arch/arm/kvm/mmu.c >>> +++ b/arch/arm/kvm/mmu.c >>> @@ -563,8 +563,8 @@ void kvm_free_stage2_pgd(struct kvm *kvm) >>> kvm->arch.pgd = NULL; >>> } >>> >>> -static pmd_t *stage2_get_pmd(struct kvm *kvm, struct kvm_mmu_memory_cache *cache, >>> - phys_addr_t addr) >>> +static pmd_t *stage2_get_pmd(struct kvm *kvm, struct kvm_mmu_memory_cache >>> + *cache, phys_addr_t addr) >> >> Please don't. This makes the code unreadable (and no, I don't care about checkpatch ;-). > > Okay. I will drop this patch from the next version. > > It would be good to change stage2_set_pmd_huge function for readability > if you don't care about checkpatch. We usually don't change that kind of thing just for the sake of changing it. It feels like fairly pointless churn. *IF* someone happens to rework that code, then they're welcome to fix it. M.
diff --git a/arch/arm/kvm/mmu.c b/arch/arm/kvm/mmu.c index 80bb1e6..e0d4f24 100644 --- a/arch/arm/kvm/mmu.c +++ b/arch/arm/kvm/mmu.c @@ -563,8 +563,8 @@ void kvm_free_stage2_pgd(struct kvm *kvm) kvm->arch.pgd = NULL; } -static pmd_t *stage2_get_pmd(struct kvm *kvm, struct kvm_mmu_memory_cache *cache, - phys_addr_t addr) +static pmd_t *stage2_get_pmd(struct kvm *kvm, struct kvm_mmu_memory_cache + *cache, phys_addr_t addr) { pgd_t *pgd; pud_t *pud;