diff mbox

[02/12] mac80211: remove config option check

Message ID 3ed41ac7f29b74d7cfc81c42715cf2dc1706066c.1398055854.git.gamerh2o@gmail.com (mailing list archive)
State Not Applicable, archived
Headers show

Commit Message

Gang ZHAO April 21, 2014, 4:52 a.m. UTC
Sanity check and error handling code shouldn't be put into
CONFIG_MAC80211_VERBOSE_DEBUG block, since verbose debug option is
used to control whether to print debug messages.

Signed-off-by: Zhao, Gang <gamerh2o@gmail.com>
---
 net/mac80211/tx.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Johannes Berg April 22, 2014, 2:44 p.m. UTC | #1
On Mon, 2014-04-21 at 12:52 +0800, Zhao, Gang wrote:
> Sanity check and error handling code shouldn't be put into
> CONFIG_MAC80211_VERBOSE_DEBUG block, since verbose debug option is
> used to control whether to print debug messages.

It's in the hotpath though, so we don't always want it, it's mostly for
development that this matters.

I don't think I want to apply this patch.

johannes


--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/net/mac80211/tx.c b/net/mac80211/tx.c
index 48650da..59715da 100644
--- a/net/mac80211/tx.c
+++ b/net/mac80211/tx.c
@@ -1205,13 +1205,11 @@  static bool ieee80211_tx_frags(struct ieee80211_local *local,
 		struct ieee80211_tx_info *info = IEEE80211_SKB_CB(skb);
 		int q = info->hw_queue;
 
-#ifdef CONFIG_MAC80211_VERBOSE_DEBUG
 		if (WARN_ON_ONCE(q >= local->hw.queues)) {
 			__skb_unlink(skb, skbs);
 			ieee80211_free_txskb(&local->hw, skb);
 			continue;
 		}
-#endif
 
 		spin_lock_irqsave(&local->queue_stop_reason_lock, flags);
 		if (local->queue_stop_reasons[q] ||