diff mbox

[PATCHv3,2/5] Input: tsc2005: use dev_err for error messages

Message ID 1398470179-20880-3-git-send-email-sre@kernel.org (mailing list archive)
State Superseded
Headers show

Commit Message

Sebastian Reichel April 25, 2014, 11:56 p.m. UTC
Change some dev_dbg() invocations to dev_err() ones, because they
are supposed to output error messages.

Signed-off-by: Sebastian Reichel <sre@kernel.org>
---
 drivers/input/touchscreen/tsc2005.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Pavel Machek April 29, 2014, 9:23 a.m. UTC | #1
On Sat 2014-04-26 01:56:16, Sebastian Reichel wrote:
> Change some dev_dbg() invocations to dev_err() ones, because they
> are supposed to output error messages.
> 
> Signed-off-by: Sebastian Reichel <sre@kernel.org>

Reviewed-by: Pavel Machek <pavel@ucw.cz>
Dmitry Torokhov May 19, 2014, 5:33 a.m. UTC | #2
On Sat, Apr 26, 2014 at 01:56:16AM +0200, Sebastian Reichel wrote:
> Change some dev_dbg() invocations to dev_err() ones, because they
> are supposed to output error messages.
> 
> Signed-off-by: Sebastian Reichel <sre@kernel.org>

Applied, thank you.

> ---
>  drivers/input/touchscreen/tsc2005.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/input/touchscreen/tsc2005.c b/drivers/input/touchscreen/tsc2005.c
> index 550adcb..520e673 100644
> --- a/drivers/input/touchscreen/tsc2005.c
> +++ b/drivers/input/touchscreen/tsc2005.c
> @@ -579,7 +579,7 @@ static int tsc2005_probe(struct spi_device *spi)
>  	int error;
>  
>  	if (!pdata) {
> -		dev_dbg(&spi->dev, "no platform data\n");
> +		dev_err(&spi->dev, "no platform data\n");
>  		return -ENODEV;
>  	}
>  
> @@ -591,7 +591,7 @@ static int tsc2005_probe(struct spi_device *spi)
>  	max_p	= pdata->ts_pressure_max   ? : MAX_12BIT;
>  
>  	if (spi->irq <= 0) {
> -		dev_dbg(&spi->dev, "no irq\n");
> +		dev_err(&spi->dev, "no irq\n");
>  		return -ENODEV;
>  	}
>  
> -- 
> 1.9.2
>
diff mbox

Patch

diff --git a/drivers/input/touchscreen/tsc2005.c b/drivers/input/touchscreen/tsc2005.c
index 550adcb..520e673 100644
--- a/drivers/input/touchscreen/tsc2005.c
+++ b/drivers/input/touchscreen/tsc2005.c
@@ -579,7 +579,7 @@  static int tsc2005_probe(struct spi_device *spi)
 	int error;
 
 	if (!pdata) {
-		dev_dbg(&spi->dev, "no platform data\n");
+		dev_err(&spi->dev, "no platform data\n");
 		return -ENODEV;
 	}
 
@@ -591,7 +591,7 @@  static int tsc2005_probe(struct spi_device *spi)
 	max_p	= pdata->ts_pressure_max   ? : MAX_12BIT;
 
 	if (spi->irq <= 0) {
-		dev_dbg(&spi->dev, "no irq\n");
+		dev_err(&spi->dev, "no irq\n");
 		return -ENODEV;
 	}