| Message ID | 1397471802-27216-5-git-send-email-ben.dooks@codethink.co.uk (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
On Mon, 14 Apr 2014, Ben Dooks wrote: > Add device-tree for vin1 (composite video in) on the > lager board. I think this patch should be the last. The rest isn't so important, but also for them I would go from more generic to device / platform / board specific ones. Thanks Guennadi > > Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk> > --- > arch/arm/boot/dts/r8a7790-lager.dts | 38 +++++++++++++++++++++++++++++++++++++ > 1 file changed, 38 insertions(+) > > diff --git a/arch/arm/boot/dts/r8a7790-lager.dts b/arch/arm/boot/dts/r8a7790-lager.dts > index a087421..6888866 100644 > --- a/arch/arm/boot/dts/r8a7790-lager.dts > +++ b/arch/arm/boot/dts/r8a7790-lager.dts > @@ -158,6 +158,11 @@ > renesas,groups = "i2c2"; > renesas,function = "i2c2"; > }; > + > + vin1_pins: vin { > + renesas,groups = "vin1_data8", "vin1_clk"; > + renesas,function = "vin1"; > + }; > }; > > &mmcif1 { > @@ -239,8 +244,41 @@ > status = "ok"; > pinctrl-0 = <&i2c2_pins>; > pinctrl-names = "default"; > + > + adv7180: composite-in@0x20 { > + compatible = "adi,adv7180"; > + reg = <0x20>; > + remote = <&vin1>; > + > + port { > + adv7180_1: endpoint { > + bus-width = <8>; > + remote-endpoint = <&vin1ep0>; > + }; > + }; > + }; > + > }; > > &i2c3 { > status = "ok"; > }; > + > +/* composite video input */ > +&vin1 { > + pinctrl-0 = <&vin1_pins>; > + pinctrl-names = "default"; > + > + status = "ok"; > + > + port { > + #address-cells = <1>; > + #size-cells = <0>; > + > + vin1ep0: endpoint { > + remote-endpoint = <&adv7180_1>; > + bus-width = <8>; > + }; > + }; > +}; > + > -- > 1.9.1 > --- Guennadi Liakhovetski, Ph.D. Freelance Open-Source Software Developer http://www.open-technology.de/ -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hello. On 04/14/2014 02:36 PM, Ben Dooks wrote: > Add device-tree for vin1 (composite video in) on the > lager board. > Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk> > --- > arch/arm/boot/dts/r8a7790-lager.dts | 38 +++++++++++++++++++++++++++++++++++++ > 1 file changed, 38 insertions(+) > diff --git a/arch/arm/boot/dts/r8a7790-lager.dts b/arch/arm/boot/dts/r8a7790-lager.dts > index a087421..6888866 100644 > --- a/arch/arm/boot/dts/r8a7790-lager.dts > +++ b/arch/arm/boot/dts/r8a7790-lager.dts [...] > @@ -239,8 +244,41 @@ > status = "ok"; > pinctrl-0 = <&i2c2_pins>; > pinctrl-names = "default"; > + > + adv7180: composite-in@0x20 { You're not using that label, as far as I could see. > + compatible = "adi,adv7180"; > + reg = <0x20>; > + remote = <&vin1>; > + > + port { > + adv7180_1: endpoint { So, you could use 'adv7180:' here instead... > + bus-width = <8>; > + remote-endpoint = <&vin1ep0>; > + }; > + }; > + }; > + WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hello. On 04/14/2014 02:36 PM, Ben Dooks wrote: > Add device-tree for vin1 (composite video in) on the > lager board. > Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk> > --- > arch/arm/boot/dts/r8a7790-lager.dts | 38 +++++++++++++++++++++++++++++++++++++ > 1 file changed, 38 insertions(+) > diff --git a/arch/arm/boot/dts/r8a7790-lager.dts b/arch/arm/boot/dts/r8a7790-lager.dts > index a087421..6888866 100644 > --- a/arch/arm/boot/dts/r8a7790-lager.dts > +++ b/arch/arm/boot/dts/r8a7790-lager.dts [...] > @@ -239,8 +244,41 @@ > status = "ok"; > pinctrl-0 = <&i2c2_pins>; > pinctrl-names = "default"; > + > + adv7180: composite-in@0x20 { Please drop "0x" from the unit-addresspart of the node name. WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm/boot/dts/r8a7790-lager.dts b/arch/arm/boot/dts/r8a7790-lager.dts index a087421..6888866 100644 --- a/arch/arm/boot/dts/r8a7790-lager.dts +++ b/arch/arm/boot/dts/r8a7790-lager.dts @@ -158,6 +158,11 @@ renesas,groups = "i2c2"; renesas,function = "i2c2"; }; + + vin1_pins: vin { + renesas,groups = "vin1_data8", "vin1_clk"; + renesas,function = "vin1"; + }; }; &mmcif1 { @@ -239,8 +244,41 @@ status = "ok"; pinctrl-0 = <&i2c2_pins>; pinctrl-names = "default"; + + adv7180: composite-in@0x20 { + compatible = "adi,adv7180"; + reg = <0x20>; + remote = <&vin1>; + + port { + adv7180_1: endpoint { + bus-width = <8>; + remote-endpoint = <&vin1ep0>; + }; + }; + }; + }; &i2c3 { status = "ok"; }; + +/* composite video input */ +&vin1 { + pinctrl-0 = <&vin1_pins>; + pinctrl-names = "default"; + + status = "ok"; + + port { + #address-cells = <1>; + #size-cells = <0>; + + vin1ep0: endpoint { + remote-endpoint = <&adv7180_1>; + bus-width = <8>; + }; + }; +}; +
Add device-tree for vin1 (composite video in) on the lager board. Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk> --- arch/arm/boot/dts/r8a7790-lager.dts | 38 +++++++++++++++++++++++++++++++++++++ 1 file changed, 38 insertions(+)