| Message ID | 1398769513-8736-6-git-send-email-rnayak@ti.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tuesday 29 April 2014 16:35:13 Rajendra Nayak wrote: > @@ -393,7 +395,12 @@ IS_OMAP_TYPE(3430, 0x3430) > > #if defined(CONFIG_SOC_DRA7XX) > #undef soc_is_dra7xx > +#undef soc_is_dra74x > +#undef soc_is_dra72x > #define soc_is_dra7xx() (of_machine_is_compatible("ti,dra7")) > +#define soc_is_dra74x() (of_machine_is_compatible("ti,dra74")) > +#define soc_is_dra72x() (of_machine_is_compatible("ti,dra72")) > + You shouldn't normally have to define these. Why are they needed? Maybe it's better to wait for a user to show up, and then we can decide whether we actually want to have them this way, or if there is a better solution for the particular use case. Normally, we'd want to make run-time decisions based on properties of the nodes a driver is working on, not the global machine compatible string. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tuesday 29 April 2014 04:48 PM, Arnd Bergmann wrote: > On Tuesday 29 April 2014 16:35:13 Rajendra Nayak wrote: >> @@ -393,7 +395,12 @@ IS_OMAP_TYPE(3430, 0x3430) >> >> #if defined(CONFIG_SOC_DRA7XX) >> #undef soc_is_dra7xx >> +#undef soc_is_dra74x >> +#undef soc_is_dra72x >> #define soc_is_dra7xx() (of_machine_is_compatible("ti,dra7")) >> +#define soc_is_dra74x() (of_machine_is_compatible("ti,dra74")) >> +#define soc_is_dra72x() (of_machine_is_compatible("ti,dra72")) >> + > > You shouldn't normally have to define these. Why are they needed? > > Maybe it's better to wait for a user to show up, and then we can decide > whether we actually want to have them this way, or if there is a better > solution for the particular use case. > > Normally, we'd want to make run-time decisions based on properties > of the nodes a driver is working on, not the global machine compatible > string. Yeah, actually this can be dropped. There is no user for it now. > > Arnd > -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
* Rajendra Nayak <rnayak@ti.com> [140429 04:22]: > On Tuesday 29 April 2014 04:48 PM, Arnd Bergmann wrote: > > On Tuesday 29 April 2014 16:35:13 Rajendra Nayak wrote: > >> @@ -393,7 +395,12 @@ IS_OMAP_TYPE(3430, 0x3430) > >> > >> #if defined(CONFIG_SOC_DRA7XX) > >> #undef soc_is_dra7xx > >> +#undef soc_is_dra74x > >> +#undef soc_is_dra72x > >> #define soc_is_dra7xx() (of_machine_is_compatible("ti,dra7")) > >> +#define soc_is_dra74x() (of_machine_is_compatible("ti,dra74")) > >> +#define soc_is_dra72x() (of_machine_is_compatible("ti,dra72")) > >> + > > > > You shouldn't normally have to define these. Why are they needed? > > > > Maybe it's better to wait for a user to show up, and then we can decide > > whether we actually want to have them this way, or if there is a better > > solution for the particular use case. > > > > Normally, we'd want to make run-time decisions based on properties > > of the nodes a driver is working on, not the global machine compatible > > string. > > Yeah, actually this can be dropped. There is no user for it now. OK applying all but the last patch into omap-for-v3.16/dt branch, it seems there's no need to separate out the fixes in this case. Regards, Tony -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tuesday 06 May 2014 09:58 PM, Tony Lindgren wrote: > * Rajendra Nayak <rnayak@ti.com> [140429 04:22]: >> On Tuesday 29 April 2014 04:48 PM, Arnd Bergmann wrote: >>> On Tuesday 29 April 2014 16:35:13 Rajendra Nayak wrote: >>>> @@ -393,7 +395,12 @@ IS_OMAP_TYPE(3430, 0x3430) >>>> >>>> #if defined(CONFIG_SOC_DRA7XX) >>>> #undef soc_is_dra7xx >>>> +#undef soc_is_dra74x >>>> +#undef soc_is_dra72x >>>> #define soc_is_dra7xx() (of_machine_is_compatible("ti,dra7")) >>>> +#define soc_is_dra74x() (of_machine_is_compatible("ti,dra74")) >>>> +#define soc_is_dra72x() (of_machine_is_compatible("ti,dra72")) >>>> + >>> >>> You shouldn't normally have to define these. Why are they needed? >>> >>> Maybe it's better to wait for a user to show up, and then we can decide >>> whether we actually want to have them this way, or if there is a better >>> solution for the particular use case. >>> >>> Normally, we'd want to make run-time decisions based on properties >>> of the nodes a driver is working on, not the global machine compatible >>> string. >> >> Yeah, actually this can be dropped. There is no user for it now. > > OK applying all but the last patch into omap-for-v3.16/dt branch, > it seems there's no need to separate out the fixes in this case. Thanks Tony. > > Regards, > > Tony > -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm/mach-omap2/soc.h b/arch/arm/mach-omap2/soc.h index 30abcc8..5ff724e 100644 --- a/arch/arm/mach-omap2/soc.h +++ b/arch/arm/mach-omap2/soc.h @@ -245,6 +245,8 @@ IS_AM_SUBCLASS(437x, 0x437) #define soc_is_omap54xx() 0 #define soc_is_omap543x() 0 #define soc_is_dra7xx() 0 +#define soc_is_dra74x() 0 +#define soc_is_dra72x() 0 #if defined(MULTI_OMAP2) # if defined(CONFIG_ARCH_OMAP2) @@ -393,7 +395,12 @@ IS_OMAP_TYPE(3430, 0x3430) #if defined(CONFIG_SOC_DRA7XX) #undef soc_is_dra7xx +#undef soc_is_dra74x +#undef soc_is_dra72x #define soc_is_dra7xx() (of_machine_is_compatible("ti,dra7")) +#define soc_is_dra74x() (of_machine_is_compatible("ti,dra74")) +#define soc_is_dra72x() (of_machine_is_compatible("ti,dra72")) + #endif /* Various silicon revisions for omap2 */
Use the corresponding compatibles to identify the devices. Signed-off-by: Rajendra Nayak <rnayak@ti.com> --- arch/arm/mach-omap2/soc.h | 7 +++++++ 1 file changed, 7 insertions(+)