diff mbox

[KVM-AUTOTEST,11/17] KVM test: kvm_tests.cfg.sample: convert PPM files to PNG by default

Message ID 8cb328ac5429d808714dd252a456e6d3dd3a96b2.1248102188.git.mgoldish@redhat.com (mailing list archive)
State New, archived
Headers show

Commit Message

Michael Goldish July 20, 2009, 3:07 p.m. UTC
By default, always remove PPM files, and keep PNG files only for failed tests.
This shouldn't do much harm, because while PPMs can be incorporated directly
into step files, PNGs can be converted back to PPMs easily, and take less disk
space.
(PNG is a lossless compression format.)

The 'keep_ppm_files' and 'keep_ppm_files_on_error' settings are commented out
so the user can easily enable them if desired.

Signed-off-by: Michael Goldish <mgoldish@redhat.com>
---
 client/tests/kvm/kvm_tests.cfg.sample |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

Comments

Lucas Meneghel Rodrigues July 24, 2009, 7:38 p.m. UTC | #1
On Mon, Jul 20, 2009 at 12:07 PM, Michael Goldish<mgoldish@redhat.com> wrote:
> By default, always remove PPM files, and keep PNG files only for failed tests.
> This shouldn't do much harm, because while PPMs can be incorporated directly
> into step files, PNGs can be converted back to PPMs easily, and take less disk
> space.
> (PNG is a lossless compression format.)
>
> The 'keep_ppm_files' and 'keep_ppm_files_on_error' settings are commented out
> so the user can easily enable them if desired.

Applied.

> Signed-off-by: Michael Goldish <mgoldish@redhat.com>
> ---
>  client/tests/kvm/kvm_tests.cfg.sample |    5 +++--
>  1 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/client/tests/kvm/kvm_tests.cfg.sample b/client/tests/kvm/kvm_tests.cfg.sample
> index 02112b7..1288952 100644
> --- a/client/tests/kvm/kvm_tests.cfg.sample
> +++ b/client/tests/kvm/kvm_tests.cfg.sample
> @@ -8,8 +8,9 @@ main_vm = vm1
>
>  # Some preprocessor/postprocessor params
>  start_vm = yes
> -keep_ppm_files = no
> -keep_ppm_files_on_error = yes
> +convert_ppm_files_to_png_on_error = yes
> +#keep_ppm_files = yes
> +#keep_ppm_files_on_error = yes
>  kill_vm = no
>  kill_vm_gracefully = yes
>
> --
> 1.5.4.1
>
> _______________________________________________
> Autotest mailing list
> Autotest@test.kernel.org
> http://test.kernel.org/cgi-bin/mailman/listinfo/autotest
>
diff mbox

Patch

diff --git a/client/tests/kvm/kvm_tests.cfg.sample b/client/tests/kvm/kvm_tests.cfg.sample
index 02112b7..1288952 100644
--- a/client/tests/kvm/kvm_tests.cfg.sample
+++ b/client/tests/kvm/kvm_tests.cfg.sample
@@ -8,8 +8,9 @@  main_vm = vm1
 
 # Some preprocessor/postprocessor params
 start_vm = yes
-keep_ppm_files = no
-keep_ppm_files_on_error = yes
+convert_ppm_files_to_png_on_error = yes
+#keep_ppm_files = yes
+#keep_ppm_files_on_error = yes
 kill_vm = no
 kill_vm_gracefully = yes