| Message ID | 1399794680-22210-1-git-send-email-computersforpeace@gmail.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
On 05/11/2014 01:21 PM, Brian Norris wrote: > powernv_cpufreq_get() is only referenced in this file. > > Signed-off-by: Brian Norris <computersforpeace@gmail.com> > Cc: Viresh Kumar <viresh.kumar@linaro.org> > Cc: Rafael J. Wysocki <rafael.j.wysocki@intel.com> > Cc: cpufreq@vger.kernel.org > Cc: linux-pm@vger.kernel.org Reviewed-by: Srivatsa S. Bhat <srivatsa.bhat@linux.vnet.ibm.com> Regards, Srivatsa S. Bhat > --- > drivers/cpufreq/powernv-cpufreq.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/cpufreq/powernv-cpufreq.c b/drivers/cpufreq/powernv-cpufreq.c > index af4968813e76..bb1d08dc8cc8 100644 > --- a/drivers/cpufreq/powernv-cpufreq.c > +++ b/drivers/cpufreq/powernv-cpufreq.c > @@ -235,7 +235,7 @@ static void powernv_read_cpu_freq(void *arg) > * firmware for CPU 'cpu'. This value is reported through the sysfs > * file cpuinfo_cur_freq. > */ > -unsigned int powernv_cpufreq_get(unsigned int cpu) > +static unsigned int powernv_cpufreq_get(unsigned int cpu) > { > struct powernv_smp_call_data freq_data; > -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 11 May 2014 13:21, Brian Norris <computersforpeace@gmail.com> wrote: > powernv_cpufreq_get() is only referenced in this file. > > Signed-off-by: Brian Norris <computersforpeace@gmail.com> > Cc: Viresh Kumar <viresh.kumar@linaro.org> > Cc: Rafael J. Wysocki <rafael.j.wysocki@intel.com> > Cc: cpufreq@vger.kernel.org > Cc: linux-pm@vger.kernel.org > --- > drivers/cpufreq/powernv-cpufreq.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/cpufreq/powernv-cpufreq.c b/drivers/cpufreq/powernv-cpufreq.c > index af4968813e76..bb1d08dc8cc8 100644 > --- a/drivers/cpufreq/powernv-cpufreq.c > +++ b/drivers/cpufreq/powernv-cpufreq.c > @@ -235,7 +235,7 @@ static void powernv_read_cpu_freq(void *arg) > * firmware for CPU 'cpu'. This value is reported through the sysfs > * file cpuinfo_cur_freq. > */ > -unsigned int powernv_cpufreq_get(unsigned int cpu) > +static unsigned int powernv_cpufreq_get(unsigned int cpu) Please make this as static as well: cpufreq_freq_attr_cpuinfo_nominal_freq and add my Acked-by: Viresh Kumar <viresh.kumar@linaro.org> on V2. -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, May 12, 2014 at 12:02:52AM +0530, Srivatsa S. Bhat wrote: > On 05/11/2014 01:21 PM, Brian Norris wrote: > > powernv_cpufreq_get() is only referenced in this file. > > > > Signed-off-by: Brian Norris <computersforpeace@gmail.com> > > Cc: Viresh Kumar <viresh.kumar@linaro.org> > > Cc: Rafael J. Wysocki <rafael.j.wysocki@intel.com> > > Cc: cpufreq@vger.kernel.org > > Cc: linux-pm@vger.kernel.org > > Reviewed-by: Srivatsa S. Bhat <srivatsa.bhat@linux.vnet.ibm.com> Thanks for this fix Brian. Reviewed-by: Gautham R. Shenoy <ego@linux.vnet.ibm.com> -- Thanks and Regards gautham. > > Regards, > Srivatsa S. Bhat > > > --- > > drivers/cpufreq/powernv-cpufreq.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/cpufreq/powernv-cpufreq.c b/drivers/cpufreq/powernv-cpufreq.c > > index af4968813e76..bb1d08dc8cc8 100644 > > --- a/drivers/cpufreq/powernv-cpufreq.c > > +++ b/drivers/cpufreq/powernv-cpufreq.c > > @@ -235,7 +235,7 @@ static void powernv_read_cpu_freq(void *arg) > > * firmware for CPU 'cpu'. This value is reported through the sysfs > > * file cpuinfo_cur_freq. > > */ > > -unsigned int powernv_cpufreq_get(unsigned int cpu) > > +static unsigned int powernv_cpufreq_get(unsigned int cpu) > > { > > struct powernv_smp_call_data freq_data; > > -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Monday, May 12, 2014 11:24:06 AM Gautham R Shenoy wrote: > On Mon, May 12, 2014 at 12:02:52AM +0530, Srivatsa S. Bhat wrote: > > On 05/11/2014 01:21 PM, Brian Norris wrote: > > > powernv_cpufreq_get() is only referenced in this file. > > > > > > Signed-off-by: Brian Norris <computersforpeace@gmail.com> > > > Cc: Viresh Kumar <viresh.kumar@linaro.org> > > > Cc: Rafael J. Wysocki <rafael.j.wysocki@intel.com> > > > Cc: cpufreq@vger.kernel.org > > > Cc: linux-pm@vger.kernel.org > > > > Reviewed-by: Srivatsa S. Bhat <srivatsa.bhat@linux.vnet.ibm.com> > > Thanks for this fix Brian. > > Reviewed-by: Gautham R. Shenoy <ego@linux.vnet.ibm.com> Queued up for 3.16, thanks! > > -- > Thanks and Regards > gautham. > > > > > Regards, > > Srivatsa S. Bhat > > > > > --- > > > drivers/cpufreq/powernv-cpufreq.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/drivers/cpufreq/powernv-cpufreq.c b/drivers/cpufreq/powernv-cpufreq.c > > > index af4968813e76..bb1d08dc8cc8 100644 > > > --- a/drivers/cpufreq/powernv-cpufreq.c > > > +++ b/drivers/cpufreq/powernv-cpufreq.c > > > @@ -235,7 +235,7 @@ static void powernv_read_cpu_freq(void *arg) > > > * firmware for CPU 'cpu'. This value is reported through the sysfs > > > * file cpuinfo_cur_freq. > > > */ > > > -unsigned int powernv_cpufreq_get(unsigned int cpu) > > > +static unsigned int powernv_cpufreq_get(unsigned int cpu) > > > { > > > struct powernv_smp_call_data freq_data; > > > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-pm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/cpufreq/powernv-cpufreq.c b/drivers/cpufreq/powernv-cpufreq.c index af4968813e76..bb1d08dc8cc8 100644 --- a/drivers/cpufreq/powernv-cpufreq.c +++ b/drivers/cpufreq/powernv-cpufreq.c @@ -235,7 +235,7 @@ static void powernv_read_cpu_freq(void *arg) * firmware for CPU 'cpu'. This value is reported through the sysfs * file cpuinfo_cur_freq. */ -unsigned int powernv_cpufreq_get(unsigned int cpu) +static unsigned int powernv_cpufreq_get(unsigned int cpu) { struct powernv_smp_call_data freq_data;
powernv_cpufreq_get() is only referenced in this file. Signed-off-by: Brian Norris <computersforpeace@gmail.com> Cc: Viresh Kumar <viresh.kumar@linaro.org> Cc: Rafael J. Wysocki <rafael.j.wysocki@intel.com> Cc: cpufreq@vger.kernel.org Cc: linux-pm@vger.kernel.org --- drivers/cpufreq/powernv-cpufreq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)