| Message ID | 1399993292-31692-1-git-send-email-agordeev@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Delegated to: | Bjorn Helgaas |
| Headers | show |
On Tue, May 13, 2014 at 05:01:32PM +0200, Alexander Gordeev wrote: > As result of deprecation of MSI-X/MSI enablement functions > pci_enable_msix() and pci_enable_msi_block() all drivers > using these two interfaces need to be updated to use the > new pci_enable_msi_range() or pci_enable_msi_exact() > and pci_enable_msix_range() or pci_enable_msix_exact() > interfaces. > > Signed-off-by: Alexander Gordeev <agordeev@redhat.com> > Cc: Matt Porter <mporter@kernel.crashing.org> > Cc: Alexandre Bounine <alexandre.bounine@idt.com> I forgot to note this patch has also been Acked-by: Alexandre Bounine <alexandre.bounine@idt.com> > Cc: linux-pci@vger.kernel.org > --- > drivers/rapidio/devices/tsi721.c | 11 +++-------- > 1 files changed, 3 insertions(+), 8 deletions(-) > > diff --git a/drivers/rapidio/devices/tsi721.c b/drivers/rapidio/devices/tsi721.c > index 1753dc6..2ca1a0b 100644 > --- a/drivers/rapidio/devices/tsi721.c > +++ b/drivers/rapidio/devices/tsi721.c > @@ -768,15 +768,10 @@ static int tsi721_enable_msix(struct tsi721_device *priv) > } > #endif /* CONFIG_RAPIDIO_DMA_ENGINE */ > > - err = pci_enable_msix(priv->pdev, entries, ARRAY_SIZE(entries)); > + err = pci_enable_msix_exact(priv->pdev, entries, ARRAY_SIZE(entries)); > if (err) { > - if (err > 0) > - dev_info(&priv->pdev->dev, > - "Only %d MSI-X vectors available, " > - "not using MSI-X\n", err); > - else > - dev_err(&priv->pdev->dev, > - "Failed to enable MSI-X (err=%d)\n", err); > + dev_err(&priv->pdev->dev, > + "Failed to enable MSI-X (err=%d)\n", err); > return err; > } > > -- > 1.7.7.6 >
On Tue, 13 May 2014 17:01:32 +0200 Alexander Gordeev <agordeev@redhat.com> wrote: > As result of deprecation of MSI-X/MSI enablement functions > pci_enable_msix() and pci_enable_msi_block() all drivers > using these two interfaces need to be updated to use the > new pci_enable_msi_range() or pci_enable_msi_exact() > and pci_enable_msix_range() or pci_enable_msix_exact() > interfaces. > What (if any) runtime effect does this patch have? > --- a/drivers/rapidio/devices/tsi721.c > +++ b/drivers/rapidio/devices/tsi721.c > @@ -768,15 +768,10 @@ static int tsi721_enable_msix(struct tsi721_device *priv) > } > #endif /* CONFIG_RAPIDIO_DMA_ENGINE */ > > - err = pci_enable_msix(priv->pdev, entries, ARRAY_SIZE(entries)); > + err = pci_enable_msix_exact(priv->pdev, entries, ARRAY_SIZE(entries)); > if (err) { > - if (err > 0) > - dev_info(&priv->pdev->dev, > - "Only %d MSI-X vectors available, " > - "not using MSI-X\n", err); > - else > - dev_err(&priv->pdev->dev, > - "Failed to enable MSI-X (err=%d)\n", err); > + dev_err(&priv->pdev->dev, > + "Failed to enable MSI-X (err=%d)\n", err); > return err; > } > > -- > 1.7.7.6 -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, May 13, 2014 at 02:46:34PM -0700, Andrew Morton wrote: > On Tue, 13 May 2014 17:01:32 +0200 Alexander Gordeev <agordeev@redhat.com> wrote: > > > As result of deprecation of MSI-X/MSI enablement functions > > pci_enable_msix() and pci_enable_msi_block() all drivers > > using these two interfaces need to be updated to use the > > new pci_enable_msi_range() or pci_enable_msi_exact() > > and pci_enable_msix_range() or pci_enable_msix_exact() > > interfaces. > > > > What (if any) runtime effect does this patch have? None.
On Tue, May 13, 2014 at 05:01:32PM +0200, Alexander Gordeev wrote: > As result of deprecation of MSI-X/MSI enablement functions > pci_enable_msix() and pci_enable_msi_block() all drivers > using these two interfaces need to be updated to use the > new pci_enable_msi_range() or pci_enable_msi_exact() > and pci_enable_msix_range() or pci_enable_msix_exact() > interfaces. > > Signed-off-by: Alexander Gordeev <agordeev@redhat.com> > Cc: Matt Porter <mporter@kernel.crashing.org> > Cc: Alexandre Bounine <alexandre.bounine@idt.com> > Cc: linux-pci@vger.kernel.org I assume this is being handled by Matt and/or Alexandre (listed in MAINTAINERS). Let me know if I should do anything. > --- > drivers/rapidio/devices/tsi721.c | 11 +++-------- > 1 files changed, 3 insertions(+), 8 deletions(-) > > diff --git a/drivers/rapidio/devices/tsi721.c b/drivers/rapidio/devices/tsi721.c > index 1753dc6..2ca1a0b 100644 > --- a/drivers/rapidio/devices/tsi721.c > +++ b/drivers/rapidio/devices/tsi721.c > @@ -768,15 +768,10 @@ static int tsi721_enable_msix(struct tsi721_device *priv) > } > #endif /* CONFIG_RAPIDIO_DMA_ENGINE */ > > - err = pci_enable_msix(priv->pdev, entries, ARRAY_SIZE(entries)); > + err = pci_enable_msix_exact(priv->pdev, entries, ARRAY_SIZE(entries)); > if (err) { > - if (err > 0) > - dev_info(&priv->pdev->dev, > - "Only %d MSI-X vectors available, " > - "not using MSI-X\n", err); > - else > - dev_err(&priv->pdev->dev, > - "Failed to enable MSI-X (err=%d)\n", err); > + dev_err(&priv->pdev->dev, > + "Failed to enable MSI-X (err=%d)\n", err); > return err; > } > > -- > 1.7.7.6 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-pci" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, May 27, 2014 at 05:19:50PM -0600, Bjorn Helgaas wrote: > I assume this is being handled by Matt and/or Alexandre (listed in > MAINTAINERS). Let me know if I should do anything. Hi Bjorn, No worries, the patch is in Andrew's tree already.
diff --git a/drivers/rapidio/devices/tsi721.c b/drivers/rapidio/devices/tsi721.c index 1753dc6..2ca1a0b 100644 --- a/drivers/rapidio/devices/tsi721.c +++ b/drivers/rapidio/devices/tsi721.c @@ -768,15 +768,10 @@ static int tsi721_enable_msix(struct tsi721_device *priv) } #endif /* CONFIG_RAPIDIO_DMA_ENGINE */ - err = pci_enable_msix(priv->pdev, entries, ARRAY_SIZE(entries)); + err = pci_enable_msix_exact(priv->pdev, entries, ARRAY_SIZE(entries)); if (err) { - if (err > 0) - dev_info(&priv->pdev->dev, - "Only %d MSI-X vectors available, " - "not using MSI-X\n", err); - else - dev_err(&priv->pdev->dev, - "Failed to enable MSI-X (err=%d)\n", err); + dev_err(&priv->pdev->dev, + "Failed to enable MSI-X (err=%d)\n", err); return err; }
As result of deprecation of MSI-X/MSI enablement functions pci_enable_msix() and pci_enable_msi_block() all drivers using these two interfaces need to be updated to use the new pci_enable_msi_range() or pci_enable_msi_exact() and pci_enable_msix_range() or pci_enable_msix_exact() interfaces. Signed-off-by: Alexander Gordeev <agordeev@redhat.com> Cc: Matt Porter <mporter@kernel.crashing.org> Cc: Alexandre Bounine <alexandre.bounine@idt.com> Cc: linux-pci@vger.kernel.org --- drivers/rapidio/devices/tsi721.c | 11 +++-------- 1 files changed, 3 insertions(+), 8 deletions(-)