[PATCHv5,4/5] dt-bindings: add documentation for Exynos3250 clock controller

Commit Message

Chanwoo Choi May 13, 2014, 1:05 p.m. UTC

The Exynos3250 clocks are statically listed and registered using the
Samsung specific common clock helper functions. Both device tree based
clock lookup and clkdev based clock lookups are supported.

Signed-off-by: Chanwoo Choi <[e-mail]>
Signed-off-by: Tomasz Figa <[e-mail]>
Acked-by: Kyungmin Park <[e-mail]>
Cc: Mike Turquette <[e-mail]>
Cc: Kukjin Kim <[e-mail]>
Cc: Rob Herring <[e-mail]>
Cc: Pawel Moll <[e-mail]>
Cc: Mark Rutland <[e-mail]>
Cc: Ian Campbell <[e-mail]>
Cc: Kumar Gala <[e-mail]>
Cc: Randy Dunlap <[e-mail]>
Cc: Tomasz Figa <[e-mail]>
---
 .../devicetree/bindings/clock/exynos3250-clock.txt | 41 ++++++++++++++++++++++
 1 file changed, 41 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/clock/exynos3250-clock.txt

Comments

Tomasz Figa May 14, 2014, 7:35 p.m. UTC | #1

Hi,

On 13.05.2014 15:05, Chanwoo Choi wrote:
> The Exynos3250 clocks are statically listed and registered using the
> Samsung specific common clock helper functions. Both device tree based
> clock lookup and clkdev based clock lookups are supported.
> 
> Signed-off-by: Chanwoo Choi <[e-mail]>
> Signed-off-by: Tomasz Figa <[e-mail]>
> Acked-by: Kyungmin Park <[e-mail]>
> Cc: Mike Turquette <[e-mail]>
> Cc: Kukjin Kim <[e-mail]>
> Cc: Rob Herring <[e-mail]>
> Cc: Pawel Moll <[e-mail]>
> Cc: Mark Rutland <[e-mail]>
> Cc: Ian Campbell <[e-mail]>
> Cc: Kumar Gala <[e-mail]>
> Cc: Randy Dunlap <[e-mail]>
> Cc: Tomasz Figa <[e-mail]>
> ---
>  .../devicetree/bindings/clock/exynos3250-clock.txt | 41 ++++++++++++++++++++++
>  1 file changed, 41 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/clock/exynos3250-clock.txt
> 
> diff --git a/Documentation/devicetree/bindings/clock/exynos3250-clock.txt b/Documentation/devicetree/bindings/clock/exynos3250-clock.txt
> new file mode 100644
> index 0000000..aadc9c5
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/clock/exynos3250-clock.txt
> @@ -0,0 +1,41 @@
> +* Samsung Exynos3250 Clock Controller
> +
> +The Exynos3250 clock controller generates and supplies clock to various
> +controllers within the Exynos3250 SoC.
> +
> +Required Properties:
> +
> +- compatible: should be one of the following.
> +  - "samsung,exynos3250-cmu" - controller compatible with Exynos3250 SoC.
> +
> +- reg: physical base address of the controller and length of memory mapped
> +  region.
> +
> +- #clock-cells: should be 1.
> +
> +Each clock is assigned an identifier and client nodes can use this identifier
> +to specify the clock which they consume.
> +
> +All available clocks are defined as preprocessor macros in
> +dt-bindings/clock/exynos3250.h header and can be used in device
> +tree sources.
> +
> +Example 1: An example of a clock controller node is listed below.
> +
> +	cmu: clock-controller@10030000 {
> +		compatible = "samsung,exynos3250-cmu";
> +		reg = <0x10030000 0x20000>;
> +		#clock-cells = <1>;
> +	};
> +
> +Example 2: UART controller node that consumes the clock generated by the clock
> +	   controller. Refer to the standard clock bindings for information
> +	   about 'clocks' and 'clock-names' property.
> +
> +	serial@13800000 {
> +		compatible = "samsung,exynos4210-uart";
> +		reg = <0x13800000 0x100>;
> +		interrupts = <0 109 0>;
> +		clocks = <&cmu CLK_UART0>, <&cmu CLK_SCLK_UART0>;
> +		clock-names = "uart", "clk_uart_baud0";
> +	};
> 

Oops, I've forgotten to apply this one. Since it doesn't have any
dependencies, Kukjin, could you apply it on top of my pull requests with
my Ack? Thanks in advance.

Acked-by: Tomasz Figa <[e-mail]>

Best regards,
Tomasz

Kim Kukjin May 14, 2014, 7:46 p.m. UTC | #2

On 05/15/14 04:35, Tomasz Figa wrote:
> Hi,
>
> On 13.05.2014 15:05, Chanwoo Choi wrote:
>> The Exynos3250 clocks are statically listed and registered using the
>> Samsung specific common clock helper functions. Both device tree based
>> clock lookup and clkdev based clock lookups are supported.
>>
>> Signed-off-by: Chanwoo Choi<[e-mail]>
>> Signed-off-by: Tomasz Figa<[e-mail]>
>> Acked-by: Kyungmin Park<[e-mail]>
>> Cc: Mike Turquette<[e-mail]>
>> Cc: Kukjin Kim<[e-mail]>
>> Cc: Rob Herring<[e-mail]>
>> Cc: Pawel Moll<[e-mail]>
>> Cc: Mark Rutland<[e-mail]>
>> Cc: Ian Campbell<[e-mail]>
>> Cc: Kumar Gala<[e-mail]>
>> Cc: Randy Dunlap<[e-mail]>
>> Cc: Tomasz Figa<[e-mail]>
>> ---
>>   .../devicetree/bindings/clock/exynos3250-clock.txt | 41 ++++++++++++++++++++++
>>   1 file changed, 41 insertions(+)
>>   create mode 100644 Documentation/devicetree/bindings/clock/exynos3250-clock.txt
>>
>> diff --git a/Documentation/devicetree/bindings/clock/exynos3250-clock.txt b/Documentation/devicetree/bindings/clock/exynos3250-clock.txt
>> new file mode 100644
>> index 0000000..aadc9c5
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/clock/exynos3250-clock.txt
>> @@ -0,0 +1,41 @@
>> +* Samsung Exynos3250 Clock Controller
>> +
>> +The Exynos3250 clock controller generates and supplies clock to various
>> +controllers within the Exynos3250 SoC.
>> +
>> +Required Properties:
>> +
>> +- compatible: should be one of the following.
>> +  - "samsung,exynos3250-cmu" - controller compatible with Exynos3250 SoC.
>> +
>> +- reg: physical base address of the controller and length of memory mapped
>> +  region.
>> +
>> +- #clock-cells: should be 1.
>> +
>> +Each clock is assigned an identifier and client nodes can use this identifier
>> +to specify the clock which they consume.
>> +
>> +All available clocks are defined as preprocessor macros in
>> +dt-bindings/clock/exynos3250.h header and can be used in device
>> +tree sources.
>> +
>> +Example 1: An example of a clock controller node is listed below.
>> +
>> +	cmu: clock-controller@10030000 {
>> +		compatible = "samsung,exynos3250-cmu";
>> +		reg =<0x10030000 0x20000>;
>> +		#clock-cells =<1>;
>> +	};
>> +
>> +Example 2: UART controller node that consumes the clock generated by the clock
>> +	   controller. Refer to the standard clock bindings for information
>> +	   about 'clocks' and 'clock-names' property.
>> +
>> +	serial@13800000 {
>> +		compatible = "samsung,exynos4210-uart";
>> +		reg =<0x13800000 0x100>;
>> +		interrupts =<0 109 0>;
>> +		clocks =<&cmu CLK_UART0>,<&cmu CLK_SCLK_UART0>;
>> +		clock-names = "uart", "clk_uart_baud0";
>> +	};
>>
>
> Oops, I've forgotten to apply this one. Since it doesn't have any
> dependencies, Kukjin, could you apply it on top of my pull requests with
> my Ack? Thanks in advance.
>
> Acked-by: Tomasz Figa<[e-mail]>
>
Sure, I will do it on your 4/4 pull-request after pulling it into 
samsung tree.

Thanks,
Kukjin

Tomasz Figa May 14, 2014, 7:54 p.m. UTC | #3

On 14.05.2014 21:46, Kukjin Kim wrote:
> On 05/15/14 04:35, Tomasz Figa wrote:
>> Hi,
>>
>> On 13.05.2014 15:05, Chanwoo Choi wrote:
>>> The Exynos3250 clocks are statically listed and registered using the
>>> Samsung specific common clock helper functions. Both device tree based
>>> clock lookup and clkdev based clock lookups are supported.
>>>
>>> Signed-off-by: Chanwoo Choi<[e-mail]>
>>> Signed-off-by: Tomasz Figa<[e-mail]>
>>> Acked-by: Kyungmin Park<[e-mail]>
>>> Cc: Mike Turquette<[e-mail]>
>>> Cc: Kukjin Kim<[e-mail]>
>>> Cc: Rob Herring<[e-mail]>
>>> Cc: Pawel Moll<[e-mail]>
>>> Cc: Mark Rutland<[e-mail]>
>>> Cc: Ian Campbell<[e-mail]>
>>> Cc: Kumar Gala<[e-mail]>
>>> Cc: Randy Dunlap<[e-mail]>
>>> Cc: Tomasz Figa<[e-mail]>
>>> ---
>>>   .../devicetree/bindings/clock/exynos3250-clock.txt | 41
>>> ++++++++++++++++++++++
>>>   1 file changed, 41 insertions(+)
>>>   create mode 100644
>>> Documentation/devicetree/bindings/clock/exynos3250-clock.txt
>>>
>>> diff --git
>>> a/Documentation/devicetree/bindings/clock/exynos3250-clock.txt
>>> b/Documentation/devicetree/bindings/clock/exynos3250-clock.txt
>>> new file mode 100644
>>> index 0000000..aadc9c5
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/clock/exynos3250-clock.txt
>>> @@ -0,0 +1,41 @@
>>> +* Samsung Exynos3250 Clock Controller
>>> +
>>> +The Exynos3250 clock controller generates and supplies clock to various
>>> +controllers within the Exynos3250 SoC.
>>> +
>>> +Required Properties:
>>> +
>>> +- compatible: should be one of the following.
>>> +  - "samsung,exynos3250-cmu" - controller compatible with Exynos3250
>>> SoC.
>>> +
>>> +- reg: physical base address of the controller and length of memory
>>> mapped
>>> +  region.
>>> +
>>> +- #clock-cells: should be 1.
>>> +
>>> +Each clock is assigned an identifier and client nodes can use this
>>> identifier
>>> +to specify the clock which they consume.
>>> +
>>> +All available clocks are defined as preprocessor macros in
>>> +dt-bindings/clock/exynos3250.h header and can be used in device
>>> +tree sources.
>>> +
>>> +Example 1: An example of a clock controller node is listed below.
>>> +
>>> +    cmu: clock-controller@10030000 {
>>> +        compatible = "samsung,exynos3250-cmu";
>>> +        reg =<0x10030000 0x20000>;
>>> +        #clock-cells =<1>;
>>> +    };
>>> +
>>> +Example 2: UART controller node that consumes the clock generated by
>>> the clock
>>> +       controller. Refer to the standard clock bindings for information
>>> +       about 'clocks' and 'clock-names' property.
>>> +
>>> +    serial@13800000 {
>>> +        compatible = "samsung,exynos4210-uart";
>>> +        reg =<0x13800000 0x100>;
>>> +        interrupts =<0 109 0>;
>>> +        clocks =<&cmu CLK_UART0>,<&cmu CLK_SCLK_UART0>;
>>> +        clock-names = "uart", "clk_uart_baud0";
>>> +    };
>>>
>>
>> Oops, I've forgotten to apply this one. Since it doesn't have any
>> dependencies, Kukjin, could you apply it on top of my pull requests with
>> my Ack? Thanks in advance.
>>
>> Acked-by: Tomasz Figa<[e-mail]>
>>
> Sure, I will do it on your 4/4 pull-request after pulling it into
> samsung tree.

Thanks!

Best regards,
Tomasz

Patch

diff --git a/Documentation/devicetree/bindings/clock/exynos3250-clock.txt b/Documentation/devicetree/bindings/clock/exynos3250-clock.txt
new file mode 100644
index 0000000..aadc9c5
--- /dev/null
+++ b/Documentation/devicetree/bindings/clock/exynos3250-clock.txt
@@ -0,0 +1,41 @@ 
+* Samsung Exynos3250 Clock Controller
+
+The Exynos3250 clock controller generates and supplies clock to various
+controllers within the Exynos3250 SoC.
+
+Required Properties:
+
+- compatible: should be one of the following.
+  - "samsung,exynos3250-cmu" - controller compatible with Exynos3250 SoC.
+
+- reg: physical base address of the controller and length of memory mapped
+  region.
+
+- #clock-cells: should be 1.
+
+Each clock is assigned an identifier and client nodes can use this identifier
+to specify the clock which they consume.
+
+All available clocks are defined as preprocessor macros in
+dt-bindings/clock/exynos3250.h header and can be used in device
+tree sources.
+
+Example 1: An example of a clock controller node is listed below.
+
+	cmu: clock-controller@10030000 {
+		compatible = "samsung,exynos3250-cmu";
+		reg = <0x10030000 0x20000>;
+		#clock-cells = <1>;
+	};
+
+Example 2: UART controller node that consumes the clock generated by the clock
+	   controller. Refer to the standard clock bindings for information
+	   about 'clocks' and 'clock-names' property.
+
+	serial@13800000 {
+		compatible = "samsung,exynos4210-uart";
+		reg = <0x13800000 0x100>;
+		interrupts = <0 109 0>;
+		clocks = <&cmu CLK_UART0>, <&cmu CLK_SCLK_UART0>;
+		clock-names = "uart", "clk_uart_baud0";
+	};