| Message ID | 1399681883-891-3-git-send-email-linux@roeck-us.net (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 05/09/2014 05:31 PM, Guenter Roeck wrote: > The watchdog subsystem provides an API to perform a system reboot. > Use it. > > Signed-off-by: Guenter Roeck <linux@roeck-us.net> Any comments / Ack from the arm maintainers ? Thanks, Guenter > --- > v2: No change > > arch/arm64/kernel/process.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/arch/arm64/kernel/process.c b/arch/arm64/kernel/process.c > index 6391485..29c2bc0 100644 > --- a/arch/arm64/kernel/process.c > +++ b/arch/arm64/kernel/process.c > @@ -42,6 +42,7 @@ > #include <linux/hw_breakpoint.h> > #include <linux/personality.h> > #include <linux/notifier.h> > +#include <linux/watchdog.h> > > #include <asm/compat.h> > #include <asm/cacheflush.h> > @@ -144,6 +145,8 @@ void machine_restart(char *cmd) > if (arm_pm_restart) > arm_pm_restart(reboot_mode, cmd); > > + watchdog_do_reboot(reboot_mode, cmd); > + > /* > * Whoops - the architecture was unable to reboot. > */ >
On Thu, May 15, 2014 at 02:37:30AM +0100, Guenter Roeck wrote: > On 05/09/2014 05:31 PM, Guenter Roeck wrote: > > The watchdog subsystem provides an API to perform a system reboot. > > Use it. > > > > Signed-off-by: Guenter Roeck <linux@roeck-us.net> > > Any comments / Ack from the arm maintainers ? I'm fine with the arm/arm64 changes, but I still reckon the parameters should be dropped unless you have a use for them. Will
On Thu, May 15, 2014 at 10:09:52AM +0100, Will Deacon wrote: > On Thu, May 15, 2014 at 02:37:30AM +0100, Guenter Roeck wrote: > > On 05/09/2014 05:31 PM, Guenter Roeck wrote: > > > The watchdog subsystem provides an API to perform a system reboot. > > > Use it. > > > > > > Signed-off-by: Guenter Roeck <linux@roeck-us.net> > > > > Any comments / Ack from the arm maintainers ? > > I'm fine with the arm/arm64 changes, but I still reckon the parameters > should be dropped unless you have a use for them. Ok, I'll drop the parameters and send a new version. Guenter
diff --git a/arch/arm64/kernel/process.c b/arch/arm64/kernel/process.c index 6391485..29c2bc0 100644 --- a/arch/arm64/kernel/process.c +++ b/arch/arm64/kernel/process.c @@ -42,6 +42,7 @@ #include <linux/hw_breakpoint.h> #include <linux/personality.h> #include <linux/notifier.h> +#include <linux/watchdog.h> #include <asm/compat.h> #include <asm/cacheflush.h> @@ -144,6 +145,8 @@ void machine_restart(char *cmd) if (arm_pm_restart) arm_pm_restart(reboot_mode, cmd); + watchdog_do_reboot(reboot_mode, cmd); + /* * Whoops - the architecture was unable to reboot. */
The watchdog subsystem provides an API to perform a system reboot. Use it. Signed-off-by: Guenter Roeck <linux@roeck-us.net> --- v2: No change arch/arm64/kernel/process.c | 3 +++ 1 file changed, 3 insertions(+)