| Message ID | 1398759542-13017-1-git-send-email-srinivas.kandagatla@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tue, Apr 29, 2014 at 10:19 AM, <srinivas.kandagatla@linaro.org> wrote: > From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> > > This patch adds Qualcomm amba vendor Id to the list. This ID is used in mmci > driver. > > Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> (...) > + AMBA_VENDOR_QCOM = 0x51, Yeah it's a "Q", like 0x41 is "A" for ARM. You could as well mention this in the commit message. And you can probably just put this patch into Russell's patch tracker already. Acked-by: Linus Walleij <linus.walleij@linaro.org> Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Thanks Linus W, On 13/05/14 08:16, Linus Walleij wrote: > On Tue, Apr 29, 2014 at 10:19 AM, <srinivas.kandagatla@linaro.org> wrote: > >> From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> >> >> This patch adds Qualcomm amba vendor Id to the list. This ID is used in mmci >> driver. >> >> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> > (...) >> + AMBA_VENDOR_QCOM = 0x51, > > Yeah it's a "Q", like 0x41 is "A" for ARM. You could as well mention > this in the commit message. > Sounds good, I will fix it in next version and send it to Russell's patch tracker. --srini > And you can probably just put this patch into Russell's patch tracker > already. > > Acked-by: Linus Walleij <linus.walleij@linaro.org> > > Yours, > Linus Walleij > -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 05/13, Srinivas Kandagatla wrote: > Thanks Linus W, > > On 13/05/14 08:16, Linus Walleij wrote: > >On Tue, Apr 29, 2014 at 10:19 AM, <srinivas.kandagatla@linaro.org> wrote: > > > >>From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> > >> > >>This patch adds Qualcomm amba vendor Id to the list. This ID is used in mmci > >>driver. > >> > >>Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> > >(...) > >>+ AMBA_VENDOR_QCOM = 0x51, > > > >Yeah it's a "Q", like 0x41 is "A" for ARM. You could as well mention > >this in the commit message. > > > Sounds good, I will fix it in next version and send it to Russell's > patch tracker. > Please add a note that this id is fake in the commit text or in the code as well.
On 13/05/14 23:13, Stephen Boyd wrote: > On 05/13, Srinivas Kandagatla wrote: >> Thanks Linus W, >> >> On 13/05/14 08:16, Linus Walleij wrote: >>> On Tue, Apr 29, 2014 at 10:19 AM, <srinivas.kandagatla@linaro.org> wrote: >>> >>>> From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> >>>> >>>> This patch adds Qualcomm amba vendor Id to the list. This ID is used in mmci >>>> driver. >>>> >>>> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> >>> (...) >>>> + AMBA_VENDOR_QCOM = 0x51, >>> >>> Yeah it's a "Q", like 0x41 is "A" for ARM. You could as well mention >>> this in the commit message. >>> >> Sounds good, I will fix it in next version and send it to Russell's >> patch tracker. >> > > Please add a note that this id is fake in the commit text or in > the code as well. Sure, I will add it in commit text. > -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, May 14, 2014 at 12:13 AM, Stephen Boyd <sboyd@codeaurora.org> wrote: > Please add a note that this id is fake in the commit text or in > the code as well. You just need one of your hardware engineers to add is to one instance of some test chip round so it exists in any hardware whatsoever and it is not "fake" anymore... This is a bit like device tree, it's defined by the kernel community as much as by the hardware engineers and it's a little bit of back-and-forth. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 05/16/14 09:24, Linus Walleij wrote: > On Wed, May 14, 2014 at 12:13 AM, Stephen Boyd <sboyd@codeaurora.org> wrote: > >> Please add a note that this id is fake in the commit text or in >> the code as well. > You just need one of your hardware engineers to add is to one instance > of some test chip round so it exists in any hardware whatsoever and it > is not "fake" anymore... > > This is a bit like device tree, it's defined by the kernel community as much > as by the hardware engineers and it's a little bit of back-and-forth. > Sure, but hardware teams have moved on from this IP so I doubt we can even get them to put it into a test chip. In fact, the devices a generation before the ones Srini is working on (msm8660 for example) have a periph ID of 0x41180 so we need to override that ID in DT with this fake ID for things to even work.
On Fri, May 16, 2014 at 6:43 PM, Stephen Boyd <sboyd@codeaurora.org> wrote: > On 05/16/14 09:24, Linus Walleij wrote: >> On Wed, May 14, 2014 at 12:13 AM, Stephen Boyd <sboyd@codeaurora.org> wrote: >> >>> Please add a note that this id is fake in the commit text or in >>> the code as well. >> You just need one of your hardware engineers to add is to one instance >> of some test chip round so it exists in any hardware whatsoever and it >> is not "fake" anymore... >> >> This is a bit like device tree, it's defined by the kernel community as much >> as by the hardware engineers and it's a little bit of back-and-forth. >> > > Sure, but hardware teams have moved on from this IP so I doubt we can > even get them to put it into a test chip. In fact, the devices a > generation before the ones Srini is working on (msm8660 for example) > have a periph ID of 0x41180 so we need to override that ID in DT with > this fake ID for things to even work. Hehe I wasn't really suggesting doing that. The point was to illustrate how fragile the border between "real" and "fake" is in these cases. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/include/linux/amba/bus.h b/include/linux/amba/bus.h index 63b5eff..fdd7e1b 100644 --- a/include/linux/amba/bus.h +++ b/include/linux/amba/bus.h @@ -47,6 +47,7 @@ struct amba_driver { enum amba_vendor { AMBA_VENDOR_ARM = 0x41, AMBA_VENDOR_ST = 0x80, + AMBA_VENDOR_QCOM = 0x51, }; extern struct bus_type amba_bustype;