| Message ID | 20140318004213.812935479@telegraphics.com.au (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tue, Mar 18, 2014 at 11:42:16AM +1100, Finn Thain wrote: > Only the NCR5380_dprint() macro should invoke the NCR5380_print() function. > That's why NCR5380.c only defines the function #if NDEBUG. Use the standard > macro. > > Signed-off-by: Finn Thain <fthain@telegraphics.com.au> Looks good, Reviewed-by: Christoph Hellwig <hch@lst.de>
Index: linux-m68k/drivers/scsi/sun3_scsi.c =================================================================== --- linux-m68k.orig/drivers/scsi/sun3_scsi.c 2014-03-18 00:18:32.000000000 +1100 +++ linux-m68k/drivers/scsi/sun3_scsi.c 2014-03-18 00:18:33.000000000 +1100 @@ -79,8 +79,6 @@ #include <scsi/scsi_host.h> #include "sun3_scsi.h" -static void NCR5380_print(struct Scsi_Host *instance); - /* #define OLDDMA */ #define USE_WRAPPER @@ -463,7 +461,7 @@ static unsigned long sun3scsi_dma_setup( printk("scsi%d: fifo_mismatch %04x not %04x\n", default_instance->host_no, dregs->fifo_count, (unsigned int) count); - NCR5380_print(default_instance); + NCR5380_dprint(NDEBUG_DMA, default_instance); } /* setup udc */
Only the NCR5380_dprint() macro should invoke the NCR5380_print() function. That's why NCR5380.c only defines the function #if NDEBUG. Use the standard macro. Signed-off-by: Finn Thain <fthain@telegraphics.com.au> --- drivers/scsi/sun3_scsi.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)