| Message ID | 1401345500-20188-17-git-send-email-kishon@ti.com (mailing list archive) |
|---|---|
| State | New, archived |
| Delegated to: | Bjorn Helgaas |
| Headers | show |
On Thursday, May 29, 2014 3:38 PM, Kishon Vijay Abraham I wrote: > > Now that we have added PCIe driver for DRA7 SOCs, enable PCI on > DRA7 SOCs. > > Cc: Tony Lindgren <tony@atomide.com> > Cc: Rob Herring <robh+dt@kernel.org> > Cc: Pawel Moll <pawel.moll@arm.com> > Cc: Mark Rutland <mark.rutland@arm.com> > Cc: Kumar Gala <galak@codeaurora.org> > Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com> > --- > arch/arm/mach-omap2/Kconfig | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/arm/mach-omap2/Kconfig b/arch/arm/mach-omap2/Kconfig > index cb31d43..b179e80 100644 > --- a/arch/arm/mach-omap2/Kconfig > +++ b/arch/arm/mach-omap2/Kconfig > @@ -75,6 +75,8 @@ config SOC_DRA7XX > select ARM_GIC > select HAVE_ARM_ARCH_TIMER > select IRQ_CROSSBAR > + select MIGHT_HAVE_PCI > + select ARCH_SUPPORTS_MSI Hi Kishon, Please, don't select ARCH_SUPPORTS_MSI, because this kconfig option was already removed in v3.12 by the commit ebd97be635 ('PCI: remove ARCH_SUPPORTS_MSI kconfig option'). So, there is NO need to select 'ARCH_SUPPORTS_MSI'. Best regards, Jingoo Han > > config ARCH_OMAP2PLUS > bool > -- > 1.7.9.5 -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi, On Thursday 29 May 2014 12:18 PM, Jingoo Han wrote: > On Thursday, May 29, 2014 3:38 PM, Kishon Vijay Abraham I wrote: >> >> Now that we have added PCIe driver for DRA7 SOCs, enable PCI on >> DRA7 SOCs. >> >> Cc: Tony Lindgren <tony@atomide.com> >> Cc: Rob Herring <robh+dt@kernel.org> >> Cc: Pawel Moll <pawel.moll@arm.com> >> Cc: Mark Rutland <mark.rutland@arm.com> >> Cc: Kumar Gala <galak@codeaurora.org> >> Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com> >> --- >> arch/arm/mach-omap2/Kconfig | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/arch/arm/mach-omap2/Kconfig b/arch/arm/mach-omap2/Kconfig >> index cb31d43..b179e80 100644 >> --- a/arch/arm/mach-omap2/Kconfig >> +++ b/arch/arm/mach-omap2/Kconfig >> @@ -75,6 +75,8 @@ config SOC_DRA7XX >> select ARM_GIC >> select HAVE_ARM_ARCH_TIMER >> select IRQ_CROSSBAR >> + select MIGHT_HAVE_PCI >> + select ARCH_SUPPORTS_MSI > > Hi Kishon, > > Please, don't select ARCH_SUPPORTS_MSI, because this kconfig > option was already removed in v3.12 by the commit ebd97be635 > ('PCI: remove ARCH_SUPPORTS_MSI kconfig option'). So, there is > NO need to select 'ARCH_SUPPORTS_MSI'. Thanks for spotting it. Will remove it. Thanks Kishon -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, May 29, 2014 at 1:38 AM, Kishon Vijay Abraham I <kishon@ti.com> wrote: > Now that we have added PCIe driver for DRA7 SOCs, enable PCI on > DRA7 SOCs. > > Cc: Tony Lindgren <tony@atomide.com> > Cc: Rob Herring <robh+dt@kernel.org> > Cc: Pawel Moll <pawel.moll@arm.com> > Cc: Mark Rutland <mark.rutland@arm.com> > Cc: Kumar Gala <galak@codeaurora.org> > Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com> > --- > arch/arm/mach-omap2/Kconfig | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/arm/mach-omap2/Kconfig b/arch/arm/mach-omap2/Kconfig > index cb31d43..b179e80 100644 > --- a/arch/arm/mach-omap2/Kconfig > +++ b/arch/arm/mach-omap2/Kconfig > @@ -75,6 +75,8 @@ config SOC_DRA7XX > select ARM_GIC > select HAVE_ARM_ARCH_TIMER > select IRQ_CROSSBAR > + select MIGHT_HAVE_PCI I believe we moved or intend to move this under MULTI_PLATFORM, so you don't need this. Will D. had a patch, but I don't think I saw a final version to merge. Rob > + select ARCH_SUPPORTS_MSI > > config ARCH_OMAP2PLUS > bool > -- > 1.7.9.5 > -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, May 29, 2014 at 06:52:14PM +0100, Rob Herring wrote: > On Thu, May 29, 2014 at 1:38 AM, Kishon Vijay Abraham I <kishon@ti.com> wrote: > > Now that we have added PCIe driver for DRA7 SOCs, enable PCI on > > DRA7 SOCs. > > > > Cc: Tony Lindgren <tony@atomide.com> > > Cc: Rob Herring <robh+dt@kernel.org> > > Cc: Pawel Moll <pawel.moll@arm.com> > > Cc: Mark Rutland <mark.rutland@arm.com> > > Cc: Kumar Gala <galak@codeaurora.org> > > Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com> > > --- > > arch/arm/mach-omap2/Kconfig | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/arch/arm/mach-omap2/Kconfig b/arch/arm/mach-omap2/Kconfig > > index cb31d43..b179e80 100644 > > --- a/arch/arm/mach-omap2/Kconfig > > +++ b/arch/arm/mach-omap2/Kconfig > > @@ -75,6 +75,8 @@ config SOC_DRA7XX > > select ARM_GIC > > select HAVE_ARM_ARCH_TIMER > > select IRQ_CROSSBAR > > + select MIGHT_HAVE_PCI > > I believe we moved or intend to move this under MULTI_PLATFORM, so you > don't need this. Will D. had a patch, but I don't think I saw a final > version to merge. I posted it earlier this week for somebody in arm-soc to pick up (although I don't think they have done yet): http://lists.infradead.org/pipermail/linux-arm-kernel/2014-May/260238.html Will -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm/mach-omap2/Kconfig b/arch/arm/mach-omap2/Kconfig index cb31d43..b179e80 100644 --- a/arch/arm/mach-omap2/Kconfig +++ b/arch/arm/mach-omap2/Kconfig @@ -75,6 +75,8 @@ config SOC_DRA7XX select ARM_GIC select HAVE_ARM_ARCH_TIMER select IRQ_CROSSBAR + select MIGHT_HAVE_PCI + select ARCH_SUPPORTS_MSI config ARCH_OMAP2PLUS bool
Now that we have added PCIe driver for DRA7 SOCs, enable PCI on DRA7 SOCs. Cc: Tony Lindgren <tony@atomide.com> Cc: Rob Herring <robh+dt@kernel.org> Cc: Pawel Moll <pawel.moll@arm.com> Cc: Mark Rutland <mark.rutland@arm.com> Cc: Kumar Gala <galak@codeaurora.org> Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com> --- arch/arm/mach-omap2/Kconfig | 2 ++ 1 file changed, 2 insertions(+)