diff mbox

[00/12] dvbv5 scan tables for Brazil

Message ID 20140530002345.GA12450@lambda.dereenigne.org (mailing list archive)
State New, archived
Headers show

Commit Message

Jonathan McCrohan May 30, 2014, 12:23 a.m. UTC
Hi Mauro,

On Tue, 27 May 2014 13:50:20 -0300, Mauro Carvalho Chehab wrote:
> This patch series add the DTV scan tables for Brazilian ISDB-T
> and for the Brazilian Countys that have already digital TV.

Thanks for the DVBv5 scan files. I had the attached draft patch sitting
in my tree. I don't think it is ready to be committed yet, but probably
worth sending now to discuss.

How do we want to manage the migration from DVBv3 to DVBv5:
1) point in time migration from DVBv3 to DVBv5?
2) maintain both until DVBv5 is in widespread use?

On a side note, I found a bug in dvb-format-convert; it cannot parse
DVB-T2 DVBv3 scan files.

Jon

Comments

Mauro Carvalho Chehab May 30, 2014, 12:37 a.m. UTC | #1
Hi Jonathan,

Em Fri, 30 May 2014 01:23:45 +0100
Jonathan McCrohan <jmccrohan@gmail.com> escreveu:

> Hi Mauro,
> 
> On Tue, 27 May 2014 13:50:20 -0300, Mauro Carvalho Chehab wrote:
> > This patch series add the DTV scan tables for Brazilian ISDB-T
> > and for the Brazilian Countys that have already digital TV.
> 
> Thanks for the DVBv5 scan files. I had the attached draft patch sitting
> in my tree. I don't think it is ready to be committed yet, but probably
> worth sending now to discuss.

Sure.

> How do we want to manage the migration from DVBv3 to DVBv5:
> 1) point in time migration from DVBv3 to DVBv5?
> 2) maintain both until DVBv5 is in widespread use?

IMHO, the best strategy would be to convert all files at the tree to
DVBv5, and add a Makefile target to produce the DVBv3 files and
another one to install the DVBv5 files on a shared repository.

That gives to distro maintainers the flexibility to have either one 
or two packages for each format, and let them to remove the dvbv3
when all apps on an specific distro would be using just the new format.

> On a side note, I found a bug in dvb-format-convert; it cannot parse
> DVB-T2 DVBv3 scan files.

Well, at the time it was written, there were no DVB-T2 files.

Feel free to send patches improving the library to also handle the
DVB-T2 formats.

Regards,
Mauro
diff mbox

Patch

From fdcabb0802a4a40e257d54dbd5e5eba59b9820f7 Mon Sep 17 00:00:00 2001
From: Jonathan McCrohan <jmccrohan@gmail.com>
Date: Fri, 30 May 2014 01:14:42 +0100
Subject: [PATCH] Add Makefile to convert DVBv3 files to DVBv5

Signed-off-by: Jonathan McCrohan <jmccrohan@gmail.com>
---
 Makefile | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)
 create mode 100644 Makefile

diff --git a/Makefile b/Makefile
new file mode 100644
index 0000000..fac40e7
--- /dev/null
+++ b/Makefile
@@ -0,0 +1,25 @@ 
+# Makefile for dtv-scan-tables (26 May 2014)
+# Copyright 2014 Jonathan McCrohan <jmccrohan@gmail.com>
+
+# The vast majority of the DVB scan files contained in this repository
+# are DVBv3 scan files. This format has been deprecated in favor of the
+# DVBv5 scan format.
+#
+# Use this makefile to convert the existing DVBv3 scan files to DVBv5
+# scan files until such time as DVBv5 scan format is in widespread use.
+#
+# Requires dvb-format-convert from v4l-utils.
+
+MKDIR = mkdir -p
+DVBFORMATCONVERT = dvb-format-convert
+
+DVBFORMATCONVERT_CHANNEL_DVBV5 = -ICHANNEL -ODVBV5
+
+DVBV3DIRS = atsc dvb-c dvb-s dvb-t
+DVBV3CHANNELFILES = $(foreach dir,$(DVBV3DIRS),$(wildcard $(dir)/*))
+
+DVBV5OUTPUTDIR = dvbv5
+
+makedvbv5:
+	@$(foreach var,$(DVBV3DIRS), $(MKDIR) $(DVBV5OUTPUTDIR)/$(var);)
+	@$(foreach var,$(DVBV3CHANNELFILES), $(DVBFORMATCONVERT) $(DVBFORMATCONVERT_CHANNEL_DVBV5) $(var) $(DVBV5OUTPUTDIR)/$(var);)
-- 
2.0.0.rc2