| Message ID | 1401255351-17653-4-git-send-email-jh80.chung@samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 28 May 2014 07:35, Jaehoon Chung <jh80.chung@samsung.com> wrote: > Removed the parser for "supports-highspeed". > It can be parsed with "cap-mmc-highsped" or "cap-sd-highspeed" at > mmc_of_parse(). > > Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com> > --- > drivers/mmc/host/dw_mmc.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c > index 3285bdd..34b5210 100644 > --- a/drivers/mmc/host/dw_mmc.c > +++ b/drivers/mmc/host/dw_mmc.c > @@ -2281,9 +2281,6 @@ static struct dw_mci_board *dw_mci_parse_dt(struct dw_mci *host) > return ERR_PTR(ret); > } > > - if (of_find_property(np, "supports-highspeed", NULL)) > - pdata->caps |= MMC_CAP_SD_HIGHSPEED | MMC_CAP_MMC_HIGHSPEED; > - According to DT guys, normally we shouldn't remove DT bindings. Thus, you need to keep this, unless you can get some of the DT guys to ack it. Though, you still want to move the DTs to use common mmc bindings. And you could mark the documentation of the above binding as deprecated. Kind regards Ulf Hansson -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi, Ulf. On 05/30/2014 05:01 PM, Ulf Hansson wrote: > On 28 May 2014 07:35, Jaehoon Chung <jh80.chung@samsung.com> wrote: >> Removed the parser for "supports-highspeed". >> It can be parsed with "cap-mmc-highsped" or "cap-sd-highspeed" at >> mmc_of_parse(). >> >> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com> >> --- >> drivers/mmc/host/dw_mmc.c | 3 --- >> 1 file changed, 3 deletions(-) >> >> diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c >> index 3285bdd..34b5210 100644 >> --- a/drivers/mmc/host/dw_mmc.c >> +++ b/drivers/mmc/host/dw_mmc.c >> @@ -2281,9 +2281,6 @@ static struct dw_mci_board *dw_mci_parse_dt(struct dw_mci *host) >> return ERR_PTR(ret); >> } >> >> - if (of_find_property(np, "supports-highspeed", NULL)) >> - pdata->caps |= MMC_CAP_SD_HIGHSPEED | MMC_CAP_MMC_HIGHSPEED; >> - > > According to DT guys, normally we shouldn't remove DT bindings. Thus, > you need to keep this, unless you can get some of the DT guys to ack > it. As you mentioned, this patch didn't need, right? > > Though, you still want to move the DTs to use common mmc bindings. And > you could mark the documentation of the above binding as deprecated. I added the comment for deprecated into dw-mmc dt-binding doc file. "[PATCHv3,4/4] ARM: dts: replace the slot property into slot sub-node for dwmmc." I think this patch can be discarded. then everything is ok.!? :) If i'm wrong, let me know, plz. Thank you for sharing the information. Best Regards, Jaehoon Chung > > Kind regards > Ulf Hansson > -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, May 30, 2014, Jaehoon Chung wrote: > Hi, Ulf. > > On 05/30/2014 05:01 PM, Ulf Hansson wrote: > > On 28 May 2014 07:35, Jaehoon Chung <jh80.chung@samsung.com> wrote: > >> Removed the parser for "supports-highspeed". > >> It can be parsed with "cap-mmc-highsped" or "cap-sd-highspeed" at > >> mmc_of_parse(). > >> > >> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com> > >> --- > >> drivers/mmc/host/dw_mmc.c | 3 --- > >> 1 file changed, 3 deletions(-) > >> > >> diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c > >> index 3285bdd..34b5210 100644 > >> --- a/drivers/mmc/host/dw_mmc.c > >> +++ b/drivers/mmc/host/dw_mmc.c > >> @@ -2281,9 +2281,6 @@ static struct dw_mci_board *dw_mci_parse_dt(struct dw_mci *host) > >> return ERR_PTR(ret); > >> } > >> > >> - if (of_find_property(np, "supports-highspeed", NULL)) > >> - pdata->caps |= MMC_CAP_SD_HIGHSPEED | MMC_CAP_MMC_HIGHSPEED; > >> - > > > > According to DT guys, normally we shouldn't remove DT bindings. Thus, > > you need to keep this, unless you can get some of the DT guys to ack > > it. > As you mentioned, this patch didn't need, right? > > > > > Though, you still want to move the DTs to use common mmc bindings. And > > you could mark the documentation of the above binding as deprecated. > I added the comment for deprecated into dw-mmc dt-binding doc file. > "[PATCHv3,4/4] ARM: dts: replace the slot property into slot sub-node for dwmmc." > > I think this patch can be discarded. then everything is ok.!? :) Once decided to turn common mmc bindings instead of driver-specific, host driver shall not need old one. I think we can remove it. Thanks, Seungwon Jeon > > If i'm wrong, let me know, plz. > > Thank you for sharing the information. > > Best Regards, > Jaehoon Chung > > > > Kind regards > > Ulf Hansson > > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-mmc" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, May 28, 2014, Jaehoon Chung wrote: > Removed the parser for "supports-highspeed". > It can be parsed with "cap-mmc-highsped" or "cap-sd-highspeed" at > mmc_of_parse(). > > Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com> Acked-by: Seungwon Jeon <tgih.jun@samsung.com> Tahnks, Seungwon Jeon > --- > drivers/mmc/host/dw_mmc.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c > index 3285bdd..34b5210 100644 > --- a/drivers/mmc/host/dw_mmc.c > +++ b/drivers/mmc/host/dw_mmc.c > @@ -2281,9 +2281,6 @@ static struct dw_mci_board *dw_mci_parse_dt(struct dw_mci *host) > return ERR_PTR(ret); > } > > - if (of_find_property(np, "supports-highspeed", NULL)) > - pdata->caps |= MMC_CAP_SD_HIGHSPEED | MMC_CAP_MMC_HIGHSPEED; > - > return pdata; > } > > -- > 1.7.9.5 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-mmc" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, May 30, 2014 at 09:01:16AM +0100, Ulf Hansson wrote: > On 28 May 2014 07:35, Jaehoon Chung <jh80.chung@samsung.com> wrote: > > Removed the parser for "supports-highspeed". > > It can be parsed with "cap-mmc-highsped" or "cap-sd-highspeed" at > > mmc_of_parse(). > > > > Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com> > > --- > > drivers/mmc/host/dw_mmc.c | 3 --- > > 1 file changed, 3 deletions(-) > > > > diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c > > index 3285bdd..34b5210 100644 > > --- a/drivers/mmc/host/dw_mmc.c > > +++ b/drivers/mmc/host/dw_mmc.c > > @@ -2281,9 +2281,6 @@ static struct dw_mci_board *dw_mci_parse_dt(struct dw_mci *host) > > return ERR_PTR(ret); > > } > > > > - if (of_find_property(np, "supports-highspeed", NULL)) > > - pdata->caps |= MMC_CAP_SD_HIGHSPEED | MMC_CAP_MMC_HIGHSPEED; > > - > > According to DT guys, normally we shouldn't remove DT bindings. Thus, > you need to keep this, unless you can get some of the DT guys to ack > it. In general, yes. Unless there's a compelling reason to drop a binding, and all users are happy with it being dropped, then there's not much point in removing it. It's usually not possible to get agreement because it's usually nto possible to know the full set of users, so in general we can't drop or change stuff. > Though, you still want to move the DTs to use common mmc bindings. And > you could mark the documentation of the above binding as deprecated. Deprecated bindings can be supported even if discouraged. As far as I can see, keeping the existing binding along side the new one looks relatively simple in this case. Thanks, Mark. -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c index 3285bdd..34b5210 100644 --- a/drivers/mmc/host/dw_mmc.c +++ b/drivers/mmc/host/dw_mmc.c @@ -2281,9 +2281,6 @@ static struct dw_mci_board *dw_mci_parse_dt(struct dw_mci *host) return ERR_PTR(ret); } - if (of_find_property(np, "supports-highspeed", NULL)) - pdata->caps |= MMC_CAP_SD_HIGHSPEED | MMC_CAP_MMC_HIGHSPEED; - return pdata; }
Removed the parser for "supports-highspeed". It can be parsed with "cap-mmc-highsped" or "cap-sd-highspeed" at mmc_of_parse(). Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com> --- drivers/mmc/host/dw_mmc.c | 3 --- 1 file changed, 3 deletions(-)