diff mbox

deb-pkg: Apply $(CROSS_COMPILE) when calling objcopy

Message ID 1401691657-12222-1-git-send-email-ijc@hellion.org.uk (mailing list archive)
State New, archived
Headers show

Commit Message

Ian Campbell June 2, 2014, 6:47 a.m. UTC
Allows me to cross build an armhf package from amd64.

Signed-off-by: Ian Campbell <ijc@hellion.org.uk>
---
 scripts/package/builddeb | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

maximilian attems June 2, 2014, 7:32 a.m. UTC | #1
On Mon, Jun 02, 2014 at 07:47:37AM +0100, Ian Campbell wrote:
> Allows me to cross build an armhf package from amd64.
> 
> Signed-off-by: Ian Campbell <ijc@hellion.org.uk>
Acked-by: maximilian attems <max@stro.at>
> ---
>  scripts/package/builddeb | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/scripts/package/builddeb b/scripts/package/builddeb
> index f46e4dd..c22ab79 100644
> --- a/scripts/package/builddeb
> +++ b/scripts/package/builddeb
> @@ -155,11 +155,11 @@ if grep -q '^CONFIG_MODULES=y' $KCONFIG_CONFIG ; then
>  			for module in $(find lib/modules/ -name *.ko); do
>  				mkdir -p $(dirname $dbg_dir/usr/lib/debug/$module)
>  				# only keep debug symbols in the debug file
> -				objcopy --only-keep-debug $module $dbg_dir/usr/lib/debug/$module
> +				${CROSS_COMPILE}objcopy --only-keep-debug $module $dbg_dir/usr/lib/debug/$module
>  				# strip original module from debug symbols
> -				objcopy --strip-debug $module
> +				${CROSS_COMPILE}objcopy --strip-debug $module
>  				# then add a link to those
> -				objcopy --add-gnu-debuglink=$dbg_dir/usr/lib/debug/$module $module
> +				${CROSS_COMPILE}objcopy --add-gnu-debuglink=$dbg_dir/usr/lib/debug/$module $module
>  			done
>  		)
>  	fi
> -- 
> 1.9.0
> 
> 
> -- 
> To UNSUBSCRIBE, email to debian-kernel-REQUEST@lists.debian.org
> with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org
> Archive: https://lists.debian.org/1401691657-12222-1-git-send-email-ijc@hellion.org.uk
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Fathi Boudra June 2, 2014, 9:29 a.m. UTC | #2
On 2 June 2014 09:47, Ian Campbell <ijc@hellion.org.uk> wrote:
> Allows me to cross build an armhf package from amd64.
>
> Signed-off-by: Ian Campbell <ijc@hellion.org.uk>
> ---
>  scripts/package/builddeb | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/scripts/package/builddeb b/scripts/package/builddeb
> index f46e4dd..c22ab79 100644
> --- a/scripts/package/builddeb
> +++ b/scripts/package/builddeb
> @@ -155,11 +155,11 @@ if grep -q '^CONFIG_MODULES=y' $KCONFIG_CONFIG ; then
>                         for module in $(find lib/modules/ -name *.ko); do
>                                 mkdir -p $(dirname $dbg_dir/usr/lib/debug/$module)
>                                 # only keep debug symbols in the debug file
> -                               objcopy --only-keep-debug $module $dbg_dir/usr/lib/debug/$module
> +                               ${CROSS_COMPILE}objcopy --only-keep-debug $module $dbg_dir/usr/lib/debug/$module
>                                 # strip original module from debug symbols
> -                               objcopy --strip-debug $module
> +                               ${CROSS_COMPILE}objcopy --strip-debug $module
>                                 # then add a link to those
> -                               objcopy --add-gnu-debuglink=$dbg_dir/usr/lib/debug/$module $module
> +                               ${CROSS_COMPILE}objcopy --add-gnu-debuglink=$dbg_dir/usr/lib/debug/$module $module
>                         done
>                 )
>         fi
> --
> 1.9.0

I submitted it a month ago. It's already applied to kbuild.git#misc:
http://www.spinics.net/lists/linux-kbuild/msg09273.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Ian Campbell June 2, 2014, 9:39 a.m. UTC | #3
On Mon, 2014-06-02 at 12:29 +0300, Fathi Boudra wrote:
> I submitted it a month ago. It's already applied to kbuild.git#misc:
> http://www.spinics.net/lists/linux-kbuild/msg09273.html

I must have missed it, thanks!

Your version looks better (correctly uses $OBJCOPY)

Ian.


--
To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/scripts/package/builddeb b/scripts/package/builddeb
index f46e4dd..c22ab79 100644
--- a/scripts/package/builddeb
+++ b/scripts/package/builddeb
@@ -155,11 +155,11 @@  if grep -q '^CONFIG_MODULES=y' $KCONFIG_CONFIG ; then
 			for module in $(find lib/modules/ -name *.ko); do
 				mkdir -p $(dirname $dbg_dir/usr/lib/debug/$module)
 				# only keep debug symbols in the debug file
-				objcopy --only-keep-debug $module $dbg_dir/usr/lib/debug/$module
+				${CROSS_COMPILE}objcopy --only-keep-debug $module $dbg_dir/usr/lib/debug/$module
 				# strip original module from debug symbols
-				objcopy --strip-debug $module
+				${CROSS_COMPILE}objcopy --strip-debug $module
 				# then add a link to those
-				objcopy --add-gnu-debuglink=$dbg_dir/usr/lib/debug/$module $module
+				${CROSS_COMPILE}objcopy --add-gnu-debuglink=$dbg_dir/usr/lib/debug/$module $module
 			done
 		)
 	fi