| Message ID | 1401915726-29092-2-git-send-email-dros@primarydata.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Wed, Jun 04, 2014 at 05:01:49PM -0400, Weston Andros Adamson wrote: > Send RECLAIM_COMPLETE after CREATE_SESSION. This enables backend > communication to v4.1 linux nfsd servers (i/o through MDS only). If that's unconditionally adding a reclaim_complete after every create_sesion, that's probably not what we want since there are tests that want to do the reclaim_complete by hand. You probably want to use new_client_session() instead? See 219cf7b7f7d0 and the preceding commit. --b. > > Signed-off-by: Weston Andros Adamson <dros@primarydata.com> > --- > nfs4.1/nfs4client.py | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/nfs4.1/nfs4client.py b/nfs4.1/nfs4client.py > index e750728..0d94a42 100644 > --- a/nfs4.1/nfs4client.py > +++ b/nfs4.1/nfs4client.py > @@ -367,6 +367,7 @@ class ClientRecord(object): > self.seqid = inc_u32(csr.csr_sequence) # XXX Do we need to check this? > sess = SessionRecord(csr, self) > self.c.sessions[sess.sessionid] = sess > + sess.compound([op.reclaim_complete(FALSE)]) > return sess > > def _cb_hook(self, prefix, opname, funct): > -- > 1.8.5.2 (Apple Git-48) > -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Jun 4, 2014, at 10:26 PM, J. Bruce Fields <bfields@fieldses.org> wrote: > On Wed, Jun 04, 2014 at 05:01:49PM -0400, Weston Andros Adamson wrote: >> Send RECLAIM_COMPLETE after CREATE_SESSION. This enables backend >> communication to v4.1 linux nfsd servers (i/o through MDS only). > > If that's unconditionally adding a reclaim_complete after every > create_sesion, that's probably not what we want since there are tests > that want to do the reclaim_complete by hand. You probably want to use > new_client_session() instead? See 219cf7b7f7d0 and the preceding > commit. > > —b. Ok, thats a good point, but AFAIC new_client_session is never called - at least by nfs4server. I’ll figure out a better way to do this. -dros > >> >> Signed-off-by: Weston Andros Adamson <dros@primarydata.com> >> --- >> nfs4.1/nfs4client.py | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/nfs4.1/nfs4client.py b/nfs4.1/nfs4client.py >> index e750728..0d94a42 100644 >> --- a/nfs4.1/nfs4client.py >> +++ b/nfs4.1/nfs4client.py >> @@ -367,6 +367,7 @@ class ClientRecord(object): >> self.seqid = inc_u32(csr.csr_sequence) # XXX Do we need to check this? >> sess = SessionRecord(csr, self) >> self.c.sessions[sess.sessionid] = sess >> + sess.compound([op.reclaim_complete(FALSE)]) >> return sess >> >> def _cb_hook(self, prefix, opname, funct): >> -- >> 1.8.5.2 (Apple Git-48) >> -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/nfs4.1/nfs4client.py b/nfs4.1/nfs4client.py index e750728..0d94a42 100644 --- a/nfs4.1/nfs4client.py +++ b/nfs4.1/nfs4client.py @@ -367,6 +367,7 @@ class ClientRecord(object): self.seqid = inc_u32(csr.csr_sequence) # XXX Do we need to check this? sess = SessionRecord(csr, self) self.c.sessions[sess.sessionid] = sess + sess.compound([op.reclaim_complete(FALSE)]) return sess def _cb_hook(self, prefix, opname, funct):
Send RECLAIM_COMPLETE after CREATE_SESSION. This enables backend communication to v4.1 linux nfsd servers (i/o through MDS only). Signed-off-by: Weston Andros Adamson <dros@primarydata.com> --- nfs4.1/nfs4client.py | 1 + 1 file changed, 1 insertion(+)