diff mbox

[i-g-t,1/7] README: update piglit instructions

Message ID 1402410657-4768-1-git-send-email-thomas.wood@intel.com (mailing list archive)
State New, archived
Headers show

Commit Message

Thomas Wood June 10, 2014, 2:30 p.m. UTC
Piglit now has a top level "piglit" command and the location of the
tests can now be read from an environment variable.

Signed-off-by: Thomas Wood <thomas.wood@intel.com>
---
 README | 27 ++++++++++-----------------
 1 file changed, 10 insertions(+), 17 deletions(-)

Comments

Daniel Vetter June 10, 2014, 2:37 p.m. UTC | #1
On Tue, Jun 10, 2014 at 03:30:51PM +0100, Thomas Wood wrote:
> Piglit now has a top level "piglit" command and the location of the
> tests can now be read from an environment variable.
> 
> Signed-off-by: Thomas Wood <thomas.wood@intel.com>
> ---
>  README | 27 ++++++++++-----------------
>  1 file changed, 10 insertions(+), 17 deletions(-)
> 
> diff --git a/README b/README
> index 2cfb5c5..cfa186d 100644
> --- a/README
> +++ b/README
> @@ -34,32 +34,25 @@ tests/
>  
>  	git://anongit.freedesktop.org/piglit
>  
> -	and build it (no need to install anything). Then we need to link up the
> -	i-g-t sources with piglit
> +	There is no need to build and install piglit if it is only going to be
> +	used for running i-g-t tests.
> +
> +	Set the IGT_TEST_ROOT environment variable to point to the tests
> +	directory or link up the i-g-t sources with piglit using a symlink:
>  
>  	piglit-sources $ cd bin
>  	piglit-sources/bin $ ln $i-g-t-sources igt -s
>  
> -	To avoid some hassles with piglit's use of Waffle just disable it. Run
> -
> -	piglit-sources $ cmake -D PIGLIT_USE_WAFFLE=OFF .
> -
> -	With
> -
> -	piglit-sources $ ccmake .
> -
> -	you can check your configuration with a curses interface, too.

Hm, why did you drop this? I run into "lack of waffle" every time I try to
use piglit ... Otherwise looks good.
-Daniel

> -
> -	The tests in the i-g-t sources need to have been built already. Then we
> -	can run the testcases with (as usual as root, no other drm clients
> -	running):
> +	In both cases, the tests in the i-g-t sources need to have been built
> +	already. Then we can run the testcases with (as usual as root, no other
> +	drm clients running):
>  
> -	piglit-sources # ./piglit-run.py igt <results-file>
> +	piglit-sources # ./piglit run igt <results-file>
>  
>  	The testlist is built at runtime, so no need to update anything in
>  	piglit when adding new tests. See
>  
> -	piglit-sources $ ./piglit-run.py -h
> +	piglit-sources $ ./piglit run -h
>  
>  	for some useful options.
>  
> -- 
> 1.9.3
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Thomas Wood June 10, 2014, 3:06 p.m. UTC | #2
On 10 June 2014 15:37, Daniel Vetter <daniel@ffwll.ch> wrote:
> On Tue, Jun 10, 2014 at 03:30:51PM +0100, Thomas Wood wrote:
>> Piglit now has a top level "piglit" command and the location of the
>> tests can now be read from an environment variable.
>>
>> Signed-off-by: Thomas Wood <thomas.wood@intel.com>
>> ---
>>  README | 27 ++++++++++-----------------
>>  1 file changed, 10 insertions(+), 17 deletions(-)
>>
>> diff --git a/README b/README
>> index 2cfb5c5..cfa186d 100644
>> --- a/README
>> +++ b/README
>> @@ -34,32 +34,25 @@ tests/
>>
>>       git://anongit.freedesktop.org/piglit
>>
>> -     and build it (no need to install anything). Then we need to link up the
>> -     i-g-t sources with piglit
>> +     There is no need to build and install piglit if it is only going to be
>> +     used for running i-g-t tests.
>> +
>> +     Set the IGT_TEST_ROOT environment variable to point to the tests
>> +     directory or link up the i-g-t sources with piglit using a symlink:
>>
>>       piglit-sources $ cd bin
>>       piglit-sources/bin $ ln $i-g-t-sources igt -s
>>
>> -     To avoid some hassles with piglit's use of Waffle just disable it. Run
>> -
>> -     piglit-sources $ cmake -D PIGLIT_USE_WAFFLE=OFF .
>> -
>> -     With
>> -
>> -     piglit-sources $ ccmake .
>> -
>> -     you can check your configuration with a curses interface, too.
>
> Hm, why did you drop this? I run into "lack of waffle" every time I try to
> use piglit ... Otherwise looks good.

Since there's no need to actually build the Piglit test cases when
running intel-gpu-tools tests, there's no requirement for waffle
either.


> -Daniel
>
>> -
>> -     The tests in the i-g-t sources need to have been built already. Then we
>> -     can run the testcases with (as usual as root, no other drm clients
>> -     running):
>> +     In both cases, the tests in the i-g-t sources need to have been built
>> +     already. Then we can run the testcases with (as usual as root, no other
>> +     drm clients running):
>>
>> -     piglit-sources # ./piglit-run.py igt <results-file>
>> +     piglit-sources # ./piglit run igt <results-file>
>>
>>       The testlist is built at runtime, so no need to update anything in
>>       piglit when adding new tests. See
>>
>> -     piglit-sources $ ./piglit-run.py -h
>> +     piglit-sources $ ./piglit run -h
>>
>>       for some useful options.
>>
>> --
>> 1.9.3
>>
>> _______________________________________________
>> Intel-gfx mailing list
>> Intel-gfx@lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
>
> --
> Daniel Vetter
> Software Engineer, Intel Corporation
> +41 (0) 79 365 57 48 - http://blog.ffwll.ch
Daniel Vetter June 10, 2014, 3:28 p.m. UTC | #3
On Tue, Jun 10, 2014 at 04:06:17PM +0100, Thomas Wood wrote:
> On 10 June 2014 15:37, Daniel Vetter <daniel@ffwll.ch> wrote:
> > On Tue, Jun 10, 2014 at 03:30:51PM +0100, Thomas Wood wrote:
> >> Piglit now has a top level "piglit" command and the location of the
> >> tests can now be read from an environment variable.
> >>
> >> Signed-off-by: Thomas Wood <thomas.wood@intel.com>
> >> ---
> >>  README | 27 ++++++++++-----------------
> >>  1 file changed, 10 insertions(+), 17 deletions(-)
> >>
> >> diff --git a/README b/README
> >> index 2cfb5c5..cfa186d 100644
> >> --- a/README
> >> +++ b/README
> >> @@ -34,32 +34,25 @@ tests/
> >>
> >>       git://anongit.freedesktop.org/piglit
> >>
> >> -     and build it (no need to install anything). Then we need to link up the
> >> -     i-g-t sources with piglit
> >> +     There is no need to build and install piglit if it is only going to be
> >> +     used for running i-g-t tests.
> >> +
> >> +     Set the IGT_TEST_ROOT environment variable to point to the tests
> >> +     directory or link up the i-g-t sources with piglit using a symlink:
> >>
> >>       piglit-sources $ cd bin
> >>       piglit-sources/bin $ ln $i-g-t-sources igt -s
> >>
> >> -     To avoid some hassles with piglit's use of Waffle just disable it. Run
> >> -
> >> -     piglit-sources $ cmake -D PIGLIT_USE_WAFFLE=OFF .
> >> -
> >> -     With
> >> -
> >> -     piglit-sources $ ccmake .
> >> -
> >> -     you can check your configuration with a curses interface, too.
> >
> > Hm, why did you drop this? I run into "lack of waffle" every time I try to
> > use piglit ... Otherwise looks good.
> 
> Since there's no need to actually build the Piglit test cases when
> running intel-gpu-tools tests, there's no requirement for waffle
> either.

Oh right ;-) Can you please mention this for dummies like me?
-Daniel
diff mbox

Patch

diff --git a/README b/README
index 2cfb5c5..cfa186d 100644
--- a/README
+++ b/README
@@ -34,32 +34,25 @@  tests/
 
 	git://anongit.freedesktop.org/piglit
 
-	and build it (no need to install anything). Then we need to link up the
-	i-g-t sources with piglit
+	There is no need to build and install piglit if it is only going to be
+	used for running i-g-t tests.
+
+	Set the IGT_TEST_ROOT environment variable to point to the tests
+	directory or link up the i-g-t sources with piglit using a symlink:
 
 	piglit-sources $ cd bin
 	piglit-sources/bin $ ln $i-g-t-sources igt -s
 
-	To avoid some hassles with piglit's use of Waffle just disable it. Run
-
-	piglit-sources $ cmake -D PIGLIT_USE_WAFFLE=OFF .
-
-	With
-
-	piglit-sources $ ccmake .
-
-	you can check your configuration with a curses interface, too.
-
-	The tests in the i-g-t sources need to have been built already. Then we
-	can run the testcases with (as usual as root, no other drm clients
-	running):
+	In both cases, the tests in the i-g-t sources need to have been built
+	already. Then we can run the testcases with (as usual as root, no other
+	drm clients running):
 
-	piglit-sources # ./piglit-run.py igt <results-file>
+	piglit-sources # ./piglit run igt <results-file>
 
 	The testlist is built at runtime, so no need to update anything in
 	piglit when adding new tests. See
 
-	piglit-sources $ ./piglit-run.py -h
+	piglit-sources $ ./piglit run -h
 
 	for some useful options.