diff mbox

[2/2] spi: Remove redundant OOM message in spi.c

Message ID 1402634862-21783-2-git-send-email-sachin.kamat@samsung.com (mailing list archive)
State Accepted
Commit 8331acb3a5515c01a1b73424a56f44c50ad7f1b4
Headers show

Commit Message

Sachin Kamat June 13, 2014, 4:47 a.m. UTC 
Let memory subsystem handle the error logging.

Signed-off-by: Sachin Kamat <sachin.kamat@samsung.com>
---
 drivers/spi/spi.c |    1 -
 1 file changed, 1 deletion(-)

Comments

Naveen Krishna Ch June 13, 2014, 5:11 a.m. UTC | #1 
Hello Sachin,

On 13 June 2014 10:17, Sachin Kamat <sachin.kamat@samsung.com> wrote:
> Let memory subsystem handle the error logging.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@samsung.com>
> ---
>  drivers/spi/spi.c |    1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c
> index d4f9670b51bc..8bbbba5b6236 100644
> --- a/drivers/spi/spi.c
> +++ b/drivers/spi/spi.c
> @@ -352,7 +352,6 @@ struct spi_device *spi_alloc_device(struct spi_master *master)
>
>         spi = kzalloc(sizeof(*spi), GFP_KERNEL);
>         if (!spi) {
> -               dev_err(dev, "cannot alloc spi_device\n");
>                 spi_master_put(master);
>                 return NULL;
>         }
> --
> 1.7.9.5
Reviewed-by: Naveen Krishna Chatradhi <ch.naveen@samsung.com>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-spi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
Mark Brown June 21, 2014, 10:14 a.m. UTC | #2 
On Fri, Jun 13, 2014 at 10:17:42AM +0530, Sachin Kamat wrote:
> Let memory subsystem handle the error logging.

Applied, thanks.
diff mbox

Patch

diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c
index d4f9670b51bc..8bbbba5b6236 100644
--- a/drivers/spi/spi.c
+++ b/drivers/spi/spi.c
@@ -352,7 +352,6 @@  struct spi_device *spi_alloc_device(struct spi_master *master)
 
 	spi = kzalloc(sizeof(*spi), GFP_KERNEL);
 	if (!spi) {
-		dev_err(dev, "cannot alloc spi_device\n");
 		spi_master_put(master);
 		return NULL;
 	}