| Message ID | 1399704998-13321-3-git-send-email-pankaj.dubey@samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Pankaj, On 10.05.2014 08:56, Pankaj Dubey wrote: > As exynos_cpuidle_init and exynos_cpufreq_init function have just one lines > of code for registering platform devices. We can move these lines to > exynos_dt_machine_init and delete exynos_cpuidle_init and exynos_cpufreq_init > function. This will help in reducing lines of code in exynos.c, making it > more cleaner. > > Suggested-by: Tomasz Figa <t.figa@samsung.com> > Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com> > --- > arch/arm/mach-exynos/exynos.c | 19 ++++--------------- > 1 file changed, 4 insertions(+), 15 deletions(-) > Reviewed-by: Tomasz Figa <t.figa@samsung.com> Btw. This and other simple clean-up patches from this series could be applied separately, without re-spinning them every time with this series. Best regards, Tomasz
Hi Tomasz, > -----Original Message----- > > Hi Pankaj, > > On 10.05.2014 08:56, Pankaj Dubey wrote: > > As exynos_cpuidle_init and exynos_cpufreq_init function have just one > > lines of code for registering platform devices. We can move these > > lines to exynos_dt_machine_init and delete exynos_cpuidle_init and > > exynos_cpufreq_init function. This will help in reducing lines of code > > in exynos.c, making it more cleaner. > > > > Suggested-by: Tomasz Figa <t.figa@samsung.com> > > Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com> > > --- > > arch/arm/mach-exynos/exynos.c | 19 ++++--------------- > > 1 file changed, 4 insertions(+), 15 deletions(-) > > > > Reviewed-by: Tomasz Figa <t.figa@samsung.com> > Thanks for review. > Btw. This and other simple clean-up patches from this series could be applied > separately, without re-spinning them every time with this series. > OK, I will separate cleanup patches. > Best regards, > Tomasz Thanks, Pankaj Dubey
diff --git a/arch/arm/mach-exynos/exynos.c b/arch/arm/mach-exynos/exynos.c index bf8a473..288e414 100644 --- a/arch/arm/mach-exynos/exynos.c +++ b/arch/arm/mach-exynos/exynos.c @@ -176,19 +176,6 @@ static struct platform_device exynos_cpuidle = { .id = -1, }; -void __init exynos_cpuidle_init(void) -{ - if (soc_is_exynos5440()) - return; - - platform_device_register(&exynos_cpuidle); -} - -void __init exynos_cpufreq_init(void) -{ - platform_device_register_simple("exynos-cpufreq", -1, NULL, 0); -} - static void __init exynos_init_late(void) { if (of_machine_is_compatible("samsung,exynos5440")) @@ -303,8 +290,10 @@ static void __init exynos_dt_machine_init(void) } } - exynos_cpuidle_init(); - exynos_cpufreq_init(); + if (!soc_is_exynos5440()) + platform_device_register(&exynos_cpuidle); + + platform_device_register_simple("exynos-cpufreq", -1, NULL, 0); of_platform_populate(NULL, of_default_bus_match_table, NULL, NULL); }
As exynos_cpuidle_init and exynos_cpufreq_init function have just one lines of code for registering platform devices. We can move these lines to exynos_dt_machine_init and delete exynos_cpuidle_init and exynos_cpufreq_init function. This will help in reducing lines of code in exynos.c, making it more cleaner. Suggested-by: Tomasz Figa <t.figa@samsung.com> Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com> --- arch/arm/mach-exynos/exynos.c | 19 ++++--------------- 1 file changed, 4 insertions(+), 15 deletions(-)