diff mbox

backlight: Fix compile error

Message ID 1403095316-6365-1-git-send-email-hdegoede@redhat.com (mailing list archive)
State New, archived
Headers show

Commit Message

Hans de Goede June 18, 2014, 12:41 p.m. UTC
/usr/include/xorg/os.h around line 579 reads:

extern _X_EXPORT char *
strndup(const char *str, size_t n);

However strndup is already defined by glibc, and this redefine causes a
compile error.

This gets triggered because backlight.c does:

Without first doing:

Causing HAVE_STRNDUP to not be defined.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
 src/backlight.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Chris Wilson June 18, 2014, 1:12 p.m. UTC | #1
On Wed, Jun 18, 2014 at 02:41:56PM +0200, Hans de Goede wrote:
> /usr/include/xorg/os.h around line 579 reads:
> 
> extern _X_EXPORT char *
> strndup(const char *str, size_t n);
> 
> However strndup is already defined by glibc, and this redefine causes a
> compile error.
> 
> This gets triggered because backlight.c does:
> 
> Without first doing:
> 
> Causing HAVE_STRNDUP to not be defined.
> 
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>

Pushed with one extra newline to break up the xorg headers from the
rest.

Thanks,
-Chris
diff mbox

Patch

diff --git a/src/backlight.c b/src/backlight.c
index d5b10a0..62241ab 100644
--- a/src/backlight.c
+++ b/src/backlight.c
@@ -42,6 +42,7 @@ 
 #include <fcntl.h>
 #include <unistd.h>
 #include <dirent.h>
+#include <xorg-server.h>
 #include <xf86.h>
 #include <pciaccess.h>