| Message ID | 1403104668-32316-1-git-send-email-balbi@ti.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
nit pick: s/regulators: TPS65218:/regulators: tps65218:/ On 06/18/2014 10:17 AM, Felipe Balbi wrote: > From: Keerthy <j-keerthy@ti.com> > > Add the missing of_node assignment in probe. Hmm... I think an explanation of the type below might be nice: config.of_node is used to populate the regulator_dev->dev.of_node as part of registration. this is used for consumer supply match to the right regulator device such as in regulator_dev_lookup. not populating config.of_node results in inability to use the regulator node as a supply in device tree. > > Cc: <stable@vger.kernel.org> # v3.15 Fixes: 90e7d5262796 (regulator: tps65218: Add Regulator driver for TPS65218 PMIC) ? > Signed-off-by: Keerthy <j-keerthy@ti.com> > Signed-off-by: Felipe Balbi <balbi@ti.com> > --- > drivers/regulator/tps65218-regulator.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/regulator/tps65218-regulator.c b/drivers/regulator/tps65218-regulator.c > index 69b4b77..edbc46e 100644 > --- a/drivers/regulator/tps65218-regulator.c > +++ b/drivers/regulator/tps65218-regulator.c > @@ -240,6 +240,7 @@ static int tps65218_regulator_probe(struct platform_device *pdev) > config.init_data = init_data; > config.driver_data = tps; > config.regmap = tps->regmap; > + config.of_node = pdev->dev.of_node; > > rdev = devm_regulator_register(&pdev->dev, ®ulators[id], &config); > if (IS_ERR(rdev)) { > otherwise, Acked-by: Nishanth Menon <nm@ti.com>
On Wed, Jun 18, 2014 at 10:17:47AM -0500, Felipe Balbi wrote: > From: Keerthy <j-keerthy@ti.com> > > Add the missing of_node assignment in probe. Applied both, thanks. Please use subject lines reflecting the style for the subsystem.
diff --git a/drivers/regulator/tps65218-regulator.c b/drivers/regulator/tps65218-regulator.c index 69b4b77..edbc46e 100644 --- a/drivers/regulator/tps65218-regulator.c +++ b/drivers/regulator/tps65218-regulator.c @@ -240,6 +240,7 @@ static int tps65218_regulator_probe(struct platform_device *pdev) config.init_data = init_data; config.driver_data = tps; config.regmap = tps->regmap; + config.of_node = pdev->dev.of_node; rdev = devm_regulator_register(&pdev->dev, ®ulators[id], &config); if (IS_ERR(rdev)) {