| Message ID | 1402954800-28215-2-git-send-email-dianders@chromium.org (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
On Mon, 16 Jun 2014, Doug Anderson wrote: > From: Bill Richardson <wfrichar@chromium.org> > > This comment was incorrect, so update it. > > Signed-off-by: Bill Richardson <wfrichar@chromium.org> > Signed-off-by: Simon Glass <sjg@chromium.org> How many people did it take to write this patch? ;) Acked-by: Lee Jones <lee.jones@linaro.org> > Signed-off-by: Doug Anderson <dianders@chromium.org> > --- > include/linux/mfd/cros_ec.h | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/include/linux/mfd/cros_ec.h b/include/linux/mfd/cros_ec.h > index 887ef4f..7e9fe6e 100644 > --- a/include/linux/mfd/cros_ec.h > +++ b/include/linux/mfd/cros_ec.h > @@ -148,8 +148,7 @@ int cros_ec_prepare_tx(struct cros_ec_device *ec_dev, > /** > * cros_ec_remove - Remove a ChromeOS EC > * > - * Call this to deregister a ChromeOS EC. After this you should call > - * cros_ec_free(). > + * Call this to deregister a ChromeOS EC, then clean up any private data. > * > * @ec_dev: Device to register > * @return 0 if ok, -ve on error
Lee, On Wed, Jun 18, 2014 at 12:57 AM, Lee Jones <lee.jones@linaro.org> wrote: > On Mon, 16 Jun 2014, Doug Anderson wrote: > >> From: Bill Richardson <wfrichar@chromium.org> >> >> This comment was incorrect, so update it. >> >> Signed-off-by: Bill Richardson <wfrichar@chromium.org> >> Signed-off-by: Simon Glass <sjg@chromium.org> > > How many people did it take to write this patch? ;) > > Acked-by: Lee Jones <lee.jones@linaro.org> There's gotta be a joke here about how many Google engineers it takes to fix a comment. In this case I think the answer is 3: one to fix the comment, one to clean it up, and one to send it upstream. ;) -Doug -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, 18 Jun 2014, Doug Anderson wrote: > Lee, > > On Wed, Jun 18, 2014 at 12:57 AM, Lee Jones <lee.jones@linaro.org> wrote: > > On Mon, 16 Jun 2014, Doug Anderson wrote: > > > >> From: Bill Richardson <wfrichar@chromium.org> > >> > >> This comment was incorrect, so update it. > >> > >> Signed-off-by: Bill Richardson <wfrichar@chromium.org> > >> Signed-off-by: Simon Glass <sjg@chromium.org> > > > > How many people did it take to write this patch? ;) > > > > Acked-by: Lee Jones <lee.jones@linaro.org> > > There's gotta be a joke here about how many Google engineers it takes > to fix a comment. In this case I think the answer is 3: one to fix > the comment, one to clean it up, and one to send it upstream. ;) ... and one to hold the ladder. No, wait! ;)
diff --git a/include/linux/mfd/cros_ec.h b/include/linux/mfd/cros_ec.h index 887ef4f..7e9fe6e 100644 --- a/include/linux/mfd/cros_ec.h +++ b/include/linux/mfd/cros_ec.h @@ -148,8 +148,7 @@ int cros_ec_prepare_tx(struct cros_ec_device *ec_dev, /** * cros_ec_remove - Remove a ChromeOS EC * - * Call this to deregister a ChromeOS EC. After this you should call - * cros_ec_free(). + * Call this to deregister a ChromeOS EC, then clean up any private data. * * @ec_dev: Device to register * @return 0 if ok, -ve on error