diff mbox

[v3] ARM: shmobile: Mark all SoCs in shmobile as CPUFreq, capable

Message ID 538FE8D8.3050602@bp.renesas.com (mailing list archive)
State Accepted
Commit 6596e97e054647fecb016ecb7e1935aa2b7db954
Headers show

Commit Message

Gaku Inami June 5, 2014, 3:49 a.m. UTC 
From: Benoit Cousson <bcousson@baylibre.com>

Mark all SoCs in shmobile as CPUFreq capable
on multiplatform build only.

Signed-off-by: Benoit Cousson <bcousson@baylibre.com>
[gaku.inami.xw@bp.renesas.com: Move the definition of cpufreq capable]
Signed-off-by: Gaku Inami <gaku.inami.xw@bp.renesas.com>
---

Changes since version 1:
- changed "Signed-off-by" and "From" correctly.
- fixed typo.

Changes since version 2:
- moved the definition of cpufreq capable for shmobile.
- reworked based on renesas-devel-v3.15-rc8-20140605.

 arch/arm/mach-shmobile/Kconfig |    2 ++
 1 file changed, 2 insertions(+)

Comments

Simon Horman June 5, 2014, 4:09 a.m. UTC | #1 
On Thu, Jun 05, 2014 at 12:49:44PM +0900, Gaku Inami wrote:
> From: Benoit Cousson <bcousson@baylibre.com>
> 
> Mark all SoCs in shmobile as CPUFreq capable
> on multiplatform build only.
> 
> Signed-off-by: Benoit Cousson <bcousson@baylibre.com>
> [gaku.inami.xw@bp.renesas.com: Move the definition of cpufreq capable]
> Signed-off-by: Gaku Inami <gaku.inami.xw@bp.renesas.com>

Thanks, I have queued this up.
--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Paul Bolle June 19, 2014, 7:49 a.m. UTC | #2 
On Thu, 2014-06-05 at 12:49 +0900, Gaku Inami wrote:
> From: Benoit Cousson <bcousson@baylibre.com>
> 
> Mark all SoCs in shmobile as CPUFreq capable
> on multiplatform build only.
> 
> Signed-off-by: Benoit Cousson <bcousson@baylibre.com>
> [gaku.inami.xw@bp.renesas.com: Move the definition of cpufreq capable]
> Signed-off-by: Gaku Inami <gaku.inami.xw@bp.renesas.com>
> ---

This patch landed in next-20140619.

> Changes since version 1:
> - changed "Signed-off-by" and "From" correctly.
> - fixed typo.
> 
> Changes since version 2:
> - moved the definition of cpufreq capable for shmobile.
> - reworked based on renesas-devel-v3.15-rc8-20140605.
> 
>  arch/arm/mach-shmobile/Kconfig |    2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm/mach-shmobile/Kconfig b/arch/arm/mach-shmobile/Kconfig
> index 2a7712b..3b28bd8 100644
> --- a/arch/arm/mach-shmobile/Kconfig
> +++ b/arch/arm/mach-shmobile/Kconfig
> @@ -13,6 +13,8 @@ config ARCH_SHMOBILE_MULTI
>  	select NO_IOPORT_MAP
>  	select PINCTRL
>  	select ARCH_REQUIRE_GPIOLIB
> +	select ARCH_HAS_CPUFREQ

The symbol ARCH_HAS_CPUFREQ was just removed in next-20140616, see
commit e49d9b375628 ("ARM: Remove ARCH_HAS_CPUFREQ config option"). So
selecting that became a nop.

Is the trivial patch to drop this select statement queued somewhere? 

(Grepping for CPU_FREQ and CPUFREQ in arch/arm/mach-shmobile suggests
that this trivial patch is all that is needed at this point.)

> +	select ARCH_HAS_OPP
>  
>  if ARCH_SHMOBILE_MULTI
>  


Paul Bolle

--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Simon Horman June 19, 2014, 8:09 a.m. UTC | #3 
On Thu, Jun 19, 2014 at 09:49:35AM +0200, Paul Bolle wrote:
> On Thu, 2014-06-05 at 12:49 +0900, Gaku Inami wrote:
> > From: Benoit Cousson <bcousson@baylibre.com>
> > 
> > Mark all SoCs in shmobile as CPUFreq capable
> > on multiplatform build only.
> > 
> > Signed-off-by: Benoit Cousson <bcousson@baylibre.com>
> > [gaku.inami.xw@bp.renesas.com: Move the definition of cpufreq capable]
> > Signed-off-by: Gaku Inami <gaku.inami.xw@bp.renesas.com>
> > ---
> 
> This patch landed in next-20140619.
> 
> > Changes since version 1:
> > - changed "Signed-off-by" and "From" correctly.
> > - fixed typo.
> > 
> > Changes since version 2:
> > - moved the definition of cpufreq capable for shmobile.
> > - reworked based on renesas-devel-v3.15-rc8-20140605.
> > 
> >  arch/arm/mach-shmobile/Kconfig |    2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/arch/arm/mach-shmobile/Kconfig b/arch/arm/mach-shmobile/Kconfig
> > index 2a7712b..3b28bd8 100644
> > --- a/arch/arm/mach-shmobile/Kconfig
> > +++ b/arch/arm/mach-shmobile/Kconfig
> > @@ -13,6 +13,8 @@ config ARCH_SHMOBILE_MULTI
> >  	select NO_IOPORT_MAP
> >  	select PINCTRL
> >  	select ARCH_REQUIRE_GPIOLIB
> > +	select ARCH_HAS_CPUFREQ
> 
> The symbol ARCH_HAS_CPUFREQ was just removed in next-20140616, see
> commit e49d9b375628 ("ARM: Remove ARCH_HAS_CPUFREQ config option"). So
> selecting that became a nop.
> 
> Is the trivial patch to drop this select statement queued somewhere? 
> 
> (Grepping for CPU_FREQ and CPUFREQ in arch/arm/mach-shmobile suggests
> that this trivial patch is all that is needed at this point.)
> 
> > +	select ARCH_HAS_OPP
> >  
> >  if ARCH_SHMOBILE_MULTI

Thanks for the follow-up Paul.

Inami-san, could you please make an appropriate patch?

Please note the dependency on the patch that Paul has noted,
hopefully it will be included in v3.16-rc2.
--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Gaku Inami June 19, 2014, 9:16 a.m. UTC | #4 
Hi Simon-san,

(2014/06/19 17:09), Simon Horman wrote:
>
> Inami-san, could you please make an appropriate patch?
>
> Please note the dependency on the patch that Paul has noted,
> hopefully it will be included in v3.16-rc2.

I understand. I will fix it and send again.

Regards,
Inami

--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Simon Horman June 20, 2014, 1:18 a.m. UTC | #5 
On Thu, Jun 19, 2014 at 06:16:13PM +0900, Gaku Inami wrote:
> Hi Simon-san,
> 
> (2014/06/19 17:09), Simon Horman wrote:
> >
> > Inami-san, could you please make an appropriate patch?
> >
> > Please note the dependency on the patch that Paul has noted,
> > hopefully it will be included in v3.16-rc2.
> 
> I understand. I will fix it and send again.

Please just send an (probably small) incremental patch that applies
on top of my current devel branch. There is no need to rework
your patches that I have already queued up.

Thanks
--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Gaku Inami June 20, 2014, 4:40 a.m. UTC | #6 
Hi Simon-san,

(2014/06/20 10:18), Simon Horman wrote:
> On Thu, Jun 19, 2014 at 06:16:13PM +0900, Gaku Inami wrote:
>> Hi Simon-san,
>>
>> (2014/06/19 17:09), Simon Horman wrote:
>>> Inami-san, could you please make an appropriate patch?
>>>
>>> Please note the dependency on the patch that Paul has noted,
>>> hopefully it will be included in v3.16-rc2.
>> I understand. I will fix it and send again.
> Please just send an (probably small) incremental patch that applies
> on top of my current devel branch. There is no need to rework
> your patches that I have already queued up.

I'm sorry, my reply was not appropriate.

I posted a new patch(no rework patch from patch v3).
Please find the following commit:
 http://marc.info/?l=linux-sh&m=140317622532328&w=2

This patch can be applied to the top of renesas-devel.
(tag:renesas-devel-v3.16-rc1-20140618)
Also, this patch can be applied to linux-next(next-20140619).

Regards,
Inami

--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Simon Horman June 20, 2014, 5:04 a.m. UTC | #7 
On Fri, Jun 20, 2014 at 01:40:15PM +0900, Gaku Inami wrote:
> Hi Simon-san,
> 
> (2014/06/20 10:18), Simon Horman wrote:
> > On Thu, Jun 19, 2014 at 06:16:13PM +0900, Gaku Inami wrote:
> >> Hi Simon-san,
> >>
> >> (2014/06/19 17:09), Simon Horman wrote:
> >>> Inami-san, could you please make an appropriate patch?
> >>>
> >>> Please note the dependency on the patch that Paul has noted,
> >>> hopefully it will be included in v3.16-rc2.
> >> I understand. I will fix it and send again.
> > Please just send an (probably small) incremental patch that applies
> > on top of my current devel branch. There is no need to rework
> > your patches that I have already queued up.
> 
> I'm sorry, my reply was not appropriate.
> 
> I posted a new patch(no rework patch from patch v3).
> Please find the following commit:
>  http://marc.info/?l=linux-sh&m=140317622532328&w=2
> 
> This patch can be applied to the top of renesas-devel.
> (tag:renesas-devel-v3.16-rc1-20140618)
> Also, this patch can be applied to linux-next(next-20140619).

Thanks, it looks good.
--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/arch/arm/mach-shmobile/Kconfig b/arch/arm/mach-shmobile/Kconfig
index 2a7712b..3b28bd8 100644
--- a/arch/arm/mach-shmobile/Kconfig
+++ b/arch/arm/mach-shmobile/Kconfig
@@ -13,6 +13,8 @@  config ARCH_SHMOBILE_MULTI
 	select NO_IOPORT_MAP
 	select PINCTRL
 	select ARCH_REQUIRE_GPIOLIB
+	select ARCH_HAS_CPUFREQ
+	select ARCH_HAS_OPP
 
 if ARCH_SHMOBILE_MULTI