diff mbox

ARM: mvebu: Fix broken SoC ID detection

Message ID 1402347165-19988-1-git-send-email-ezequiel.garcia@free-electrons.com (mailing list archive)
State New, archived
Headers show

Commit Message

Ezequiel Garcia June 9, 2014, 8:52 p.m. UTC
Currently the mvebu boards need to detect the SoC revision in order to apply
some quirks needed to workaround issues found on I2C and thermal controllers
present only in very early SoC.

This detection requires PCI address translation to work, so we need to
explicitly select OF_ADDRESS_PCI.

This can be considered a partial revert of the following commit, that
wrongly removed the option selection:

commit 55400f3a1f89e39761f45c19f6e4235a329c400b
Author: Rob Herring <robh@kernel.org>
Date:   Tue Apr 22 14:15:52 2014 -0500

    ARM: mvebu: clean-up unneeded kconfig selects

Signed-off-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
---
 arch/arm/mach-mvebu/Kconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Rob Herring (Arm) June 9, 2014, 10:13 p.m. UTC | #1
On Mon, Jun 9, 2014 at 3:52 PM, Ezequiel Garcia
<ezequiel.garcia@free-electrons.com> wrote:
> Currently the mvebu boards need to detect the SoC revision in order to apply
> some quirks needed to workaround issues found on I2C and thermal controllers
> present only in very early SoC.
>
> This detection requires PCI address translation to work, so we need to
> explicitly select OF_ADDRESS_PCI.
>
> This can be considered a partial revert of the following commit, that
> wrongly removed the option selection:
>
> commit 55400f3a1f89e39761f45c19f6e4235a329c400b
> Author: Rob Herring <robh@kernel.org>
> Date:   Tue Apr 22 14:15:52 2014 -0500
>
>     ARM: mvebu: clean-up unneeded kconfig selects
>
> Signed-off-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>

Thanks for fixing it.

Acked-by: Rob Herring <robh@kernel.org>

Rob
Jason Cooper June 20, 2014, 8:33 p.m. UTC | #2
On Mon, Jun 09, 2014 at 05:52:45PM -0300, Ezequiel Garcia wrote:
> Currently the mvebu boards need to detect the SoC revision in order to apply
> some quirks needed to workaround issues found on I2C and thermal controllers
> present only in very early SoC.
> 
> This detection requires PCI address translation to work, so we need to
> explicitly select OF_ADDRESS_PCI.
> 
> This can be considered a partial revert of the following commit, that
> wrongly removed the option selection:
> 
> commit 55400f3a1f89e39761f45c19f6e4235a329c400b
> Author: Rob Herring <robh@kernel.org>
> Date:   Tue Apr 22 14:15:52 2014 -0500
> 
>     ARM: mvebu: clean-up unneeded kconfig selects
> 
> Signed-off-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
> ---
>  arch/arm/mach-mvebu/Kconfig | 1 +
>  1 file changed, 1 insertion(+)

Applied to mvebu/fixes with Rob's Ack.

thx,

Jason.
diff mbox

Patch

diff --git a/arch/arm/mach-mvebu/Kconfig b/arch/arm/mach-mvebu/Kconfig
index 6090b9e..61ac80a 100644
--- a/arch/arm/mach-mvebu/Kconfig
+++ b/arch/arm/mach-mvebu/Kconfig
@@ -10,6 +10,7 @@  config ARCH_MVEBU
 	select ZONE_DMA if ARM_LPAE
 	select ARCH_REQUIRE_GPIOLIB
 	select PCI_QUIRKS if PCI
+	select OF_ADDRESS_PCI
 
 if ARCH_MVEBU