diff mbox

cxgb4: Remove duplicate tcp-options clearing

Message ID 1403609642-27757-1-git-send-email-christoph.paasch@uclouvain.be (mailing list archive)
State Rejected
Headers show

Commit Message

Christoph Paasch June 24, 2014, 11:34 a.m. UTC
tmp_opt is memset to 0. Thus, no need for another call to
tcp_clear_options which simply sets some fields explicitly to 0 again.

Cc: Steve Wise <swise@chelsio.com>
Cc: Roland Dreier <roland@kernel.org>
Cc: Sean Hefty <sean.hefty@intel.com>
Cc: Hal Rosenstock <hal.rosenstock@gmail.com>
Cc: linux-rdma@vger.kernel.org
Signed-off-by: Christoph Paasch <christoph.paasch@uclouvain.be>
---
 drivers/infiniband/hw/cxgb4/cm.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Steve Wise June 24, 2014, 1:49 p.m. UTC | #1
Acked-by: Steve Wise <swise@opengridcomputing.com>


--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/infiniband/hw/cxgb4/cm.c b/drivers/infiniband/hw/cxgb4/cm.c
index 96d7131ab974..2106a6dc62b3 100644
--- a/drivers/infiniband/hw/cxgb4/cm.c
+++ b/drivers/infiniband/hw/cxgb4/cm.c
@@ -3326,7 +3326,6 @@  static void build_cpl_pass_accept_req(struct sk_buff *skb, int stid , u8 tos)
 	 * to generate cpl_pass_accept_req.
 	 */
 	memset(&tmp_opt, 0, sizeof(tmp_opt));
-	tcp_clear_options(&tmp_opt);
 	tcp_parse_options(skb, &tmp_opt, 0, NULL);
 
 	req = (struct cpl_pass_accept_req *)__skb_push(skb, sizeof(*req));