| Message ID | 1402913484-25910-8-git-send-email-denis@eukrea.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Denis, This patch creates binding documentation. Any patch which does so should be copied to the DT people so they can review the bindings and give appropriate acks. It would be better if you separate the binding documentation updates from the other functional changes too. I've added them on this reply to see whether they'll feel friendly enough to comment on the patch as it stands to avoid having to go through two more rounds on this already-fourteen revision patch set. On Mon, Jun 16, 2014 at 12:11:22PM +0200, Denis Carikli wrote: > Signed-off-by: Denis Carikli <denis@eukrea.com> > --- > ChangeLog v13->v14: > - None > > ChangeLog v12->v13: > - Added a note explaining why the size is zero in > the eukrea_mbimxsd51_dvi(s)vga structs. > ChangeLog v11->v12: > - Rebased: It now uses the new DRM_MODE_FLAG_POL_DE flags defines names > > ChangeLog v10->v11: > - New patch. > --- > .../bindings/panel/eukrea,mbimxsd51-cmo-qvga.txt | 7 ++ > .../bindings/panel/eukrea,mbimxsd51-dvi-svga.txt | 7 ++ > .../bindings/panel/eukrea,mbimxsd51-dvi-vga.txt | 7 ++ > drivers/gpu/drm/panel/panel-simple.c | 83 ++++++++++++++++++++ > 4 files changed, 104 insertions(+) > create mode 100644 Documentation/devicetree/bindings/panel/eukrea,mbimxsd51-cmo-qvga.txt > create mode 100644 Documentation/devicetree/bindings/panel/eukrea,mbimxsd51-dvi-svga.txt > create mode 100644 Documentation/devicetree/bindings/panel/eukrea,mbimxsd51-dvi-vga.txt > > diff --git a/Documentation/devicetree/bindings/panel/eukrea,mbimxsd51-cmo-qvga.txt b/Documentation/devicetree/bindings/panel/eukrea,mbimxsd51-cmo-qvga.txt > new file mode 100644 > index 0000000..03679d0 > --- /dev/null > +++ b/Documentation/devicetree/bindings/panel/eukrea,mbimxsd51-cmo-qvga.txt > @@ -0,0 +1,7 @@ > +Eukrea CMO-QVGA (320x240 pixels) TFT LCD panel > + > +Required properties: > +- compatible: should be "eukrea,mbimxsd51-cmo-qvga" > + > +This binding is compatible with the simple-panel binding, which is specified > +in simple-panel.txt in this directory. > diff --git a/Documentation/devicetree/bindings/panel/eukrea,mbimxsd51-dvi-svga.txt b/Documentation/devicetree/bindings/panel/eukrea,mbimxsd51-dvi-svga.txt > new file mode 100644 > index 0000000..f408c9a > --- /dev/null > +++ b/Documentation/devicetree/bindings/panel/eukrea,mbimxsd51-dvi-svga.txt > @@ -0,0 +1,7 @@ > +Eukrea DVI-SVGA (800x600 pixels) DVI output. > + > +Required properties: > +- compatible: should be "eukrea,mbimxsd51-dvi-svga" > + > +This binding is compatible with the simple-panel binding, which is specified > +in simple-panel.txt in this directory. > diff --git a/Documentation/devicetree/bindings/panel/eukrea,mbimxsd51-dvi-vga.txt b/Documentation/devicetree/bindings/panel/eukrea,mbimxsd51-dvi-vga.txt > new file mode 100644 > index 0000000..8ea90da > --- /dev/null > +++ b/Documentation/devicetree/bindings/panel/eukrea,mbimxsd51-dvi-vga.txt > @@ -0,0 +1,7 @@ > +Eukrea DVI-VGA (640x480 pixels) DVI output. > + > +Required properties: > +- compatible: should be "eukrea,mbimxsd51-dvi-vga" > + > +This binding is compatible with the simple-panel binding, which is specified > +in simple-panel.txt in this directory. > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c > index a251361..adc40a7 100644 > --- a/drivers/gpu/drm/panel/panel-simple.c > +++ b/drivers/gpu/drm/panel/panel-simple.c > @@ -403,6 +403,80 @@ static const struct panel_desc edt_etm0700g0dh6 = { > }, > }; > > +static const struct drm_display_mode eukrea_mbimxsd51_cmoqvga_mode = { > + .clock = 6500, > + .hdisplay = 320, > + .hsync_start = 320 + 38, > + .hsync_end = 320 + 38 + 20, > + .htotal = 320 + 38 + 20 + 30, > + .vdisplay = 240, > + .vsync_start = 240 + 15, > + .vsync_end = 240 + 15 + 4, > + .vtotal = 240 + 15 + 4 + 3, > + .vrefresh = 60, > + .pol_flags = DRM_MODE_FLAG_POL_PIXDATA_NEGEDGE | > + DRM_MODE_FLAG_POL_DE_LOW, > +}; > + > +static const struct panel_desc eukrea_mbimxsd51_cmoqvga = { > + .modes = &eukrea_mbimxsd51_cmoqvga_mode, > + .num_modes = 1, > + .size = { > + .width = 73, > + .height = 56, > + }, > +}; > + > +static const struct drm_display_mode eukrea_mbimxsd51_dvisvga_mode = { > + .clock = 44333, > + .hdisplay = 800, > + .hsync_start = 800 + 112, > + .hsync_end = 800 + 112 + 32, > + .htotal = 800 + 112 + 32 + 80, > + .vdisplay = 600, > + .vsync_start = 600 + 3, > + .vsync_end = 600 + 3 + 17, > + .vtotal = 600 + 3 + 17 + 4, > + .vrefresh = 60, > + .pol_flags = DRM_MODE_FLAG_POL_PIXDATA_POSEDGE | > + DRM_MODE_FLAG_POL_DE_HIGH, > +}; > + > +static const struct panel_desc eukrea_mbimxsd51_dvisvga = { > + .modes = &eukrea_mbimxsd51_dvisvga_mode, > + .num_modes = 1, > + /* This is a DVI adapter for external displays */ > + .size = { > + .width = 0, > + .height = 0, > + }, > +}; > + > +static const struct drm_display_mode eukrea_mbimxsd51_dvivga_mode = { > + .clock = 23750, > + .hdisplay = 640, > + .hsync_start = 640 + 80, > + .hsync_end = 640 + 80 + 16, > + .htotal = 640 + 80 + 16 + 64, > + .vdisplay = 480, > + .vsync_start = 480 + 3, > + .vsync_end = 480 + 3 + 13, > + .vtotal = 480 + 3 + 13 + 4, > + .vrefresh = 60, > + .pol_flags = DRM_MODE_FLAG_POL_PIXDATA_POSEDGE | > + DRM_MODE_FLAG_POL_DE_HIGH, > +}; > + > +static const struct panel_desc eukrea_mbimxsd51_dvivga = { > + .modes = &eukrea_mbimxsd51_dvivga_mode, > + .num_modes = 1, > + /* This is a DVI adapter for external displays */ > + .size = { > + .width = 0, > + .height = 0, > + }, > +}; > + > static const struct drm_display_mode lg_lp129qe_mode = { > .clock = 285250, > .hdisplay = 2560, > @@ -458,6 +532,15 @@ static const struct of_device_id platform_of_match[] = { > .compatible = "chunghwa,claa101wa01a", > .data = &chunghwa_claa101wa01a > }, { > + .compatible = "eukrea,mbimxsd51-cmo-qvga", > + .data = &eukrea_mbimxsd51_cmoqvga, > + }, { > + .compatible = "eukrea,mbimxsd51-dvi-svga", > + .data = &eukrea_mbimxsd51_dvisvga, > + }, { > + .compatible = "eukrea,mbimxsd51-dvi-vga", > + .data = &eukrea_mbimxsd51_dvivga, > + }, { > .compatible = "chunghwa,claa101wb01", > .data = &chunghwa_claa101wb01 > }, { > -- > 1.7.9.5 >
On Tue, Jun 24, 2014 at 10:06 AM, Russell King - ARM Linux <linux@arm.linux.org.uk> wrote: > Denis, > > This patch creates binding documentation. Any patch which does so > should be copied to the DT people so they can review the bindings > and give appropriate acks. It would be better if you separate the > binding documentation updates from the other functional changes too. > > I've added them on this reply to see whether they'll feel friendly > enough to comment on the patch as it stands to avoid having to go > through two more rounds on this already-fourteen revision patch set. > > On Mon, Jun 16, 2014 at 12:11:22PM +0200, Denis Carikli wrote: >> Signed-off-by: Denis Carikli <denis@eukrea.com> >> --- >> ChangeLog v13->v14: >> - None >> >> ChangeLog v12->v13: >> - Added a note explaining why the size is zero in >> the eukrea_mbimxsd51_dvi(s)vga structs. >> ChangeLog v11->v12: >> - Rebased: It now uses the new DRM_MODE_FLAG_POL_DE flags defines names >> >> ChangeLog v10->v11: >> - New patch. >> --- >> .../bindings/panel/eukrea,mbimxsd51-cmo-qvga.txt | 7 ++ >> .../bindings/panel/eukrea,mbimxsd51-dvi-svga.txt | 7 ++ >> .../bindings/panel/eukrea,mbimxsd51-dvi-vga.txt | 7 ++ >> drivers/gpu/drm/panel/panel-simple.c | 83 ++++++++++++++++++++ >> 4 files changed, 104 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/panel/eukrea,mbimxsd51-cmo-qvga.txt >> create mode 100644 Documentation/devicetree/bindings/panel/eukrea,mbimxsd51-dvi-svga.txt >> create mode 100644 Documentation/devicetree/bindings/panel/eukrea,mbimxsd51-dvi-vga.txt >> >> diff --git a/Documentation/devicetree/bindings/panel/eukrea,mbimxsd51-cmo-qvga.txt b/Documentation/devicetree/bindings/panel/eukrea,mbimxsd51-cmo-qvga.txt >> new file mode 100644 >> index 0000000..03679d0 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/panel/eukrea,mbimxsd51-cmo-qvga.txt >> @@ -0,0 +1,7 @@ >> +Eukrea CMO-QVGA (320x240 pixels) TFT LCD panel >> + >> +Required properties: >> +- compatible: should be "eukrea,mbimxsd51-cmo-qvga" >> + >> +This binding is compatible with the simple-panel binding, which is specified >> +in simple-panel.txt in this directory. >> diff --git a/Documentation/devicetree/bindings/panel/eukrea,mbimxsd51-dvi-svga.txt b/Documentation/devicetree/bindings/panel/eukrea,mbimxsd51-dvi-svga.txt >> new file mode 100644 >> index 0000000..f408c9a >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/panel/eukrea,mbimxsd51-dvi-svga.txt >> @@ -0,0 +1,7 @@ >> +Eukrea DVI-SVGA (800x600 pixels) DVI output. >> + >> +Required properties: >> +- compatible: should be "eukrea,mbimxsd51-dvi-svga" >> + >> +This binding is compatible with the simple-panel binding, which is specified >> +in simple-panel.txt in this directory. >> diff --git a/Documentation/devicetree/bindings/panel/eukrea,mbimxsd51-dvi-vga.txt b/Documentation/devicetree/bindings/panel/eukrea,mbimxsd51-dvi-vga.txt >> new file mode 100644 >> index 0000000..8ea90da >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/panel/eukrea,mbimxsd51-dvi-vga.txt >> @@ -0,0 +1,7 @@ >> +Eukrea DVI-VGA (640x480 pixels) DVI output. >> + >> +Required properties: >> +- compatible: should be "eukrea,mbimxsd51-dvi-vga" >> + >> +This binding is compatible with the simple-panel binding, which is specified >> +in simple-panel.txt in this directory. Seems like we could just have a list of compatible strings rather than a mostly duplicated file. >> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c >> index a251361..adc40a7 100644 >> --- a/drivers/gpu/drm/panel/panel-simple.c >> +++ b/drivers/gpu/drm/panel/panel-simple.c >> @@ -403,6 +403,80 @@ static const struct panel_desc edt_etm0700g0dh6 = { >> }, >> }; >> >> +static const struct drm_display_mode eukrea_mbimxsd51_cmoqvga_mode = { >> + .clock = 6500, >> + .hdisplay = 320, >> + .hsync_start = 320 + 38, >> + .hsync_end = 320 + 38 + 20, >> + .htotal = 320 + 38 + 20 + 30, >> + .vdisplay = 240, >> + .vsync_start = 240 + 15, >> + .vsync_end = 240 + 15 + 4, >> + .vtotal = 240 + 15 + 4 + 3, >> + .vrefresh = 60, >> + .pol_flags = DRM_MODE_FLAG_POL_PIXDATA_NEGEDGE | >> + DRM_MODE_FLAG_POL_DE_LOW, Why aren't you using: Documentation/devicetree/bindings/video/display-timing.txt Rob
On Mon, Jun 16, 2014 at 12:11:22PM +0200, Denis Carikli wrote: [...] > diff --git a/Documentation/devicetree/bindings/panel/eukrea,mbimxsd51-dvi-svga.txt b/Documentation/devicetree/bindings/panel/eukrea,mbimxsd51-dvi-svga.txt [...] > @@ -0,0 +1,7 @@ > +Eukrea DVI-SVGA (800x600 pixels) DVI output. [...] > diff --git a/Documentation/devicetree/bindings/panel/eukrea,mbimxsd51-dvi-vga.txt b/Documentation/devicetree/bindings/panel/eukrea,mbimxsd51-dvi-vga.txt [...] > @@ -0,0 +1,7 @@ > +Eukrea DVI-VGA (640x480 pixels) DVI output. DVI outputs shouldn't be using the panel framework and this binding at all. DVI usually has the means to determine all of this by itself. Why do you need to represent this as a panel in device tree? Thierry
Hi Thierry, Le Tue, 24 Jun 2014 23:49:37 +0200, Thierry Reding <thierry.reding@gmail.com> a écrit : > On Mon, Jun 16, 2014 at 12:11:22PM +0200, Denis Carikli wrote: > [...] > > diff --git a/Documentation/devicetree/bindings/panel/eukrea,mbimxsd51-dvi-svga.txt b/Documentation/devicetree/bindings/panel/eukrea,mbimxsd51-dvi-svga.txt > [...] > > @@ -0,0 +1,7 @@ > > +Eukrea DVI-SVGA (800x600 pixels) DVI output. > [...] > > diff --git a/Documentation/devicetree/bindings/panel/eukrea,mbimxsd51-dvi-vga.txt b/Documentation/devicetree/bindings/panel/eukrea,mbimxsd51-dvi-vga.txt > [...] > > @@ -0,0 +1,7 @@ > > +Eukrea DVI-VGA (640x480 pixels) DVI output. > > DVI outputs shouldn't be using the panel framework and this binding at > all. DVI usually has the means to determine all of this by itself. Why > do you need to represent this as a panel in device tree? > because on this very simple display board, we only have DVI LVDS signals without the I2C to detect the display. Best regards Eric
On Tue, Jun 24, 2014 at 02:52:11PM -0500, Rob Herring wrote: > On Tue, Jun 24, 2014 at 10:06 AM, Russell King - ARM Linux <linux@arm.linux.org.uk> wrote: [...] > > On Mon, Jun 16, 2014 at 12:11:22PM +0200, Denis Carikli wrote: [...] > >> diff --git a/Documentation/devicetree/bindings/panel/eukrea,mbimxsd51-dvi-vga.txt b/Documentation/devicetree/bindings/panel/eukrea,mbimxsd51-dvi-vga.txt [...] > >> @@ -0,0 +1,7 @@ > >> +Eukrea DVI-VGA (640x480 pixels) DVI output. > >> + > >> +Required properties: > >> +- compatible: should be "eukrea,mbimxsd51-dvi-vga" > >> + > >> +This binding is compatible with the simple-panel binding, which is specified > >> +in simple-panel.txt in this directory. > > Seems like we could just have a list of compatible strings rather than > a mostly duplicated file. We've been doing it this way for all other panels. > >> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c > >> index a251361..adc40a7 100644 > >> --- a/drivers/gpu/drm/panel/panel-simple.c > >> +++ b/drivers/gpu/drm/panel/panel-simple.c > >> @@ -403,6 +403,80 @@ static const struct panel_desc edt_etm0700g0dh6 = { > >> }, > >> }; > >> > >> +static const struct drm_display_mode eukrea_mbimxsd51_cmoqvga_mode = { > >> + .clock = 6500, > >> + .hdisplay = 320, > >> + .hsync_start = 320 + 38, > >> + .hsync_end = 320 + 38 + 20, > >> + .htotal = 320 + 38 + 20 + 30, > >> + .vdisplay = 240, > >> + .vsync_start = 240 + 15, > >> + .vsync_end = 240 + 15 + 4, > >> + .vtotal = 240 + 15 + 4 + 3, > >> + .vrefresh = 60, > >> + .pol_flags = DRM_MODE_FLAG_POL_PIXDATA_NEGEDGE | > >> + DRM_MODE_FLAG_POL_DE_LOW, > > Why aren't you using: > > Documentation/devicetree/bindings/video/display-timing.txt Because it's redundant information. We need to have a compatible for the panel in the device tree anyway and that already implicitly defines the display mode. Thierry
On Tue, Jun 24, 2014 at 11:56:39PM +0200, Eric Bénard wrote: > Hi Thierry, > > Le Tue, 24 Jun 2014 23:49:37 +0200, > Thierry Reding <thierry.reding@gmail.com> a écrit : > > > On Mon, Jun 16, 2014 at 12:11:22PM +0200, Denis Carikli wrote: > > [...] > > > diff --git a/Documentation/devicetree/bindings/panel/eukrea,mbimxsd51-dvi-svga.txt b/Documentation/devicetree/bindings/panel/eukrea,mbimxsd51-dvi-svga.txt > > [...] > > > @@ -0,0 +1,7 @@ > > > +Eukrea DVI-SVGA (800x600 pixels) DVI output. > > [...] > > > diff --git a/Documentation/devicetree/bindings/panel/eukrea,mbimxsd51-dvi-vga.txt b/Documentation/devicetree/bindings/panel/eukrea,mbimxsd51-dvi-vga.txt > > [...] > > > @@ -0,0 +1,7 @@ > > > +Eukrea DVI-VGA (640x480 pixels) DVI output. > > > > DVI outputs shouldn't be using the panel framework and this binding at > > all. DVI usually has the means to determine all of this by itself. Why > > do you need to represent this as a panel in device tree? > > > because on this very simple display board, we only have DVI LVDS signals > without the I2C to detect the display. That's unfortunate. In that case perhaps a better approach would be to add a video timings node to the device that provides the DVI output? The panel bindings are really for internal panels and should define all of their properties. That's also why they need a specific compatible string. What the above two bindings define are really "connectors" with a fixed resolution rather than panels. Thierry
On 06/25/2014 12:04 AM, Thierry Reding wrote: >> because on this very simple display board, we only have DVI LVDS signals >> without the I2C to detect the display. > > That's unfortunate. In that case perhaps a better approach would be to > add a video timings node to the device that provides the DVI output? I've just done that. Should I resend now? The goal is to avoid as much as possible extra versions. Also, as I said before in a response to "[PATCH v14 09/10] ARM: dts: mbimx51sd: Add display support.", the LCD regulator was inverted, it worked while inverted because of a bug which is now fixed by: "imx-drm: parallel-display: Fix DPMS default state." Right now, I don't have any other changes for this serie beside a simple rebase of "dts: imx5*, imx6*: correct display-timings rebased". Denis.
On 06/24/2014 05:06 PM, Russell King - ARM Linux wrote: > It would be better if you separate the > binding documentation updates from the other functional changes too. Fixed. Denis.
diff --git a/Documentation/devicetree/bindings/panel/eukrea,mbimxsd51-cmo-qvga.txt b/Documentation/devicetree/bindings/panel/eukrea,mbimxsd51-cmo-qvga.txt new file mode 100644 index 0000000..03679d0 --- /dev/null +++ b/Documentation/devicetree/bindings/panel/eukrea,mbimxsd51-cmo-qvga.txt @@ -0,0 +1,7 @@ +Eukrea CMO-QVGA (320x240 pixels) TFT LCD panel + +Required properties: +- compatible: should be "eukrea,mbimxsd51-cmo-qvga" + +This binding is compatible with the simple-panel binding, which is specified +in simple-panel.txt in this directory. diff --git a/Documentation/devicetree/bindings/panel/eukrea,mbimxsd51-dvi-svga.txt b/Documentation/devicetree/bindings/panel/eukrea,mbimxsd51-dvi-svga.txt new file mode 100644 index 0000000..f408c9a --- /dev/null +++ b/Documentation/devicetree/bindings/panel/eukrea,mbimxsd51-dvi-svga.txt @@ -0,0 +1,7 @@ +Eukrea DVI-SVGA (800x600 pixels) DVI output. + +Required properties: +- compatible: should be "eukrea,mbimxsd51-dvi-svga" + +This binding is compatible with the simple-panel binding, which is specified +in simple-panel.txt in this directory. diff --git a/Documentation/devicetree/bindings/panel/eukrea,mbimxsd51-dvi-vga.txt b/Documentation/devicetree/bindings/panel/eukrea,mbimxsd51-dvi-vga.txt new file mode 100644 index 0000000..8ea90da --- /dev/null +++ b/Documentation/devicetree/bindings/panel/eukrea,mbimxsd51-dvi-vga.txt @@ -0,0 +1,7 @@ +Eukrea DVI-VGA (640x480 pixels) DVI output. + +Required properties: +- compatible: should be "eukrea,mbimxsd51-dvi-vga" + +This binding is compatible with the simple-panel binding, which is specified +in simple-panel.txt in this directory. diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c index a251361..adc40a7 100644 --- a/drivers/gpu/drm/panel/panel-simple.c +++ b/drivers/gpu/drm/panel/panel-simple.c @@ -403,6 +403,80 @@ static const struct panel_desc edt_etm0700g0dh6 = { }, }; +static const struct drm_display_mode eukrea_mbimxsd51_cmoqvga_mode = { + .clock = 6500, + .hdisplay = 320, + .hsync_start = 320 + 38, + .hsync_end = 320 + 38 + 20, + .htotal = 320 + 38 + 20 + 30, + .vdisplay = 240, + .vsync_start = 240 + 15, + .vsync_end = 240 + 15 + 4, + .vtotal = 240 + 15 + 4 + 3, + .vrefresh = 60, + .pol_flags = DRM_MODE_FLAG_POL_PIXDATA_NEGEDGE | + DRM_MODE_FLAG_POL_DE_LOW, +}; + +static const struct panel_desc eukrea_mbimxsd51_cmoqvga = { + .modes = &eukrea_mbimxsd51_cmoqvga_mode, + .num_modes = 1, + .size = { + .width = 73, + .height = 56, + }, +}; + +static const struct drm_display_mode eukrea_mbimxsd51_dvisvga_mode = { + .clock = 44333, + .hdisplay = 800, + .hsync_start = 800 + 112, + .hsync_end = 800 + 112 + 32, + .htotal = 800 + 112 + 32 + 80, + .vdisplay = 600, + .vsync_start = 600 + 3, + .vsync_end = 600 + 3 + 17, + .vtotal = 600 + 3 + 17 + 4, + .vrefresh = 60, + .pol_flags = DRM_MODE_FLAG_POL_PIXDATA_POSEDGE | + DRM_MODE_FLAG_POL_DE_HIGH, +}; + +static const struct panel_desc eukrea_mbimxsd51_dvisvga = { + .modes = &eukrea_mbimxsd51_dvisvga_mode, + .num_modes = 1, + /* This is a DVI adapter for external displays */ + .size = { + .width = 0, + .height = 0, + }, +}; + +static const struct drm_display_mode eukrea_mbimxsd51_dvivga_mode = { + .clock = 23750, + .hdisplay = 640, + .hsync_start = 640 + 80, + .hsync_end = 640 + 80 + 16, + .htotal = 640 + 80 + 16 + 64, + .vdisplay = 480, + .vsync_start = 480 + 3, + .vsync_end = 480 + 3 + 13, + .vtotal = 480 + 3 + 13 + 4, + .vrefresh = 60, + .pol_flags = DRM_MODE_FLAG_POL_PIXDATA_POSEDGE | + DRM_MODE_FLAG_POL_DE_HIGH, +}; + +static const struct panel_desc eukrea_mbimxsd51_dvivga = { + .modes = &eukrea_mbimxsd51_dvivga_mode, + .num_modes = 1, + /* This is a DVI adapter for external displays */ + .size = { + .width = 0, + .height = 0, + }, +}; + static const struct drm_display_mode lg_lp129qe_mode = { .clock = 285250, .hdisplay = 2560, @@ -458,6 +532,15 @@ static const struct of_device_id platform_of_match[] = { .compatible = "chunghwa,claa101wa01a", .data = &chunghwa_claa101wa01a }, { + .compatible = "eukrea,mbimxsd51-cmo-qvga", + .data = &eukrea_mbimxsd51_cmoqvga, + }, { + .compatible = "eukrea,mbimxsd51-dvi-svga", + .data = &eukrea_mbimxsd51_dvisvga, + }, { + .compatible = "eukrea,mbimxsd51-dvi-vga", + .data = &eukrea_mbimxsd51_dvivga, + }, { .compatible = "chunghwa,claa101wb01", .data = &chunghwa_claa101wb01 }, {
Signed-off-by: Denis Carikli <denis@eukrea.com> --- ChangeLog v13->v14: - None ChangeLog v12->v13: - Added a note explaining why the size is zero in the eukrea_mbimxsd51_dvi(s)vga structs. ChangeLog v11->v12: - Rebased: It now uses the new DRM_MODE_FLAG_POL_DE flags defines names ChangeLog v10->v11: - New patch. --- .../bindings/panel/eukrea,mbimxsd51-cmo-qvga.txt | 7 ++ .../bindings/panel/eukrea,mbimxsd51-dvi-svga.txt | 7 ++ .../bindings/panel/eukrea,mbimxsd51-dvi-vga.txt | 7 ++ drivers/gpu/drm/panel/panel-simple.c | 83 ++++++++++++++++++++ 4 files changed, 104 insertions(+) create mode 100644 Documentation/devicetree/bindings/panel/eukrea,mbimxsd51-cmo-qvga.txt create mode 100644 Documentation/devicetree/bindings/panel/eukrea,mbimxsd51-dvi-svga.txt create mode 100644 Documentation/devicetree/bindings/panel/eukrea,mbimxsd51-dvi-vga.txt