| Message ID | 1403794923-19511-1-git-send-email-guido@vanguardiasur.com.ar (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 26 Jun 12:02 PM, Guido Martínez wrote: > Currently, child nodes of the gpmc node are iterated and probed > regardless of their 'status' property. This means adding 'status = > "disabled";' has no effect. > > This patch changes the iteration to only probe nodes marked as > available. > > Signed-off-by: Guido Martínez <guido@vanguardiasur.com.ar> Just a nit: the commit title doesn't match the recent commits. If you run "git log" on this file, you'll find the pattern should be something like: "ARM: OMAP2+: GPMC should only probe enabled devices" Other than this, the patch looks correct. Thanks,
>From: Ezequiel García [mailto:ezequiel@vanguardiasur.com.ar] >>On 26 Jun 12:02 PM, Guido Martínez wrote: >> Currently, child nodes of the gpmc node are iterated and probed >> regardless of their 'status' property. This means adding 'status = >> "disabled";' has no effect. >> >> This patch changes the iteration to only probe nodes marked as >> available. >> >> Signed-off-by: Guido Martínez <guido@vanguardiasur.com.ar> > >Just a nit: the commit title doesn't match the recent commits. If you >run "git log" on this file, you'll find the pattern should be something >like: > >"ARM: OMAP2+: GPMC should only probe enabled devices" > >Other than this, the patch looks correct. > Yes, plz keep patch title consistent as in other gpmc.c patches. And thanks for this fix. Tested-by: Pekon Gupta <pekon@ti.com> with regards, pekon -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm/mach-omap2/gpmc.c b/arch/arm/mach-omap2/gpmc.c index 2c0c281..8bc1338 100644 --- a/arch/arm/mach-omap2/gpmc.c +++ b/arch/arm/mach-omap2/gpmc.c @@ -1615,7 +1615,7 @@ static int gpmc_probe_dt(struct platform_device *pdev) return ret; } - for_each_child_of_node(pdev->dev.of_node, child) { + for_each_available_child_of_node(pdev->dev.of_node, child) { if (!child->name) continue;
Currently, child nodes of the gpmc node are iterated and probed regardless of their 'status' property. This means adding 'status = "disabled";' has no effect. This patch changes the iteration to only probe nodes marked as available. Signed-off-by: Guido Martínez <guido@vanguardiasur.com.ar> --- arch/arm/mach-omap2/gpmc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)