| Message ID | 1404373939-10510-1-git-send-email-cw00.choi@samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Chanwoo Choi wrote: > > From: Tomasz Figa <t.figa@samsung.com> > > This patch add I2S (Inter-IC Sound) dt node which supports 1-port stereo > (1 channels) IIS-bus for audio interface with DMA-based operation. > > Signed-off-by: Tomasz Figa <t.figa@samsung.com> > Signed-off-by: Inha Song <ideal.song@samsung.com> > Tested-by: Inha Song <ideal.song@samsung.com> > Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com> > Acked-by: Kyungmin Park <kyungmin.park@samsung.com> > --- > arch/arm/boot/dts/exynos3250.dtsi | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/arch/arm/boot/dts/exynos3250.dtsi b/arch/arm/boot/dts/exynos3250.dtsi > index 1f8384f..e9017ef 100644 > --- a/arch/arm/boot/dts/exynos3250.dtsi > +++ b/arch/arm/boot/dts/exynos3250.dtsi > @@ -644,6 +644,19 @@ > status = "disabled"; > }; > > + i2s: i2s@13970000 { > + compatible = "samsung,s3c6410-i2s"; > + reg = <0x13970000 0x100>; > + interrupts = <0 126 0>; > + clocks = <&cmu CLK_I2S>, <&cmu CLK_SCLK_I2S>; > + clock-names = "iis", "i2s_opclk0"; > + dmas = <&pdma0 14>, <&pdma0 13>; > + dma-names = "tx", "rx"; > + pinctrl-0 = <&i2s2_bus>; > + pinctrl-name = "default"; To put 'pinctrl-name' and then 'pinctrl-0' is better? :-) > + status = "disabled"; > + }; > + > pwm: pwm@139D0000 { > compatible = "samsung,exynos4210-pwm"; > reg = <0x139D0000 0x1000>; > -- > 1.8.0 Will apply. Thanks, Kukjin
On 07/04/2014 04:43 PM, Kukjin Kim wrote: > Chanwoo Choi wrote: >> >> From: Tomasz Figa <t.figa@samsung.com> >> >> This patch add I2S (Inter-IC Sound) dt node which supports 1-port stereo >> (1 channels) IIS-bus for audio interface with DMA-based operation. >> >> Signed-off-by: Tomasz Figa <t.figa@samsung.com> >> Signed-off-by: Inha Song <ideal.song@samsung.com> >> Tested-by: Inha Song <ideal.song@samsung.com> >> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com> >> Acked-by: Kyungmin Park <kyungmin.park@samsung.com> >> --- >> arch/arm/boot/dts/exynos3250.dtsi | 13 +++++++++++++ >> 1 file changed, 13 insertions(+) >> >> diff --git a/arch/arm/boot/dts/exynos3250.dtsi b/arch/arm/boot/dts/exynos3250.dtsi >> index 1f8384f..e9017ef 100644 >> --- a/arch/arm/boot/dts/exynos3250.dtsi >> +++ b/arch/arm/boot/dts/exynos3250.dtsi >> @@ -644,6 +644,19 @@ >> status = "disabled"; >> }; >> >> + i2s: i2s@13970000 { >> + compatible = "samsung,s3c6410-i2s"; >> + reg = <0x13970000 0x100>; >> + interrupts = <0 126 0>; >> + clocks = <&cmu CLK_I2S>, <&cmu CLK_SCLK_I2S>; >> + clock-names = "iis", "i2s_opclk0"; >> + dmas = <&pdma0 14>, <&pdma0 13>; >> + dma-names = "tx", "rx"; >> + pinctrl-0 = <&i2s2_bus>; >> + pinctrl-name = "default"; > > To put 'pinctrl-name' and then 'pinctrl-0' is better? :-) The i2s dt node can drop "pinctrl-0/pinctrl-name" properties. I will re-send this patchset (v2) after fixing it. Best Regards, Chanwoo Choi
Hi Chanwoo, On 03.07.2014 09:52, Chanwoo Choi wrote: > From: Tomasz Figa <t.figa@samsung.com> > > This patch add I2S (Inter-IC Sound) dt node which supports 1-port stereo > (1 channels) IIS-bus for audio interface with DMA-based operation. > > Signed-off-by: Tomasz Figa <t.figa@samsung.com> > Signed-off-by: Inha Song <ideal.song@samsung.com> > Tested-by: Inha Song <ideal.song@samsung.com> > Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com> > Acked-by: Kyungmin Park <kyungmin.park@samsung.com> > --- > arch/arm/boot/dts/exynos3250.dtsi | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/arch/arm/boot/dts/exynos3250.dtsi b/arch/arm/boot/dts/exynos3250.dtsi > index 1f8384f..e9017ef 100644 > --- a/arch/arm/boot/dts/exynos3250.dtsi > +++ b/arch/arm/boot/dts/exynos3250.dtsi > @@ -644,6 +644,19 @@ > status = "disabled"; > }; > > + i2s: i2s@13970000 { Shouldn't the label be rather called "i2s2" as the pinctrl entry below suggests? > + compatible = "samsung,s3c6410-i2s"; > + reg = <0x13970000 0x100>; > + interrupts = <0 126 0>; > + clocks = <&cmu CLK_I2S>, <&cmu CLK_SCLK_I2S>; > + clock-names = "iis", "i2s_opclk0"; > + dmas = <&pdma0 14>, <&pdma0 13>; > + dma-names = "tx", "rx"; > + pinctrl-0 = <&i2s2_bus>; > + pinctrl-name = "default"; "pinctrl-name" is not a valid property. I suppose it should be "pinctrl-names". Best regards, Tomasz
diff --git a/arch/arm/boot/dts/exynos3250.dtsi b/arch/arm/boot/dts/exynos3250.dtsi index 1f8384f..e9017ef 100644 --- a/arch/arm/boot/dts/exynos3250.dtsi +++ b/arch/arm/boot/dts/exynos3250.dtsi @@ -644,6 +644,19 @@ status = "disabled"; }; + i2s: i2s@13970000 { + compatible = "samsung,s3c6410-i2s"; + reg = <0x13970000 0x100>; + interrupts = <0 126 0>; + clocks = <&cmu CLK_I2S>, <&cmu CLK_SCLK_I2S>; + clock-names = "iis", "i2s_opclk0"; + dmas = <&pdma0 14>, <&pdma0 13>; + dma-names = "tx", "rx"; + pinctrl-0 = <&i2s2_bus>; + pinctrl-name = "default"; + status = "disabled"; + }; + pwm: pwm@139D0000 { compatible = "samsung,exynos4210-pwm"; reg = <0x139D0000 0x1000>;