| Message ID | 1403783163-28638-1-git-send-email-k.kozlowski@samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Krzysztof, On Thu, Jun 26, 2014 at 5:16 PM, Krzysztof Kozlowski <k.kozlowski@samsung.com> wrote: > Commit b3205dea8fbf ("ARM: EXYNOS: Map SYSRAM through generic DT > bindings") introduced local variable boot_reg where boot address from > cpu_boot_reg() call is stored. Re-use it instead calling cpu_boot_reg() > again. > > Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> > --- Thanks for the patch. Reviewed-by: Sachin Kamat <sachin.kamat@samsung.com> Regards, Sachin. -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Krzysztof Kozlowski wrote: > > Commit b3205dea8fbf ("ARM: EXYNOS: Map SYSRAM through generic DT > bindings") introduced local variable boot_reg where boot address from > cpu_boot_reg() call is stored. Re-use it instead calling cpu_boot_reg() > again. > > Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> > --- > arch/arm/mach-exynos/platsmp.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/mach-exynos/platsmp.c b/arch/arm/mach-exynos/platsmp.c > index 1c8d31e39520..55ed2e6729c5 100644 > --- a/arch/arm/mach-exynos/platsmp.c > +++ b/arch/arm/mach-exynos/platsmp.c > @@ -155,7 +155,7 @@ static int exynos_boot_secondary(unsigned int cpu, struct task_struct *idle) > ret = PTR_ERR(boot_reg); > goto fail; > } > - __raw_writel(boot_addr, cpu_boot_reg(phys_cpu)); > + __raw_writel(boot_addr, boot_reg); > } > > call_firmware_op(cpu_boot, phys_cpu); > @@ -242,7 +242,7 @@ static void __init exynos_smp_prepare_cpus(unsigned int max_cpus) > > if (IS_ERR(boot_reg)) > break; > - __raw_writel(boot_addr, cpu_boot_reg(phys_cpu)); > + __raw_writel(boot_addr, boot_reg); > } > } > } > -- > 1.9.1 Oh, good catch. will apply :-) Thanks, Kukjin -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On pi?, 2014-07-04 at 17:41 +0900, Kukjin Kim wrote: > Krzysztof Kozlowski wrote: > > > > Commit b3205dea8fbf ("ARM: EXYNOS: Map SYSRAM through generic DT > > bindings") introduced local variable boot_reg where boot address from > > cpu_boot_reg() call is stored. Re-use it instead calling cpu_boot_reg() > > again. > > > > Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> > > --- > > arch/arm/mach-exynos/platsmp.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/arch/arm/mach-exynos/platsmp.c b/arch/arm/mach-exynos/platsmp.c > > index 1c8d31e39520..55ed2e6729c5 100644 > > --- a/arch/arm/mach-exynos/platsmp.c > > +++ b/arch/arm/mach-exynos/platsmp.c > > @@ -155,7 +155,7 @@ static int exynos_boot_secondary(unsigned int cpu, struct task_struct *idle) > > ret = PTR_ERR(boot_reg); > > goto fail; > > } > > - __raw_writel(boot_addr, cpu_boot_reg(phys_cpu)); > > + __raw_writel(boot_addr, boot_reg); > > } > > > > call_firmware_op(cpu_boot, phys_cpu); > > @@ -242,7 +242,7 @@ static void __init exynos_smp_prepare_cpus(unsigned int max_cpus) > > > > if (IS_ERR(boot_reg)) > > break; > > - __raw_writel(boot_addr, cpu_boot_reg(phys_cpu)); > > + __raw_writel(boot_addr, boot_reg); > > } > > } > > } > > -- > > 1.9.1 > > Oh, good catch. will apply :-) Hi Kukjin, I cannot find this patch in your tree or in next. Did you applied this? Best regards, Krzysztof > Thanks, > Kukjin -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm/mach-exynos/platsmp.c b/arch/arm/mach-exynos/platsmp.c index 1c8d31e39520..55ed2e6729c5 100644 --- a/arch/arm/mach-exynos/platsmp.c +++ b/arch/arm/mach-exynos/platsmp.c @@ -155,7 +155,7 @@ static int exynos_boot_secondary(unsigned int cpu, struct task_struct *idle) ret = PTR_ERR(boot_reg); goto fail; } - __raw_writel(boot_addr, cpu_boot_reg(phys_cpu)); + __raw_writel(boot_addr, boot_reg); } call_firmware_op(cpu_boot, phys_cpu); @@ -242,7 +242,7 @@ static void __init exynos_smp_prepare_cpus(unsigned int max_cpus) if (IS_ERR(boot_reg)) break; - __raw_writel(boot_addr, cpu_boot_reg(phys_cpu)); + __raw_writel(boot_addr, boot_reg); } } }
Commit b3205dea8fbf ("ARM: EXYNOS: Map SYSRAM through generic DT bindings") introduced local variable boot_reg where boot address from cpu_boot_reg() call is stored. Re-use it instead calling cpu_boot_reg() again. Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> --- arch/arm/mach-exynos/platsmp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)