| Message ID | 1404530457-4739-1-git-send-email-xerofoify@gmail.com (mailing list archive) |
|---|---|
| State | Rejected |
| Headers | show |
On Fri, 2014-07-04 at 23:20 -0400, Nicholas Krause wrote: > This removes the sizeof(frame) from the call to get_sigframe on line > 243 in order to fix the call to this function as the sizeof in not > needed to call this function. How did you compile this? arch/parisc/kernel/signal.c:178:get_sigframe(struct k_sigaction *ka, unsigned long sp, size_t frame_size) > diff --git a/arch/parisc/kernel/signal.c b/arch/parisc/kernel/signal.c [] > @@ -240,8 +240,7 @@ setup_rt_frame(int sig, struct k_sigaction *ka, siginfo_t *info, [] > - /*FIXME: frame_size parameter is unused, remove it. */ > - frame = get_sigframe(ka, usp, sizeof(*frame)); > + frame = get_sigframe(ka, usp) Nichola -- To unsubscribe from this list: send the line "unsubscribe linux-parisc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
I didn't compile check it seems to be a valid line after reading this. I will resend a new patch removing the FIX ME line. Sorry Nick On Fri, Jul 4, 2014 at 11:58 PM, Joe Perches <joe@perches.com> wrote: > On Fri, 2014-07-04 at 23:20 -0400, Nicholas Krause wrote: >> This removes the sizeof(frame) from the call to get_sigframe on line >> 243 in order to fix the call to this function as the sizeof in not >> needed to call this function. > > How did you compile this? > > arch/parisc/kernel/signal.c:178:get_sigframe(struct k_sigaction *ka, unsigned long sp, size_t frame_size) > >> diff --git a/arch/parisc/kernel/signal.c b/arch/parisc/kernel/signal.c > [] >> @@ -240,8 +240,7 @@ setup_rt_frame(int sig, struct k_sigaction *ka, siginfo_t *info, > [] >> - /*FIXME: frame_size parameter is unused, remove it. */ >> - frame = get_sigframe(ka, usp, sizeof(*frame)); >> + frame = get_sigframe(ka, usp) > > Nichola > -- To unsubscribe from this list: send the line "unsubscribe linux-parisc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, 4 Jul 2014 23:20:57 -0400 Nicholas Krause <xerofoify@gmail.com> wrote: > This removes the sizeof(frame) from the call to get_sigframe on line > 243 in order to fix the call to this function as the sizeof in not > needed to call this function. If you are going to submit patches then - actually read what you are submitting - check it actually compiles - run it on the system in question and verify your changed code paths are used *then* consider submitting it, otherwise all you are doing is wasting people's time. Alan -- To unsubscribe from this list: send the line "unsubscribe linux-parisc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, 7 Jul 2014, One Thousand Gnomes wrote: > > This removes the sizeof(frame) from the call to get_sigframe on line > > 243 in order to fix the call to this function as the sizeof in not > > needed to call this function. > > If you are going to submit patches then > > - actually read what you are submitting > > - check it actually compiles > > - run it on the system in question and verify your changed code paths are > used > > *then* consider submitting it, otherwise all you are doing is wasting > people's time. Seconded. Nicholas, this is a third time I've seen patch from you in my mailbox that didn't make any sense whatsoever. Please be more careful, once certain reputation is gained, it's very difficult to escape it.
diff --git a/arch/parisc/kernel/signal.c b/arch/parisc/kernel/signal.c index 1cba8f2..3b7caac 100644 --- a/arch/parisc/kernel/signal.c +++ b/arch/parisc/kernel/signal.c @@ -240,8 +240,7 @@ setup_rt_frame(int sig, struct k_sigaction *ka, siginfo_t *info, #endif usp = (regs->gr[30] & ~(0x01UL)); - /*FIXME: frame_size parameter is unused, remove it. */ - frame = get_sigframe(ka, usp, sizeof(*frame)); + frame = get_sigframe(ka, usp) DBG(1,"SETUP_RT_FRAME: START\n"); DBG(1,"setup_rt_frame: frame %p info %p\n", frame, info);
This removes the sizeof(frame) from the call to get_sigframe on line 243 in order to fix the call to this function as the sizeof in not needed to call this function. Signed-off-by: Nicholas Krause <xerofoify@gmail.com> --- arch/parisc/kernel/signal.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)