diff mbox

[3/7] ASoC: Intel: mrlfd - add generic parameter interface

Message ID 1404898076-1882-4-git-send-email-vinod.koul@intel.com (mailing list archive)
State Accepted
Commit e310fb9141436672db680923228fba5aab206062
Headers show

Commit Message

Vinod Koul July 9, 2014, 9:27 a.m. UTC 
This interface will be used by subsequent patches to set/get parameters from DSP

Signed-off-by: Vinod Koul <vinod.koul@intel.com>
---
 sound/soc/intel/sst-mfld-platform.h |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)

Comments

Mark Brown July 14, 2014, 6:46 p.m. UTC | #1 
On Wed, Jul 09, 2014 at 02:57:51PM +0530, Vinod Koul wrote:
> This interface will be used by subsequent patches to set/get parameters from DSP

Applied, thanks.  Please try to keep your subject lines consistent and
word wrap your changelogs a bit more (they look like they go to exactly
80 columns which isn't good for replying).
Vinod Koul July 15, 2014, 5:25 a.m. UTC | #2 
On Mon, Jul 14, 2014 at 07:46:32PM +0100, Mark Brown wrote:
> On Wed, Jul 09, 2014 at 02:57:51PM +0530, Vinod Koul wrote:
> > This interface will be used by subsequent patches to set/get parameters from DSP
> 
> Applied, thanks.  Please try to keep your subject lines consistent and
> word wrap your changelogs a bit more (they look like they go to exactly
> 80 columns which isn't good for replying).
Yes set it to 80, i agree it cause issues while replying. What do you set, 76??
Mark Brown July 15, 2014, 12:38 p.m. UTC | #3 
On Tue, Jul 15, 2014 at 10:55:55AM +0530, Vinod Koul wrote:
> On Mon, Jul 14, 2014 at 07:46:32PM +0100, Mark Brown wrote:

> > Applied, thanks.  Please try to keep your subject lines consistent and
> > word wrap your changelogs a bit more (they look like they go to exactly
> > 80 columns which isn't good for replying).

> Yes set it to 80, i agree it cause issues while replying. What do you set, 76??

Something like that (I actually do it by eye a lot of the time).
diff mbox

Patch

diff --git a/sound/soc/intel/sst-mfld-platform.h b/sound/soc/intel/sst-mfld-platform.h
index 9dc962f..6c6a42c 100644
--- a/sound/soc/intel/sst-mfld-platform.h
+++ b/sound/soc/intel/sst-mfld-platform.h
@@ -63,7 +63,9 @@  enum sst_controls {
 	SST_SND_BUFFER_POINTER =	0x05,
 	SST_SND_STREAM_INIT =		0x06,
 	SST_SND_START	 =		0x07,
-	SST_MAX_CONTROLS =		0x07,
+	SST_SET_BYTE_STREAM =           0x100A,
+	SST_GET_BYTE_STREAM =           0x100B,
+	SST_MAX_CONTROLS = SST_GET_BYTE_STREAM,
 };
 
 enum sst_stream_ops {
@@ -127,6 +129,7 @@  struct compress_sst_ops {
 struct sst_ops {
 	int (*open) (struct snd_sst_params *str_param);
 	int (*device_control) (int cmd, void *arg);
+	int (*set_generic_params)(enum sst_controls cmd, void *arg);
 	int (*close) (unsigned int str_id);
 };