| Message ID | 1405087464-13762-5-git-send-email-j.anaszewski@samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Jacek, Jacek Anaszewski wrote: > Reorder include directives so that they are arranged > in alphabetical order. > > Signed-off-by: Jacek Anaszewski <j.anaszewski@samsung.com> > Acked-by: Kyungmin Park <kyungmin.park@samsung.com> > Cc: Bryan Wu <cooloney@gmail.com> > Cc: Richard Purdie <rpurdie@rpsys.net> > --- > drivers/leds/led-class.c | 13 +++++++------ > drivers/leds/led-core.c | 3 ++- > include/linux/leds.h | 2 +- > 3 files changed, 10 insertions(+), 8 deletions(-) > > diff --git a/drivers/leds/led-class.c b/drivers/leds/led-class.c > index da79bbb..0127783 100644 > --- a/drivers/leds/led-class.c > +++ b/drivers/leds/led-class.c > @@ -9,16 +9,17 @@ > * published by the Free Software Foundation. > */ > > -#include <linux/module.h> > -#include <linux/kernel.h> > +#include <linux/ctype.h> > +#include <linux/device.h> > +#include <linux/err.h> > #include <linux/init.h> > +#include <linux/kernel.h> > +#include <linux/leds.h> > #include <linux/list.h> > +#include <linux/module.h> > +#include <linux/slab.h> Do you also need slab.h? > #include <linux/spinlock.h> > -#include <linux/device.h> > #include <linux/timer.h> > -#include <linux/err.h> > -#include <linux/ctype.h> > -#include <linux/leds.h> > #include "leds.h" > > static struct class *leds_class; > diff --git a/drivers/leds/led-core.c b/drivers/leds/led-core.c > index 0ac06ed..d156fb6 100644 > --- a/drivers/leds/led-core.c > +++ b/drivers/leds/led-core.c > @@ -12,10 +12,11 @@ > */ > > #include <linux/kernel.h> > +#include <linux/leds.h> > #include <linux/list.h> > #include <linux/module.h> > +#include <linux/mutex.h> And mutex.h here? With that fixed, if there are some other patches that are essentially cleanups that could go in well before the rest of the set. Some of the patches will take a little longer, I presume. I'll let you know if/when there's an update regarding the compound controls patchset.
diff --git a/drivers/leds/led-class.c b/drivers/leds/led-class.c index da79bbb..0127783 100644 --- a/drivers/leds/led-class.c +++ b/drivers/leds/led-class.c @@ -9,16 +9,17 @@ * published by the Free Software Foundation. */ -#include <linux/module.h> -#include <linux/kernel.h> +#include <linux/ctype.h> +#include <linux/device.h> +#include <linux/err.h> #include <linux/init.h> +#include <linux/kernel.h> +#include <linux/leds.h> #include <linux/list.h> +#include <linux/module.h> +#include <linux/slab.h> #include <linux/spinlock.h> -#include <linux/device.h> #include <linux/timer.h> -#include <linux/err.h> -#include <linux/ctype.h> -#include <linux/leds.h> #include "leds.h" static struct class *leds_class; diff --git a/drivers/leds/led-core.c b/drivers/leds/led-core.c index 0ac06ed..d156fb6 100644 --- a/drivers/leds/led-core.c +++ b/drivers/leds/led-core.c @@ -12,10 +12,11 @@ */ #include <linux/kernel.h> +#include <linux/leds.h> #include <linux/list.h> #include <linux/module.h> +#include <linux/mutex.h> #include <linux/rwsem.h> -#include <linux/leds.h> #include "leds.h" DECLARE_RWSEM(leds_list_lock); diff --git a/include/linux/leds.h b/include/linux/leds.h index e9b025d..1a130cc 100644 --- a/include/linux/leds.h +++ b/include/linux/leds.h @@ -14,8 +14,8 @@ #include <linux/list.h> #include <linux/mutex.h> -#include <linux/spinlock.h> #include <linux/rwsem.h> +#include <linux/spinlock.h> #include <linux/timer.h> #include <linux/workqueue.h>