| Message ID | 1405411346-12471-1-git-send-email-ch.naveen@samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hello All, On 15 July 2014 13:32, Naveen Krishna Chatradhi <ch.naveen@samsung.com> wrote: > Enabled S3C24XX I2C driver and MAX77686 PMIC MFD and Voltage > regulator drivers used on Exynos5250 based Snow board. > > Signed-off-by: Naveen Krishna Chatradhi <ch.naveen@samsung.com> > --- > By enabling the symbols to compile S3C24XX I2C driver, MAX77686 PMIC > under MFD and REGULATOR. > > http://arm-soc.lixom.net/bootlogs/next/next-20140711/snow-multi_v7_defconfig.html > The warnings by cpufreq on Snow board are fixed. > > Booted and verified on on Exynos5420 based Snow board * Exynos5250 based Snow board. > > arch/arm/configs/multi_v7_defconfig | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig > index 5348364..1aaf91d 100644 > --- a/arch/arm/configs/multi_v7_defconfig > +++ b/arch/arm/configs/multi_v7_defconfig > @@ -193,6 +193,7 @@ CONFIG_I2C_CADENCE=y > CONFIG_I2C_DESIGNWARE_PLATFORM=y > CONFIG_I2C_EXYNOS5=y > CONFIG_I2C_MV64XXX=y > +CONFIG_I2C_S3C2410=y > CONFIG_I2C_SIRF=y > CONFIG_I2C_TEGRA=y > CONFIG_SPI=y > @@ -231,6 +232,7 @@ CONFIG_MFD_AS3722=y > CONFIG_MFD_BCM590XX=y > CONFIG_MFD_CROS_EC=y > CONFIG_MFD_CROS_EC_SPI=y > +CONFIG_MFD_MAX77686=y > CONFIG_MFD_MAX8907=y > CONFIG_MFD_SEC_CORE=y > CONFIG_MFD_PALMAS=y > @@ -243,6 +245,7 @@ CONFIG_REGULATOR_AS3722=y > CONFIG_REGULATOR_BCM590XX=y > CONFIG_REGULATOR_GPIO=y > CONFIG_REGULATOR_MAX8907=y > +CONFIG_REGULATOR_MAX77686=y > CONFIG_REGULATOR_PALMAS=y > CONFIG_REGULATOR_S2MPS11=y > CONFIG_REGULATOR_S5M8767=y > -- > 1.7.9.5 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
Naveen, On Tue, Jul 15, 2014 at 1:02 AM, Naveen Krishna Chatradhi <ch.naveen@samsung.com> wrote: > Enabled S3C24XX I2C driver and MAX77686 PMIC MFD and Voltage > regulator drivers used on Exynos5250 based Snow board. > > Signed-off-by: Naveen Krishna Chatradhi <ch.naveen@samsung.com> > --- > By enabling the symbols to compile S3C24XX I2C driver, MAX77686 PMIC > under MFD and REGULATOR. > > http://arm-soc.lixom.net/bootlogs/next/next-20140711/snow-multi_v7_defconfig.html > The warnings by cpufreq on Snow board are fixed. > > Booted and verified on on Exynos5420 based Snow board > > arch/arm/configs/multi_v7_defconfig | 3 +++ > 1 file changed, 3 insertions(+) Is there a reason not to add more of the max77686 configs? +CONFIG_RTC_DRV_MAX77686=y +CONFIG_COMMON_CLK_MAX77686=y I also seems like it would be nice to reconcile this with Sacin's latest patch. For starters I notice that you're missing: CONFIG_EXYNOS5420_MCPM=y I'll leave it up to you to look for other things that might be missing. If some of the things in exynos5_defconfig can't go into the multi-config, please explain. -Doug -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Doug, On Tue, Jul 15, 2014 at 9:29 PM, Doug Anderson <dianders@chromium.org> wrote: > Naveen, > > On Tue, Jul 15, 2014 at 1:02 AM, Naveen Krishna Chatradhi > <ch.naveen@samsung.com> wrote: >> Enabled S3C24XX I2C driver and MAX77686 PMIC MFD and Voltage >> regulator drivers used on Exynos5250 based Snow board. >> >> Signed-off-by: Naveen Krishna Chatradhi <ch.naveen@samsung.com> >> --- >> By enabling the symbols to compile S3C24XX I2C driver, MAX77686 PMIC >> under MFD and REGULATOR. >> >> http://arm-soc.lixom.net/bootlogs/next/next-20140711/snow-multi_v7_defconfig.html >> The warnings by cpufreq on Snow board are fixed. >> >> Booted and verified on on Exynos5420 based Snow board >> >> arch/arm/configs/multi_v7_defconfig | 3 +++ >> 1 file changed, 3 insertions(+) > > Is there a reason not to add more of the max77686 configs? > > +CONFIG_RTC_DRV_MAX77686=y > +CONFIG_COMMON_CLK_MAX77686=y > > I also seems like it would be nice to reconcile this with Sacin's > latest patch. For starters I notice that you're missing: > CONFIG_EXYNOS5420_MCPM=y > > I'll leave it up to you to look for other things that might be > missing. If some of the things in exynos5_defconfig can't go into the > multi-config, please explain. multi_v7_defconfig update patch, inline with exynos_defconfig is already on my TODO list. I wanted to send this one along with the next update of exynos_defconfig (around -rc7) as Olof preferred to have a single patch updating most of the available things. By then I believe remaining drivers like 5420/5800 regulators, display and cpufreq drivers would have been merged. -- Regards, Sachin. -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hello Doug On 15 July 2014 21:29, Doug Anderson <dianders@chromium.org> wrote: > Naveen, > > On Tue, Jul 15, 2014 at 1:02 AM, Naveen Krishna Chatradhi > <ch.naveen@samsung.com> wrote: >> Enabled S3C24XX I2C driver and MAX77686 PMIC MFD and Voltage >> regulator drivers used on Exynos5250 based Snow board. >> >> Signed-off-by: Naveen Krishna Chatradhi <ch.naveen@samsung.com> >> --- >> By enabling the symbols to compile S3C24XX I2C driver, MAX77686 PMIC >> under MFD and REGULATOR. >> >> http://arm-soc.lixom.net/bootlogs/next/next-20140711/snow-multi_v7_defconfig.html >> The warnings by cpufreq on Snow board are fixed. >> >> Booted and verified on on Exynos5420 based Snow board >> >> arch/arm/configs/multi_v7_defconfig | 3 +++ >> 1 file changed, 3 insertions(+) > > Is there a reason not to add more of the max77686 configs? I was trying to address the warnings posted @ http://arm-soc.lixom.net/bootlogs/next/next-20140711/snow-multi_v7_defconfig.html > > +CONFIG_RTC_DRV_MAX77686=y > +CONFIG_COMMON_CLK_MAX77686=y > > I also seems like it would be nice to reconcile this with Sacin's > latest patch. For starters I notice that you're missing: > CONFIG_EXYNOS5420_MCPM=y Right > > I'll leave it up to you to look for other things that might be > missing. If some of the things in exynos5_defconfig can't go into the > multi-config, please explain. Will try to bring the symbols from Sachin's patch for exynos_defconfig to multi_v7_defconfig. > > -Doug > -- > To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
Hello, On Tue, Jul 15, 2014 at 5:59 PM, Doug Anderson <dianders@chromium.org> wrote: > > Is there a reason not to add more of the max77686 configs? > > +CONFIG_RTC_DRV_MAX77686=y > +CONFIG_COMMON_CLK_MAX77686=y AFAIK for the multi-platform defconfig we should try to build as a module as many config options as possible to keep the kernel binary size to a minimum. In the case of the MAX77686, the mfd, regulator and clock drivers use subsys_initcall() instead of module_init() but I wonder which of these really need to be initialized at subsys init call time and which one can just be built as a module. The only MAX77686 driver that uses module_platform_driver() so it's initialized at device initcall time is the rtc-max77686 driver which ironically is the only MAX77686 driver that doesn't define a MODULE_DEVICE_TABLE() so the module won't be autoloaded. Best regards, Javier -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, Jul 18, 2014 at 12:31:48AM +0200, Javier Martinez Canillas wrote: > In the case of the MAX77686, the mfd, regulator and clock drivers use > subsys_initcall() instead of module_init() but I wonder which of these > really need to be initialized at subsys init call time and which one > can just be built as a module. I think you're making a frequently made mistake concerning module initialisation. Having code initialised by subsys_initcall() (or indeed any other level) does not preclude it being a module: #ifndef MODULE ... #define subsys_initcall(fn) __define_initcall(fn, 4) ... #else /* MODULE */ ... #define subsys_initcall(fn) module_init(fn) ... #endif So, subsys_initcall() automagically becomes module_init() when built as a module. There's no need to change anything here.
Hello Russell, On Fri, Jul 18, 2014 at 12:44 AM, Russell King - ARM Linux <linux@arm.linux.org.uk> wrote: > On Fri, Jul 18, 2014 at 12:31:48AM +0200, Javier Martinez Canillas wrote: >> In the case of the MAX77686, the mfd, regulator and clock drivers use >> subsys_initcall() instead of module_init() but I wonder which of these >> really need to be initialized at subsys init call time and which one >> can just be built as a module. > > I think you're making a frequently made mistake concerning module > initialisation. > > Having code initialised by subsys_initcall() (or indeed any other level) > does not preclude it being a module: > > #ifndef MODULE > ... > #define subsys_initcall(fn) __define_initcall(fn, 4) > ... > #else /* MODULE */ > ... > #define subsys_initcall(fn) module_init(fn) > ... > #endif > > So, subsys_initcall() automagically becomes module_init() when built > as a module. There's no need to change anything here. > I was indeed confused, I should had looked at include/linux/init.h before. Thanks a lot for the clarification. Best regards, Javier -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig index 5348364..1aaf91d 100644 --- a/arch/arm/configs/multi_v7_defconfig +++ b/arch/arm/configs/multi_v7_defconfig @@ -193,6 +193,7 @@ CONFIG_I2C_CADENCE=y CONFIG_I2C_DESIGNWARE_PLATFORM=y CONFIG_I2C_EXYNOS5=y CONFIG_I2C_MV64XXX=y +CONFIG_I2C_S3C2410=y CONFIG_I2C_SIRF=y CONFIG_I2C_TEGRA=y CONFIG_SPI=y @@ -231,6 +232,7 @@ CONFIG_MFD_AS3722=y CONFIG_MFD_BCM590XX=y CONFIG_MFD_CROS_EC=y CONFIG_MFD_CROS_EC_SPI=y +CONFIG_MFD_MAX77686=y CONFIG_MFD_MAX8907=y CONFIG_MFD_SEC_CORE=y CONFIG_MFD_PALMAS=y @@ -243,6 +245,7 @@ CONFIG_REGULATOR_AS3722=y CONFIG_REGULATOR_BCM590XX=y CONFIG_REGULATOR_GPIO=y CONFIG_REGULATOR_MAX8907=y +CONFIG_REGULATOR_MAX77686=y CONFIG_REGULATOR_PALMAS=y CONFIG_REGULATOR_S2MPS11=y CONFIG_REGULATOR_S5M8767=y
Enabled S3C24XX I2C driver and MAX77686 PMIC MFD and Voltage regulator drivers used on Exynos5250 based Snow board. Signed-off-by: Naveen Krishna Chatradhi <ch.naveen@samsung.com> --- By enabling the symbols to compile S3C24XX I2C driver, MAX77686 PMIC under MFD and REGULATOR. http://arm-soc.lixom.net/bootlogs/next/next-20140711/snow-multi_v7_defconfig.html The warnings by cpufreq on Snow board are fixed. Booted and verified on on Exynos5420 based Snow board arch/arm/configs/multi_v7_defconfig | 3 +++ 1 file changed, 3 insertions(+)