| Message ID | 1405587689-1466-10-git-send-email-yj44.cho@samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thu, Jul 17, 2014 at 06:01:24PM +0900, YoungJun Cho wrote: > This patch adds DT bindings for s6e3fa0 panel. > The bindings describes panel resources and display timings. The commit message here should preferably say which platform this is used on. > Signed-off-by: YoungJun Cho <yj44.cho@samsung.com> > Acked-by: Inki Dae <inki.dae@samsung.com> > Acked-by: Kyungmin Park <kyungmin.park@samsung.com> > --- > .../devicetree/bindings/panel/samsung,s6e3fa0.txt | 46 ++++++++++++++++++++++ > 1 file changed, 46 insertions(+) > create mode 100644 Documentation/devicetree/bindings/panel/samsung,s6e3fa0.txt > > diff --git a/Documentation/devicetree/bindings/panel/samsung,s6e3fa0.txt b/Documentation/devicetree/bindings/panel/samsung,s6e3fa0.txt > new file mode 100644 > index 0000000..2cd32f5 > --- /dev/null > +++ b/Documentation/devicetree/bindings/panel/samsung,s6e3fa0.txt > @@ -0,0 +1,46 @@ > +Samsung S6E3FA0 AMOLED LCD 5.7 inch panel > + > +Required properties: > + - compatible: "samsung,s6e3fa0" > + - reg: the virtual channel number of a DSI peripheral > + - vdd3-supply: core voltage supply > + - vci-supply: voltage supply for analog circuits > + - reset-gpios: a GPIO spec for the reset pin > + - det-gpios: a GPIO spec for the OLED detection pin > + - te-gpios: a GPIO spec for the TE pin > + - display-timings: timings for the connected panel as described by [1] display-timings should be optional. The panel driver should provide a default mode. And only if you really need to override the default mode you should provide the option of getting an alternative set of values from DT. Thierry
Hi Thierry, On 07/17/2014 07:38 PM, Thierry Reding wrote: > On Thu, Jul 17, 2014 at 06:01:24PM +0900, YoungJun Cho wrote: >> This patch adds DT bindings for s6e3fa0 panel. >> The bindings describes panel resources and display timings. > > The commit message here should preferably say which platform this is > used on. Although only exynos drm could use this panel now, I think this panel could be used by any platform. Do you have any good idea for that? > >> Signed-off-by: YoungJun Cho <yj44.cho@samsung.com> >> Acked-by: Inki Dae <inki.dae@samsung.com> >> Acked-by: Kyungmin Park <kyungmin.park@samsung.com> >> --- >> .../devicetree/bindings/panel/samsung,s6e3fa0.txt | 46 ++++++++++++++++++++++ >> 1 file changed, 46 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/panel/samsung,s6e3fa0.txt >> >> diff --git a/Documentation/devicetree/bindings/panel/samsung,s6e3fa0.txt b/Documentation/devicetree/bindings/panel/samsung,s6e3fa0.txt >> new file mode 100644 >> index 0000000..2cd32f5 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/panel/samsung,s6e3fa0.txt >> @@ -0,0 +1,46 @@ >> +Samsung S6E3FA0 AMOLED LCD 5.7 inch panel >> + >> +Required properties: >> + - compatible: "samsung,s6e3fa0" >> + - reg: the virtual channel number of a DSI peripheral >> + - vdd3-supply: core voltage supply >> + - vci-supply: voltage supply for analog circuits >> + - reset-gpios: a GPIO spec for the reset pin >> + - det-gpios: a GPIO spec for the OLED detection pin >> + - te-gpios: a GPIO spec for the TE pin >> + - display-timings: timings for the connected panel as described by [1] > > display-timings should be optional. The panel driver should provide a > default mode. And only if you really need to override the default mode > you should provide the option of getting an alternative set of values > from DT. Could you explain why this display-timings should be optional? Most of DTs regard display-timings as required property. Thank you. Best regards YJ > > Thierry >
diff --git a/Documentation/devicetree/bindings/panel/samsung,s6e3fa0.txt b/Documentation/devicetree/bindings/panel/samsung,s6e3fa0.txt new file mode 100644 index 0000000..2cd32f5 --- /dev/null +++ b/Documentation/devicetree/bindings/panel/samsung,s6e3fa0.txt @@ -0,0 +1,46 @@ +Samsung S6E3FA0 AMOLED LCD 5.7 inch panel + +Required properties: + - compatible: "samsung,s6e3fa0" + - reg: the virtual channel number of a DSI peripheral + - vdd3-supply: core voltage supply + - vci-supply: voltage supply for analog circuits + - reset-gpios: a GPIO spec for the reset pin + - det-gpios: a GPIO spec for the OLED detection pin + - te-gpios: a GPIO spec for the TE pin + - display-timings: timings for the connected panel as described by [1] + +Optional properties: + +The device node can contain one 'port' child node with one child 'endpoint' +node, according to the bindings defined in [2]. This node should describe +panel's video bus. + +[1]: Documentation/devicetree/bindings/video/display-timing.txt +[2]: Documentation/devicetree/bindings/media/video-interfaces.txt + +Example: + + panel@0 { + compatible = "samsung,s6e3fa0"; + reg = <0>; + vdd3-supply = <&vcclcd_reg>; + vci-supply = <&vlcd_reg>; + reset-gpios = <&gpy7 4 0>; + det-gpios = <&gpg0 6 0>; + te-gpios = <&gpd1 7 0>; + + display-timings { + timings0 { + clock-frequency = <0>; + hactive = <1080>; + vactive = <1920>; + hfront-porch = <2>; + hback-porch = <2>; + hsync-len = <1>; + vfront-porch = <1>; + vback-porch = <4>; + vsync-len = <1>; + }; + }; + };