| Message ID | 1402025761-16831-4-git-send-email-nm@ti.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
* Nishanth Menon <nm@ti.com> [140605 20:37]: > "wkup" event at bit offset 0 exists only on OMAP3. > OMAP4430/60 PRM_IRQSTATUS_A9, OMAP5/DRA7 PRM_IRQSTATUS_MPU > > register bit 0 is DPLL_CORE_RECAL_ST not wakeup event like OMAP3. Hmm so why was it added originally then? Do the PRM_IRQSTATUS line and the following line belong together or is it missing something? Regards, Tony > The same applies to AM437x as well. > > Remove the wrong definition. > > Signed-off-by: Nishanth Menon <nm@ti.com> > --- > arch/arm/mach-omap2/prm44xx.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/arm/mach-omap2/prm44xx.c b/arch/arm/mach-omap2/prm44xx.c > index d4d745e..1ecf244 100644 > --- a/arch/arm/mach-omap2/prm44xx.c > +++ b/arch/arm/mach-omap2/prm44xx.c > @@ -32,7 +32,6 @@ > /* Static data */ > > static const struct omap_prcm_irq omap4_prcm_irqs[] = { > - OMAP_PRCM_IRQ("wkup", 0, 0), > OMAP_PRCM_IRQ("io", 9, 1), > }; > > -- > 1.7.9.5 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-omap" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, Jul 21, 2014 at 5:44 AM, Tony Lindgren <tony@atomide.com> wrote: > > Hmm so why was it added originally then? > > Do the PRM_IRQSTATUS line and the following line belong together > or is it missing something? Seems like to have been a copy paste from OMAP3 code which did have wakeup event at bit 0.
diff --git a/arch/arm/mach-omap2/prm44xx.c b/arch/arm/mach-omap2/prm44xx.c index d4d745e..1ecf244 100644 --- a/arch/arm/mach-omap2/prm44xx.c +++ b/arch/arm/mach-omap2/prm44xx.c @@ -32,7 +32,6 @@ /* Static data */ static const struct omap_prcm_irq omap4_prcm_irqs[] = { - OMAP_PRCM_IRQ("wkup", 0, 0), OMAP_PRCM_IRQ("io", 9, 1), };
"wkup" event at bit offset 0 exists only on OMAP3. OMAP4430/60 PRM_IRQSTATUS_A9, OMAP5/DRA7 PRM_IRQSTATUS_MPU register bit 0 is DPLL_CORE_RECAL_ST not wakeup event like OMAP3. The same applies to AM437x as well. Remove the wrong definition. Signed-off-by: Nishanth Menon <nm@ti.com> --- arch/arm/mach-omap2/prm44xx.c | 1 - 1 file changed, 1 deletion(-)