| Message ID | 1406129207-1302-3-git-send-email-dh.herrmann@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Wed, Jul 23, 2014 at 05:26:37PM +0200, David Herrmann wrote: > This object is unused, drop it. > > Signed-off-by: David Herrmann <dh.herrmann@gmail.com> Funny how after even all my "kill stuff with fire" series there's still such low hanging fruit left ;-) Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch> > --- > include/drm/drmP.h | 17 ----------------- > 1 file changed, 17 deletions(-) > > diff --git a/include/drm/drmP.h b/include/drm/drmP.h > index 335b7b8..d3d9be6 100644 > --- a/include/drm/drmP.h > +++ b/include/drm/drmP.h > @@ -430,23 +430,6 @@ struct drm_file { > struct drm_prime_file_private prime; > }; > > -/** Wait queue */ > -struct drm_queue { > - atomic_t use_count; /**< Outstanding uses (+1) */ > - atomic_t finalization; /**< Finalization in progress */ > - atomic_t block_count; /**< Count of processes waiting */ > - atomic_t block_read; /**< Queue blocked for reads */ > - wait_queue_head_t read_queue; /**< Processes waiting on block_read */ > - atomic_t block_write; /**< Queue blocked for writes */ > - wait_queue_head_t write_queue; /**< Processes waiting on block_write */ > - atomic_t total_queued; /**< Total queued statistic */ > - atomic_t total_flushed; /**< Total flushes statistic */ > - atomic_t total_locks; /**< Total locks statistics */ > - enum drm_ctx_flags flags; /**< Context preserving and 2D-only */ > - struct drm_waitlist waitlist; /**< Pending buffers */ > - wait_queue_head_t flush_queue; /**< Processes waiting until flush */ > -}; > - > /** > * Lock data. > */ > -- > 2.0.2 >
Hi On Wed, Jul 23, 2014 at 9:35 PM, Daniel Vetter <daniel@ffwll.ch> wrote: > On Wed, Jul 23, 2014 at 05:26:37PM +0200, David Herrmann wrote: >> This object is unused, drop it. >> >> Signed-off-by: David Herrmann <dh.herrmann@gmail.com> > > Funny how after even all my "kill stuff with fire" series there's still > such low hanging fruit left ;-) > > Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch> I think the problem is, they all depend on each other. With this patch applied, "drm_waitlist" becomes unused.. noticed it just now. I already have a followup. Thanks David
diff --git a/include/drm/drmP.h b/include/drm/drmP.h index 335b7b8..d3d9be6 100644 --- a/include/drm/drmP.h +++ b/include/drm/drmP.h @@ -430,23 +430,6 @@ struct drm_file { struct drm_prime_file_private prime; }; -/** Wait queue */ -struct drm_queue { - atomic_t use_count; /**< Outstanding uses (+1) */ - atomic_t finalization; /**< Finalization in progress */ - atomic_t block_count; /**< Count of processes waiting */ - atomic_t block_read; /**< Queue blocked for reads */ - wait_queue_head_t read_queue; /**< Processes waiting on block_read */ - atomic_t block_write; /**< Queue blocked for writes */ - wait_queue_head_t write_queue; /**< Processes waiting on block_write */ - atomic_t total_queued; /**< Total queued statistic */ - atomic_t total_flushed; /**< Total flushes statistic */ - atomic_t total_locks; /**< Total locks statistics */ - enum drm_ctx_flags flags; /**< Context preserving and 2D-only */ - struct drm_waitlist waitlist; /**< Pending buffers */ - wait_queue_head_t flush_queue; /**< Processes waiting until flush */ -}; - /** * Lock data. */
This object is unused, drop it. Signed-off-by: David Herrmann <dh.herrmann@gmail.com> --- include/drm/drmP.h | 17 ----------------- 1 file changed, 17 deletions(-)