diff mbox

video: clcd-versatile: Depend on ARM

Message ID 1406480658-27243-1-git-send-email-broonie@kernel.org (mailing list archive)
State New, archived
Headers show

Commit Message

Mark Brown July 27, 2014, 5:04 p.m. UTC 
From: Mark Brown <broonie@linaro.org>

The Versatile CLCD helpers call dma_alloc_writecombine() which is only
available on ARM and AVR32, meaning they won't build on other platforms
including arm64. Unfortunately the current Kconfig enables the symbol
by default if ARCH_VEXPRESS is defined which means that it is enabled on
arm64 when building for the ARM reference platforms and models for ARMv8
since they have many hardware similarities with their pre-ARMv8 systems.

Since all the systems that need the helpers are ARM systems fix this by
adding a dependency on ARM.

Signed-off-by: Mark Brown <broonie@linaro.org>
---
 drivers/video/fbdev/Kconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Arnd Bergmann July 28, 2014, 8:54 a.m. UTC | #1 
On Sunday 27 July 2014 18:04:18 Mark Brown wrote:
> From: Mark Brown <broonie@linaro.org>
> 
> The Versatile CLCD helpers call dma_alloc_writecombine() which is only
> available on ARM and AVR32, meaning they won't build on other platforms
> including arm64. Unfortunately the current Kconfig enables the symbol
> by default if ARCH_VEXPRESS is defined which means that it is enabled on
> arm64 when building for the ARM reference platforms and models for ARMv8
> since they have many hardware similarities with their pre-ARMv8 systems.
> 
> Since all the systems that need the helpers are ARM systems fix this by
> adding a dependency on ARM.
> 
> Signed-off-by: Mark Brown <broonie@linaro.org>

I guess this one is for me, as the bug only exists in linux-next through
arm-soc, introduced by my previous fix for another bug.

Applied to next/cleanup, thanks a lot for fixing it!

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig
index e83ed760141b..ce7c76676a70 100644
--- a/drivers/video/fbdev/Kconfig
+++ b/drivers/video/fbdev/Kconfig
@@ -293,6 +293,7 @@  config FB_ARMCLCD
 # Helper logic selected only by the ARM Versatile platform family.
 config PLAT_VERSATILE_CLCD
 	def_bool ARCH_VERSATILE || ARCH_REALVIEW || ARCH_VEXPRESS
+	depends on ARM
 	depends on FB_ARMCLCD && FB=y
 
 config FB_ACORN